Three fixes. The CHANGELOG has an entry for each.
- Use the git executable set as git_exe
- Read the commit of a node pack whose refs are packed, and bring its
submodules to the commit that is checked out
- Fail an update whose pull or submodule update failed, leave the node pack
at its commit, remove what a clone that failed left, and refuse an install
of a node pack that another install is working on
Port the pip requirement checks of manager-v4 (#3489) to main, so that
both branches decide with the same code. #3431 had only replaced the
version class in main's own checks, which left ">" and "~=" answered
differently from v4.
- Parse requirements with packaging and share one parser and one
downgrade decision between manager_core and the startup check
- Treat '-', '_' and '.' as one separator in package names, in the
installed-package lookup, both lists, requirements and
pip_auto_fix.list (#3458)
- Read every version clause, so a lower bound written first no longer
hides an upper bound; read spaces, parentheses, markers, '===' and
direct references
- Install a requirement with extras unless it would downgrade the
protected package
- Check the requirement of every pip install command form, including
those with --index-url, on the immediate and reserved paths
- Skip a protected package when the requirement cannot be compared and
log why and how to install it
- At startup, recognize an installed package however its requirement
spells the name, install one older than its '~=' version or at the
version that '>' excludes, and stop reinstalling the '~=' version
itself
- Read downgrade_blacklist from config.ini in cm-cli, which read a
path attribute that does not exist and so protected only the
built-in packages
- Remove the unused is_installed copy from manager_core and the
pip_version helper that #3431 added
- Import packaging where it is used, because prestartup_script imports
manager_util before it installs missing dependencies
- Add the tests of #3489, adapted to main, and tests for the startup
loop, '>', pip_auto_fix.list names and the cm-cli setting; update
README and CHANGELOG
manager-v4 needs no counterpart: it has this code since #3489.
fixed: Update all - Properly display the results of the ComfyUI update.
fixed: Update all - An issue where the action results of the custom nodes manager were reflected in the main dialog.
https://github.com/ltdrdata/ComfyUI-Manager/issues/1548
fixed: invalid environment setup for git_helper.py
fixed: default pip overrides doesn't work
modified: git_helper.py - use GIT_EXE_PATH env instead of config.ini
improved: print user_directory and ComfyUI-Manager config path on startup
This commit addresses the NameError that occurs in the get_custom_nodes_paths method of the Ctx class. The error was caused by the folder_paths module not being properly imported or accessible within the static method. The fix involves the following changes:
1. Add a class variable folder_paths to the Ctx class.
2. Import the folder_paths module in the __init__ method using importlib.
3. Update the get_custom_nodes_paths method to use the class variable.
4. Add error handling to gracefully handle cases where the folder_paths module cannot be imported.
These changes ensure that the folder_paths module is properly imported and accessible within the Ctx class, resolving the NameError and improving the overall stability of the ComfyUI-Manager CLI tool.
Co-authored-by: yhayano-ponotech <yhayano.biz@gmail.com>
* Hacky: hide the features we do not want to ship with electron app
* Backup
* Take install path for cm-cli.
* Remove unused.
* Add no deps.
* Add no deps.
* Bypass ComfyUI version check when in electron env
* Fix exception when comfyui is not repo
* Fix version reporting always skipped
* Log unhandled errors
---------
Co-authored-by: Yoland Y <4950057+yoland68@users.noreply.github.com>
Co-authored-by: Robin Huang <robin.j.huang@gmail.com>
- print invalid installation nodes on terminal
(installed by `comfy registryinstall`)
- show only 'reinstall' menu if invalid installation node in gui
(and show INVALID marker)
This allows nodes to be pulled from git repositories that:
1. Require authentication
2. Are located on a computer that does not have any special software
beyond an SSH server to serve up git repos
3. Are hosted on sites that exclusively allow SSH access
I have also cleaned up the JavaScript regex for identifying valid HTTP
addresses. Due to an unescaped '.' and the lack of a count on the first
group, it wasn't doing a whole lot anyway -- just checking that the very
first character wasn't invalid.