Commit Graph
421 Commits
Author SHA1 Message Date
Dr.Lt.Data 9117bce3e1 Fix git_exe, the commit and submodules of a node pack and the git steps of install and update
Three fixes. The CHANGELOG has an entry for each.

- Use the git executable set as git_exe
- Read the commit of a node pack whose refs are packed, and bring its
  submodules to the commit that is checked out
- Fail an update whose pull or submodule update failed, leave the node pack
  at its commit, remove what a clone that failed left, and refuse an install
  of a node pack that another install is working on
2026-11-18 00:10:04 +09:00
Dr.Lt.Data 3a2177fb24 Fix failure answers, console messages and settings (#3543)
Five fixes. The CHANGELOG has an entry for each.

- Log a failed read of the ComfyUI versions instead of raising
- Print the messages of manager_core as they are
- Answer 400 to an install request whose body is not usable
- Refuse a db_mode, update_policy or component_policy request the server cannot use
- Keep a setting chosen while the Manager menu is loading it
2026-11-17 12:39:56 +09:00
Dr.Lt.Data 3bea57137c bump version to 3.43 2026-11-16 00:03:49 +09:00
Perfect Johny 2fc00edf2d Clean up after a registry archive that cannot be extracted (#3433)
_cnr_install creates the directory of the pack and then extracts the
downloaded archive into it. extract_package_as_zip handles a file that
is not a zip; any other error, such as an entry that cannot be written,
left the function through an exception with the new directory and the
archive still in custom_nodes. The next install of the pack found the
directory and stopped with "Install path already exists".

- Catch the error, remove the directory with try_rmtree and return a
  failed result that names the error
- Remove the archive whether the extraction worked or not, and ignore
  a failure to remove it
- Use try_rmtree for an archive that is not a zip as well, where
  shutil.rmtree was called directly
- Log a cleanup that fails as well and still return the failed result,
  at both calls; try_rmtree raises when it can neither remove nor
  schedule the directory, which an uninstall still reports as an error
- Add tests that install from an archive that fails part-way and from
  a file that is not a zip, install again afterwards, install while
  the cleanup fails, and uninstall a pack whose directory cannot be
  removed
- Add a CHANGELOG entry

The same change for manager-v4 is #3533.
2026-11-15 14:40:39 +09:00
Perfect Johny bfd65e7173 Write cache files whole and age them by their last write (#3432)
The cache files of the channel lists and of the registry's node list
were written in place. A write that stopped part-way left a truncated
file, which get_data reads as an empty list.

is_file_created_within_one_day read os.path.getctime. On Windows that
is the creation time, which stays the same when the file is rewritten,
so a cache first created more than a day ago counted as expired however
recently it was written.

- Add write_cache_file, which writes a temporary file beside the cache
  and replaces the cache with it, keeping the mode of the existing
  file. Where the written file cannot be put in place, as on Windows
  while another reader has the cache open, the replace is tried three
  times, 0.1 s apart. A cache that stays open is left as it is, with a
  warning; the caller gets no error and goes on with its data. A
  failure while writing the temporary file leaves the cache as it is
  as well. Where the mode cannot be set, the cache is replaced all the
  same. A temporary file that cannot be removed, because a scanner
  holds it open, is left behind and does not fail the write
- Use it for the four writes of a cache file: two in manager_util, one
  in get_data_by_mode and one in default_cache_update
- Read the modification time for the age
- Add tests for a write that fails and one that runs out of space, the
  mode, a mode that cannot be set, a replace that is refused for a
  moment and one that stays refused, a temporary file that is held
  open, and the age
- Add a CHANGELOG entry

The same change for manager-v4 is #3532.
2026-11-15 14:30:12 +09:00
Perfect Johny 0b3966f050 Compare a snapshot's pins with the installed commit and version (#3426)
Two comparisons in restore_snapshot never matched.

get_commit_hash returned the line of .git/HEAD as it is when HEAD is
detached, with its newline, and the snapshot saved it that way. On
restore the checkout of that text failed, repo_switch_commit returned
None, and the pack was listed as skipped at the commit it had. A pack
is left at a detached HEAD by a restore, so a snapshot taken after one
has this.

For a registry pack, the installed version was compared through v[1],
the path of the pack, where v[0] is the version. Every installed pack
was therefore sent to cnr_switch_version, which asks the registry
before it finds the version unchanged; with the registry out of reach
the request raised and the restore stopped.

- Return the hash without the newline
- Strip the hash read from a snapshot, so the snapshots already saved
  restore too
- Compare the version
- Add tests for the hash, for a pack at the pinned version and at
  another one, and for the checkout of both forms of the hash in a
  real repository

The same change for manager-v4 is #3531.
2026-11-15 11:06:55 +09:00
Perfect Johny 7b61a5cb07 Read pip's exit status when restoring a snapshot's pip packages (#3425)
restore_pip_snapshot kept the return value of subprocess.check_output
as the result of each pip run and compared it with 0. check_output
returns pip's output, never an exit status, so the comparison held for
every run that succeeded: after the one run that installs the packages
named by version, pip was run again for each of them with --no-deps,
and every package of the three groups was reported under "Installation
failed for pip packages".

- Run pip with check_call, which returns the exit status and raises
  when it is not 0
- Add tests that cover the three groups, the fallback after a failed
  run, failures in every group at once, and a group whose option is
  not given

The same change for manager-v4 is #3530.
2026-11-15 10:18:23 +09:00
Dr.Lt.Data 5b9988cd8e Weigh the clauses of a pip requirement together (#3524)
The downgrade decision and the startup check read each clause of a pip
requirement on its own, and did not read "!=". Found by CodeRabbit on
#3521, #3523 and #3524 and in review.

- Install a requirement for a protected package that allows the
  installed version when another clause sets a minimum above it
  ("==4.*,>=4.58.0" beside 4.57.0); it was skipped
- Skip one that the installed version does not meet and that allows no
  newer version ("[torch]<=4.57.0,!=4.57.0", "<4.58,!=4.57.*"); it was
  installed, and pip replaced the package with an older version
- Install one that excludes the installed version with "!=" while a
  newer version is allowed ("~=4.57.0,!=4.57.0"); without extras it
  was skipped
- At startup, read ">" as pip does: a post-release of its version does
  not meet it, and the requirement is installed when a newer version
  meets every clause
- At startup, take "==0.21.*" as met by an installed 0.21.0rc1, as pip
  does
- At startup, install a requirement that excludes the installed
  version with "!=" and allows a newer one; pip chooses the version,
  which is an older one when no newer release exists
- Ask packaging whether a newer version meets every clause, about the
  versions next to the installed one and next to each clause's version;
  a pre-release counts only when "==", ">=", "<=", "~=" or "===" names
  one, which is when every pip takes one
- Never replace an installed local build, such as a CUDA build, on
  these grounds, and keep a protected one that "!=" excludes unless
  the requirement sets a minimum above it: for such a build the
  changes only add requirements that are skipped
- Add tests and a CHANGELOG entry

The same change for manager-v4 is #3523.
2026-11-14 21:29:46 +09:00
Dr.Lt.Data 1ad89f69cd Apply pip blacklists however a requirement is written (#3521)
Port the pip requirement checks of manager-v4 (#3489) to main, so that
both branches decide with the same code. #3431 had only replaced the
version class in main's own checks, which left ">" and "~=" answered
differently from v4.

- Parse requirements with packaging and share one parser and one
  downgrade decision between manager_core and the startup check
- Treat '-', '_' and '.' as one separator in package names, in the
  installed-package lookup, both lists, requirements and
  pip_auto_fix.list (#3458)
- Read every version clause, so a lower bound written first no longer
  hides an upper bound; read spaces, parentheses, markers, '===' and
  direct references
- Install a requirement with extras unless it would downgrade the
  protected package
- Check the requirement of every pip install command form, including
  those with --index-url, on the immediate and reserved paths
- Skip a protected package when the requirement cannot be compared and
  log why and how to install it
- At startup, recognize an installed package however its requirement
  spells the name, install one older than its '~=' version or at the
  version that '>' excludes, and stop reinstalling the '~=' version
  itself
- Read downgrade_blacklist from config.ini in cm-cli, which read a
  path attribute that does not exist and so protected only the
  built-in packages
- Remove the unused is_installed copy from manager_core and the
  pip_version helper that #3431 added
- Import packaging where it is used, because prestartup_script imports
  manager_util before it installs missing dependencies
- Add the tests of #3489, adapted to main, and tests for the startup
  loop, '>', pip_auto_fix.list names and the cm-cli setting; update
  README and CHANGELOG

manager-v4 needs no counterpart: it has this code since #3489.
2026-11-14 18:14:54 +09:00
Dr.Lt.Data c4c5c7f943 Fix lists failing after a channel response that is not JSON (#3518)
get_data returned {} when a channel answered with something that is
not JSON, such as a block page or "404: Not Found". get_data_by_mode
and the startup cache update wrote that {} to the cache, and the
custom node list and the model list then failed on the missing key
for as long as the cached {} was read, up to a day.

Raise for such a response, as for a failed connection. The callers
already handle that: get_data_by_mode falls back to the bundled file,
and nothing is written to the cache.

- Add tests
- Add a CHANGELOG entry

The manager-v4 port is #3519. Refs #3480.
2026-11-14 17:11:47 +09:00
Perfect Johny 41b6f19931 Read node pack and pip versions that carry a suffix (#3431)
StrictVersion read each of the first three components of a version
with int(), so it raised on a suffix after the third number. On main
it read node pack versions and pip versions alike.

- Read a node pack version with a pre-release after the third number,
  following '.' or '-', and write it with '-' as before: a registry
  version such as 1.8.0-beta.1 is recognized, and 0.1.3.post1 no
  longer stops the scan of installed node packs
- Compare pip versions with packaging in is_blacklisted and
  is_installed of manager_core and in is_installed of
  prestartup_script: an installed 2.5.1+cu124 or 4.41.0rc1 no longer
  raises, which at the next start skipped the rest of a node pack's
  requirements and its install.py
- Ask a packaging Specifier for the entries of pip_auto_fix.list, as
  pip does; "~=" becomes a compatible-release clause
- Import packaging where it is used, because prestartup_script imports
  manager_util before it installs missing dependencies
- Add tests that run the real scan and the real pip checks
- Add a CHANGELOG entry

The same change for manager-v4 is #3516. Fixes #1755.
2026-11-14 15:32:01 +09:00
Perfect Johny 443f7c5b84 Share only a file inside the output directory to Matrix (#3427)
The share route joined the file name and subfolder of the selected
output, both taken from the request, onto the output or temp directory
and uploaded that file to the Matrix homeserver named in the same
request. A name such as "../../file" left the directory, so a request
could have any file that ComfyUI can read uploaded.

- Refuse, with 400 and the error shape the share dialog shows, a path
  that is not inside the directory
- Compare the normalized path without resolving symlinks, as ComfyUI's
  /view does, and open that same path, so an image that the dialog
  previews through a symlink in the directory can still be shared
- Refuse a path on another Windows drive, for which commonpath raises
  ValueError
- Add tests that run the real route against a recording Matrix client
- Add a CHANGELOG entry

The same change for manager-v4 is #3515.
2026-11-14 14:46:32 +09:00
Perfect Johny 54e4ee5977 Read workflow files as UTF-8 when collecting node types (#3510)
get_node_types_in_workflows opened workflow files with the locale
encoding. On a non-UTF-8 locale, such as a Windows ANSI code page, a
UTF-8 workflow either failed to decode and was skipped with a
warning, or was read with garbled non-ASCII node type names. Read
with utf-8-sig, which takes files with and without a BOM.

A workflow file saved in the ANSI code page is no longer read.
ComfyUI saves workflows as UTF-8.

Fixes #3441
2026-11-14 12:39:34 +09:00
Perfect Johny 94abb6175c Reject form POSTs to update_all before the autosave snapshot (#3429)
update_all wrote the autosave snapshot before it read the request
body, so a cross-origin <form method=POST>, which needs no CORS
preflight, reached the snapshot write. Reject the simple form
Content-Types first, as the handlers without a body do, and describe
the scope of the gate in the helper docstring.

A client that sends the JSON body with a form Content-Type, such as
curl -d without a Content-Type header, now gets 400.
2026-11-14 11:26:43 +09:00
Perfect Johny 3ab17e228e Match the download url in the model whitelist (#3428)
check_whitelist_for_model compared save_path, base and filename with
the model list, but not the url the file is downloaded from, so a
request with a listed name and another url was queued as given.
Compare the url too.
2026-11-13 20:27:02 +09:00
Perfect Johny e66b7b71c7 Verify the TLS certificate when fetching the notice (#3424)
The notice route fetched the News page from GitHub with
verify_ssl=False, so certificate verification was off for every user:
whoever sat on the connection could present any certificate for
github.com and choose the notice text and links. The sanitizer limits
the markup, but it cannot tell whose content it is.

- Turn verification off for the notice only when bypass_ssl is set, as
  manager_util.get_data does
- Answer a certificate or connection failure with "Unable to retrieve
  Notice" where it raised and the notice area showed the server's 500
  page
- Add tests that run get_notice against a local HTTPS server behind a
  local CONNECT proxy: an untrusted certificate and a trusted
  certificate for another host are rejected; bypass_ssl accepts the
  untrusted certificate; a CA trusted through SSL_CERT_FILE is
  accepted; a closed proxy, a proxy answering 502 and a proxy that
  never answers end in the unavailable notice, each with one warning
  naming the cause
- Add a CHANGELOG entry

Fixes #3302
2026-11-13 08:19:55 +09:00
Dr.Lt.Data ea0b0f5864 v3: Remove share destinations that no longer accept workflows (#3501)
Four of the six share destinations are gone: the comfyworkflows.com
domain registration has expired, the Copus API answers 410 "ComfyUI
direct publishing is no longer supported", the OpenArt workflow API and
pages return 404 or redirect to the home page, and esheep.com no longer
resolves. Manager still offered them, and the ComfyWorkflows flow would
hand the share key, the workflow and the installed snapshot to whoever
answers at that domain next.

- Remove ComfyWorkflows, Copus, OpenArt and eSheep from the share
  chooser, the Share setting, the Workflow Gallery menu and the share
  dialog, with their server routes, the two dialog modules and what the
  Copus theme added to the chooser
- Treat a saved Share setting that names a removed site as All, and do
  not open a removed site saved as the last visited Workflow Gallery
- Sharing to YouML and to Matrix is unchanged; the share request no
  longer carries cw_auth or is_nsfw, which only ComfyWorkflows used
- Update README and CHANGELOG, drop the tests of the removed code, and
  keep a single-quoted href under test through the update-result links
2026-11-12 21:47:38 +09:00
Pablo Apiolazza ecc09f1a12 Fix restart losing quotes around arguments that contain spaces (#3488)
os.execv on Windows joins its arguments with spaces and quotes nothing, so
only the interpreter and script path (quoted by hand) survived a restart.
Any other argument with a space, e.g. --browser-profile "Profile 1", was
split in two and ComfyUI failed to start with 'unrecognized arguments'.

Build the command in one helper, manager_util.build_restart_command, used by
both the reboot endpoint and the prestartup restart. On Windows every entry
is quoted with subprocess.list2cmdline; other platforms are unchanged.

Fixes #3339
2026-11-12 18:06:37 +09:00
Dr.Lt.Data 946ef8fe65 bump version to 3.42 2026-09-19 08:38:42 +09:00
Dr.Lt.Data 572f363696 v3: Prevent HTML and URL injection in the Manager UI (#3296) 2026-09-19 08:22:26 +09:00
Dr.Lt.Data ea7534fae8 v3: Restrict Flagged CNR installs on non-local listeners (#3298) 2026-09-19 07:47:20 +09:00
Dr.Lt.Data aaed26a5a4 fix(config): merge write_config() onto disk instead of rebuilding from the startup snapshot (#3128)
write_config() rebuilt config.ini's [default] section entirely from the
startup snapshot into a fresh parser opened 'w'. Any Manager settings
change therefore silently reverted values hand-edited while ComfyUI was
running (the same config['default'] flags those messages tell users to
edit), deleted the two read-but-never-written keys (http_channel_enabled,
default_cache_as_channel_url), and erased every non-[default] section.

get_config() now tracks which keys callers actually change, and
write_config() re-reads config.ini and overlays only those keys plus the
live preview_method. After a successful write the just-persisted keys are
cleared from the tracker, so a key changed once through the UI does not
stay dirty for the life of the process and re-clobber a later hand-edit of
that same key on the next unrelated write. Hand-edited values, unknown
keys, and foreign sections survive; CRLF sanitization still applies to
every value written; an unparsable config.ini falls back to a full rewrite
instead of failing every settings endpoint.

configparser.read() suppresses OSError, so a config.ini that exists but
cannot be read comes back as an empty parser rather than an exception,
which would silently route the merge into the bootstrap branch and rewrite
the file from defaults. write_config() now detects that case (the file
exists but read() loaded nothing) and refuses the write with a raised
error, leaving the file untouched, rather than destroying its contents
while reporting success.

tests/test_write_config_persistence.py pins the three loss classes
(hand-edit revert, key deletion, section erasure), the settings
round-trip, the persisted-key re-clobber guard, and the silent-read-failure
refusal.
2026-08-14 06:31:38 +09:00
Dr.Lt.Data ffb2f03e92 fix(security-messages): state the actual gate in install-denial messages (#3128)
The install-denial diagnostics named the wrong gate, sending users to
settings that could not resolve their denial:

- SECURITY_MESSAGE_FLAG_GIT_URL / _FLAG_PIP omitted the loopback half of
  the flag-AND-loopback predicate, telling users to enable a flag that
  was often already enabled. They now state both conditions, print the
  live --listen value at every emission site, and explain that both
  values are read once at startup (stop the server, edit, then start).
- SECURITY_MESSAGE_MIDDLE_OR_BELOW instructed setting security_level to
  'middle', a value that does not exist; it now names only real values
  (any level other than 'strong': normal, normal-, weak).
- The blocked-risk arm reused SECURITY_MESSAGE_GENERAL, blaming
  security_level although no value of it can help there; it now emits a
  dedicated SECURITY_MESSAGE_BLOCKED_RISK stating this is not a
  configuration problem.
- SECURITY_MESSAGE_NORMAL_MINUS_MODEL now names its loopback-listener
  condition and the same restart guidance.
- The js/common.js dedicated-403 messages mirror the loopback clause.
2026-08-13 12:38:11 +09:00
Rvage 25f519ed0c Fix: tooltip global listener (#3114)
* remove noise

* fix: remove global tooltip listener
2026-08-02 15:08:27 +09:00
dehypnotic e634489a97 Update manager_server.py 2026-07-20 23:45:17 +02:00
Dr.Lt.Data 79dd5e2358 Merge pull request #2152 from jfcantu/main
New feature: Node Usage Analyzer
2026-07-20 20:13:04 +09:00
Dr.Lt.Data e4c5401dd5 feat(security): dedicated install flags decoupled from security_level (#2991)
* feat(security): add dedicated install flags decoupled from security_level

Gate 'install via git URL' and 'install via pip' with dedicated opt-in
boolean flags (allow_git_url_install / allow_pip_install) in config.ini
[default], fully replacing the security_level term on those surfaces
(REPLACE, not AND — a strict level no longer denies when the flag is on;
a weak level no longer allows when the flag is off).

- glob/manager_server.py: pure predicate is_dedicated_install_allowed
  (flag AND loopback, request-time args.listen); REPLACE gates at
  /customnode/install/git_url and /customnode/install/pip; batch
  unknown-URL arm routes through the same full predicate at the risky
  position (loopback term is load-bearing — the middle entry gate has
  no network-position term; the entry gate itself stays in force);
  unknown-pip in batch stays unconditionally blocked; new
  SECURITY_MESSAGE_FLAG_* denial constants name the responsible flag;
  security_403_response gains flag_token (comfyui_outdated keeps precedence)
- glob/manager_core.py: register both keys (read via get_bool default-false,
  write list, exception fallback); "true"-only truthy; restart-only activation
- js/common.js: 403 dialog copy names the responsible flag at the two
  install call sites
- README.md: security-policy docs for both flags (per-surface scope incl.
  the batch entry-gate qualifier, REPLACE decoupling, loopback bound,
  opt-in config snippet, default-deny + migration note); stale tier lists
  corrected against the actual gates
- CHANGELOG.md: opt-in migration note + accepted residual risk (flags
  bypass the forced-strong outdated-ComfyUI hardening on loopback,
  opt-in only), decoupling claim qualified for the batch entry gate

Tests: unit suite (predicate truth table, REPLACE litmus both directions,
AST binding-proofs against live handlers, subprocess-isolated config
contract) plus a real-server E2E suite that mounts the Manager-under-test
via git worktree (exact-SHA pin, detached) against a real ComfyUI and
exercises both flag surfaces and both arms — deny arms (403 + flag-naming
body/log + no install artifact), git-URL allow arm (real clone), pip allow
arm as a two-phase reservation oracle — with zero-residual self-clean.
Module skips without E2E_COMFYUI_ROOT; unit suite unaffected.

The manager-v4 branch ships the identical policy (shared invariants +
config contract); this tree uses the degraded predicate 'flag AND
loopback' (no personal_cloud-equivalent mode here).

* bump version to v3.41
2026-06-16 03:34:10 +09:00
Dr.Lt.Data 491f847bbc fix(security): harden CSRF with Content-Type gate and OpenAPI sync (#2819)
Defense-in-depth over GET→POST alone: reject the three CORS-safelisted
simple-form Content-Types (x-www-form-urlencoded, multipart/form-data,
text/plain) on 5 no-body POST handlers (snapshot/save,
manager/queue/{reset,start,update_comfyui}, manager/reboot) to block
<form method=POST> CSRF that bypasses method-only gating. Convert 10 pure
state-changing endpoints (fetch_updates, queue/{update_all,reset,start,
update_comfyui}, snapshot/{remove,restore,save}, comfyui_switch_version,
reboot) from GET to POST and split 5 config endpoints
(db_mode/preview_method/channel_url_list/policy/{component,update}) into
GET(read) + POST(write, JSON body). Emit the in_progress + done event pair
from the /manager/queue/install sync-enable fast-path so client UI
finalizes (previously only queue/start's empty worker done fired, leaving
item.restart unset and the Enable button visible after a successful enable).
Harden js/custom-nodes-manager.js completion path: await onQueueCompleted
with try/catch (surfaces silent turbogrid stale-item throws), replace the
{}.length == 0 no-op empty guard, set install_context before queue/install
to avoid a sync-completion race, wrap classList/updateCell in try/catch.
Resynchronize openapi.yaml with the converted routes (method → post, query
params → requestBody JSON schema, sibling post on 5 split endpoints).
Update 31 JS fetchApi call sites across 7 files; add
tests/test_csrf_content_type_helper.py covering 5 Content-Type cases via
aiohttp TestClient.

Reported-by: XlabAI Team of Tencent Xuanwu Lab
CVSS: 8.1 (AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:H)
2026-04-22 05:04:07 +09:00
Dr.Lt.Data 2007eab26d fix(security): add litellm supply chain attack detection and improve pip matching (#2731)
- Add litellm==1.82.7 and litellm==1.82.8 to blacklist (PYSEC-2026-2)
- Add ultralytics==8.3.42 to blacklist
- Replace substring matching with exact version set matching
- Remove early break to detect multiple malicious packages
2026-03-26 04:17:46 +09:00
Dr.Lt.Data f4fa394e0f fix(security): add input sanitization and path traversal protection
- Sanitize config string values to prevent CRLF injection attacks
- Add get_safe_snapshot_path() helper to validate snapshot targets
- Block path traversal attempts in remove_snapshot and restore_snapshot endpoints
- Reject targets containing /, \, .., or null characters
2026-01-08 18:29:14 +09:00
Dr.Lt.Data 10f3b6551c bump version 2026-01-08 01:22:59 +09:00
Dr.Lt.Data f4fdd51ce9 feat(preview): disable Manager preview method when ComfyUI native feature is available
- Add detection for ComfyUI PR #11261 (per-queue preview override)
- Return DISABLED status when native feature is detected
- Improve UI loading state and prevent flash of enabled state
- Add accessibility attributes and visual feedback for disabled state
- Show user notification when feature transitions to native
- Version bump to 3.39
2025-12-19 23:05:52 +09:00
John Cantu 1bdcd1bdbf Merge branch 'main' of https://github.com/jfcantu/ComfyUI-Manager 2025-12-14 18:11:34 -08:00
Dr.Lt.Data d8f111a5e3 bump version 2025-12-12 18:16:51 +09:00
ae5565ce68 ComfyUI version listing + nightly current fix (#2334)
* Improve comfyui version listing

* Fix ComfyUI semver selection and stable update

* Fix nightly current detection on default branch

* Fix: use tag_ref.name explicitly and cache get_remote_name result

- Use tag_ref.name instead of tag_ref object for checkout
- Cache get_remote_name() result to avoid duplicate calls

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Dr.Lt.Data <dr.lt.data@gmail.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-12 18:15:12 +09:00
Dr.Lt.Data 891005bcd3 fix(git): handle divergent branches safely during pull
- Use --ff-only flag to detect non-fast-forward situations
- Create backup branch before resetting divergent local branch
- Reset to remote branch when fast-forward is not possible
- Use time.strftime() instead of datetime for better compatibility
- Bump version to 3.38.2
2025-12-12 12:22:42 +09:00
Dr.Lt.Data 4249ac193a improved: display a more user-friendly message 2025-12-05 07:01:01 +09:00
Dr.Lt.Data aaed1dc3d5 feat(security): Support System User Protection API with security migration (V3.38) (#2338)
- Migrate Manager data path: default/ComfyUI-Manager → __manager
- Force security_level=strong on outdated ComfyUI (block installations)
- Auto-migrate config.ini only; backup legacy files for manual verification
- Raise weak/normal- to normal during migration
- Add /manager/startup_alerts API for UI warnings
- Differentiate 403 responses: comfyui_outdated vs security_level
- Block startup scripts execution on old ComfyUI

Requires ComfyUI v0.3.76+ for full functionality.
Backward compatible with older versions (uses legacy path).
2025-12-03 00:42:12 +09:00
Dr.Lt.Data e4a90089ab fixed: a bug where updating ComfyUI using Update: ComfyUI Stable Version did not updating ComfyUI's dependencies 2025-11-26 21:54:28 +09:00
Dr.Lt.Data aedc99cefd bump version 2025-11-11 00:42:32 +09:00
unclepomedev b32cab6e9a Fix: Gracefully handle errors during pip package enumeration (#2266) 2025-11-11 00:41:16 +09:00
Dr.Lt.Data 48ab48cc30 fixed: more complete uv support
* Previously, only `uv` installed inside a venv was properly handled. Now `uv` installed outside the venv is also supported.
* Even if `use_uv=False`, `uv` is used as a fallback when `pip` is unavailable.
* Even if `use_uv=True`, `pip` is used as a fallback when `uv` is unavailable.

https://github.com/Comfy-Org/ComfyUI-Manager/issues/2125
2025-09-17 06:28:06 +09:00
John Cantu 02aa67b541 Merge branch 'main' of https://github.com/jfcantu/ComfyUI-Manager 2025-09-14 22:52:41 -07:00
John Cantu 67d03530a3 Changes and new code for Node Usage Analyzer 2025-09-14 22:49:54 -07:00
Dr.Lt.Data 5ed6d8b202 update DB 2025-09-06 03:53:56 +09:00
Dr.Lt.Data eab6cdeee4 bump version 2025-08-11 12:48:38 +09:00
Dr.Lt.Data 4834874091 fixed: ruff check 2025-07-25 07:26:48 +09:00
Dr.Lt.Data 8759ebf200 bump version 2025-07-25 07:03:14 +09:00
YAN Wenkun d4715aebef Migrate matrix-client to matrix-nio (#2025) 2025-07-25 06:59:46 +09:00
Dr.Lt.Data 4a1e76730a fixed: security_check - robust checking
https://github.com/Comfy-Org/ComfyUI-Manager/issues/2002
2025-07-24 02:44:43 +09:00