Three fixes. The CHANGELOG has an entry for each.
- Use the git executable set as git_exe
- Read the commit of a node pack whose refs are packed, and bring its
submodules to the commit that is checked out
- Fail an update whose pull or submodule update failed, leave the node pack
at its commit, remove what a clone that failed left, and refuse an install
of a node pack that another install is working on
Two comparisons in restore_snapshot never matched.
get_commit_hash returned the line of .git/HEAD as it is when HEAD is
detached, with its newline, and the snapshot saved it that way. On
restore the checkout of that text failed, repo_switch_commit returned
None, and the pack was listed as skipped at the commit it had. A pack
is left at a detached HEAD by a restore, so a snapshot taken after one
has this.
For a registry pack, the installed version was compared through v[1],
the path of the pack, where v[0] is the version. Every installed pack
was therefore sent to cnr_switch_version, which asks the registry
before it finds the version unchanged; with the registry out of reach
the request raised and the restore stopped.
- Return the hash without the newline
- Strip the hash read from a snapshot, so the snapshots already saved
restore too
- Compare the version
- Add tests for the hash, for a pack at the pinned version and at
another one, and for the checkout of both forms of the hash in a
real repository
The same change for manager-v4 is #3531.
- Set ConfigParser strict mode to False
- Resolves issue #1529 by permitting section duplicates
- Allow `vscode-merge-base` to appear multiple times in `.git/config`