Five fixes. The CHANGELOG has an entry for each.
- Log a failed read of the ComfyUI versions instead of raising
- Print the messages of manager_core as they are
- Answer 400 to an install request whose body is not usable
- Refuse a db_mode, update_policy or component_policy request the server cannot use
- Keep a setting chosen while the Manager menu is loading it
The server reports the end of every queue with two dicts,
nodepack_result and model_result, keyed by the id of each task. The
Model Manager read model_result as an array, so result.length was
undefined, the guard for an empty result never held, and the end of
any queue ended its pending install. After a model install request
that the server refused, the end of the next queue, such as a node
pack install, asked to click Refresh and raised the notice that all
model downloads were completed, although no model had been installed.
- Count the keys of model_result in the guard and in the status text
- Hide the Stop button when the install is completed, not at the end
of every queue
- When a queue ends without a model result, ask the server what is
left: while tasks are left the install stays pending, and with none
left the dialog returns to idle without a message. An install that
started while the server was asked is left alone
- Show the Stop button only while the install that was queued is
still pending; a queue can end before its start request is answered
- Add tests that run the shipped handlers in node
- Add a CHANGELOG entry
The change for manager-v4, which tells the batches apart by their id,
is #3536.
When the server refuses to restore or remove a snapshot with status
400, the Snapshot Manager showed "Restore snapshot failed: undefined /
ReferenceError: exception is not defined", for a removal too, and after
a refused restore it still asked for a restart. The handler built its
message from target.title and exception: target is the snapshot's name,
a string, and exception is not defined there, so the line threw and the
catch block reported that error. Any other error status, such as a 502
from a proxy, was taken as success.
- Show the snapshot's name and the reason, both escaped, for every
answer that is not a success. The reason is the text of a text/plain
response, and otherwise the status line
- Show the restart notice only after a restore that was accepted
- Say "Remove snapshot failed" when a removal fails
- Add tests that run the shipped restore and removal against the
server's answers
- Add a CHANGELOG entry
The same change for manager-v4 is #3535.
The preview that the Custom Nodes Manager shows over a node name is
built from ComfyUI's node definitions (/object_info) and inserted with
innerHTML. The name, the input and output names, the default values
and the description went in as they are, so text between angle
brackets was dropped from the preview and markup in a definition was
rendered.
- Escape the eight values where createNodePreview inserts them; the
line break of a multi-line default is still shown as <br>
- Add tests that run the shipped createNodePreview in node with a
definition that carries markup, and one that carries text between
angle brackets, in every value the preview shows
- Add a CHANGELOG entry
The same change for manager-v4 is #3534.
When an extension asks through cm.try-install-custom-node for a node
pack that is disabled, the user is asked whether to enable it and
restart. On confirmation the handler posted to
/customnode/toggle_active, which the server does not have, did not
look at the answer, and restarted: ComfyUI came back with the pack
still disabled.
- Enable the pack as the Custom Nodes Manager does: find its row in
/customnode/getlist, put it in the queue, start the queue, and wait
for the queue to report the pack
- Restart only when the queue reports success; otherwise show why the
pack was not enabled
- Leave a queue that is already running alone
- End the wait when the started queue reports without the pack, or
does not report within a minute; a listener left waiting would take
a later report for the same row and restart ComfyUI unasked
- Show the reason when a request made while enabling gets no answer
- Show "Rebooting..." when the restart request gets no answer, which
is what happens when ComfyUI restarts
- Remove the branch for a pack that is not installed: the server does
not send this request for one, and the route it posted to does not
exist
- Leave the queue listener of the Manager menu when the menu has not
been created; a queue started from here made it raise
- Add browser tests of the handler and of the menu listener
- Add a CHANGELOG entry
The same change for manager-v4 is #3526.
installNodeWithVersion interpolated the node id into
/customnode/versions/{id} and /customnode/disabled_versions/{id}
unencoded. Only registry ids reach these fetches, since a pack with
an 'unknown' version never opens the version dialog, and for them the
request URL is unchanged. Encode the id so it stays a single path
segment regardless.
"Fix node (recreate)" looked a node's links, and the nodes at their
other end, up in app.graph, the root graph. A subgraph keeps its own
links and nodes, so inside a subgraph the lookup found nothing: the
entry threw "Cannot read properties of undefined" and, because the
original is removed only afterwards, left the wired original and an
unwired replacement on the canvas.
- Read links and nodes from the graph the node is in
- Reconnect a link that starts at an input of the subgraph, or ends at
one of its outputs, through that slot; those two are not nodes of
the graph
- For a link from a subgraph input, skip an input the new node does
not have or has with a type that does not fit, as connect() does for
a link from a node; a subgraph input's connect() checks neither
- Add a CHANGELOG entry
Follow-up to #3443. The manager-v4 port, #3512, carries the browser
test.
Four of the six share destinations are gone: the comfyworkflows.com
domain registration has expired, the Copus API answers 410 "ComfyUI
direct publishing is no longer supported", the OpenArt workflow API and
pages return 404 or redirect to the home page, and esheep.com no longer
resolves. Manager still offered them, and the ComfyWorkflows flow would
hand the share key, the workflow and the installed snapshot to whoever
answers at that domain next.
- Remove ComfyWorkflows, Copus, OpenArt and eSheep from the share
chooser, the Share setting, the Workflow Gallery menu and the share
dialog, with their server routes, the two dialog modules and what the
Copus theme added to the chooser
- Treat a saved Share setting that names a removed site as All, and do
not open a removed site saved as the last visited Workflow Gallery
- Sharing to YouML and to Matrix is unchanged; the share request no
longer carries cw_auth or is_nsfw, which only ComfyWorkflows used
- Update README and CHANGELOG, drop the tests of the removed code, and
keep a single-quoted href under test through the update-result links
* Reload components on clear of any root graph
ComfyUI_frontend is moving to one LGraph instance per workflow tab
(Comfy-Org/ComfyUI_frontend#21571), and app.clean() clears the new graph
before any extension hook fires. The instance patch on app.graph.clear
only reaches the graph that existed at startup, so components would not
be reloaded for later workflows.
Patch clear on the graph prototype and reload components when the
cleared graph is the current root graph. This also stops a subgraph
clear from clearing the root graph, which the old wrapper did by always
calling orig_clear on app.graph.
Amp-Thread-ID: https://ampcode.com/threads/T-d545a10a-f002-4dc5-9a74-f6402a836919
* Apply suggestion from @DrJKL
The dialog renders HTML, so run the server body and the pack title
(registry-derived) through the existing sanitizeHTML() at both sites. The
title is wrapped in String() so a missing title can't throw inside the error
handler; rendered text is unchanged for ordinary values.
The batch install/uninstall paths replaced the server's 404 body with a
false "default channel" lead. Drop the 404 branch so a 404 falls through to
the existing server-text path; uninstall never returns 404 anyway. Fixes
#3128 (section 1), reported by plz12345.
The install-denial diagnostics named the wrong gate, sending users to
settings that could not resolve their denial:
- SECURITY_MESSAGE_FLAG_GIT_URL / _FLAG_PIP omitted the loopback half of
the flag-AND-loopback predicate, telling users to enable a flag that
was often already enabled. They now state both conditions, print the
live --listen value at every emission site, and explain that both
values are read once at startup (stop the server, edit, then start).
- SECURITY_MESSAGE_MIDDLE_OR_BELOW instructed setting security_level to
'middle', a value that does not exist; it now names only real values
(any level other than 'strong': normal, normal-, weak).
- The blocked-risk arm reused SECURITY_MESSAGE_GENERAL, blaming
security_level although no value of it can help there; it now emits a
dedicated SECURITY_MESSAGE_BLOCKED_RISK stating this is not a
configuration problem.
- SECURITY_MESSAGE_NORMAL_MINUS_MODEL now names its loopback-listener
condition and the same restart guidance.
- The js/common.js dedicated-403 messages mirror the loopback clause.
* feat(security): add dedicated install flags decoupled from security_level
Gate 'install via git URL' and 'install via pip' with dedicated opt-in
boolean flags (allow_git_url_install / allow_pip_install) in config.ini
[default], fully replacing the security_level term on those surfaces
(REPLACE, not AND — a strict level no longer denies when the flag is on;
a weak level no longer allows when the flag is off).
- glob/manager_server.py: pure predicate is_dedicated_install_allowed
(flag AND loopback, request-time args.listen); REPLACE gates at
/customnode/install/git_url and /customnode/install/pip; batch
unknown-URL arm routes through the same full predicate at the risky
position (loopback term is load-bearing — the middle entry gate has
no network-position term; the entry gate itself stays in force);
unknown-pip in batch stays unconditionally blocked; new
SECURITY_MESSAGE_FLAG_* denial constants name the responsible flag;
security_403_response gains flag_token (comfyui_outdated keeps precedence)
- glob/manager_core.py: register both keys (read via get_bool default-false,
write list, exception fallback); "true"-only truthy; restart-only activation
- js/common.js: 403 dialog copy names the responsible flag at the two
install call sites
- README.md: security-policy docs for both flags (per-surface scope incl.
the batch entry-gate qualifier, REPLACE decoupling, loopback bound,
opt-in config snippet, default-deny + migration note); stale tier lists
corrected against the actual gates
- CHANGELOG.md: opt-in migration note + accepted residual risk (flags
bypass the forced-strong outdated-ComfyUI hardening on loopback,
opt-in only), decoupling claim qualified for the batch entry gate
Tests: unit suite (predicate truth table, REPLACE litmus both directions,
AST binding-proofs against live handlers, subprocess-isolated config
contract) plus a real-server E2E suite that mounts the Manager-under-test
via git worktree (exact-SHA pin, detached) against a real ComfyUI and
exercises both flag surfaces and both arms — deny arms (403 + flag-naming
body/log + no install artifact), git-URL allow arm (real clone), pip allow
arm as a two-phase reservation oracle — with zero-residual self-clean.
Module skips without E2E_COMFYUI_ROOT; unit suite unaffected.
The manager-v4 branch ships the identical policy (shared invariants +
config contract); this tree uses the degraded predicate 'flag AND
loopback' (no personal_cloud-equivalent mode here).
* bump version to v3.41
Defense-in-depth over GET→POST alone: reject the three CORS-safelisted
simple-form Content-Types (x-www-form-urlencoded, multipart/form-data,
text/plain) on 5 no-body POST handlers (snapshot/save,
manager/queue/{reset,start,update_comfyui}, manager/reboot) to block
<form method=POST> CSRF that bypasses method-only gating. Convert 10 pure
state-changing endpoints (fetch_updates, queue/{update_all,reset,start,
update_comfyui}, snapshot/{remove,restore,save}, comfyui_switch_version,
reboot) from GET to POST and split 5 config endpoints
(db_mode/preview_method/channel_url_list/policy/{component,update}) into
GET(read) + POST(write, JSON body). Emit the in_progress + done event pair
from the /manager/queue/install sync-enable fast-path so client UI
finalizes (previously only queue/start's empty worker done fired, leaving
item.restart unset and the Enable button visible after a successful enable).
Harden js/custom-nodes-manager.js completion path: await onQueueCompleted
with try/catch (surfaces silent turbogrid stale-item throws), replace the
{}.length == 0 no-op empty guard, set install_context before queue/install
to avoid a sync-completion race, wrap classList/updateCell in try/catch.
Resynchronize openapi.yaml with the converted routes (method → post, query
params → requestBody JSON schema, sibling post on 5 split endpoints).
Update 31 JS fetchApi call sites across 7 files; add
tests/test_csrf_content_type_helper.py covering 5 Content-Type cases via
aiohttp TestClient.
Reported-by: XlabAI Team of Tencent Xuanwu Lab
CVSS: 8.1 (AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:H)
handleFile signature is updated in ComfyUI frontend [handleFile (file: File, openSource?: WorkflowOpenSource, options?: { deferWarnings?: boolean } )]. Using rest parameters to fix and future-proof.
- Add detection for ComfyUI PR #11261 (per-queue preview override)
- Return DISABLED status when native feature is detected
- Improve UI loading state and prevent flash of enabled state
- Add accessibility attributes and visual feedback for disabled state
- Show user notification when feature transitions to native
- Version bump to 3.39
* Started changing UI to match the rest of ComfyUI
Completed Main Container
* - Added layout formatting to components of the Manager dialog box
- Pulled name from select and put it into a label (eg "DB: Channel" now has a label of DB and a dropdown with channel, etc)
- Fixed incorrect z-index
* Removed this.close() I added before finding z-index issue.
* Matched buttons and drop downs to match style of ComfyUI interface while keeping the colours the same as OG ComfyUI Manager
* - Took gui building out and put into its own .js
- Applied theme to Nodes Manager
- Made theme respect user theme colors
* - Themed model manager and snapshot manager
- fixed incorrect id in gui builder
* Fix syntax error in color property
---------
Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
- Migrate Manager data path: default/ComfyUI-Manager → __manager
- Force security_level=strong on outdated ComfyUI (block installations)
- Auto-migrate config.ini only; backup legacy files for manual verification
- Raise weak/normal- to normal during migration
- Add /manager/startup_alerts API for UI warnings
- Differentiate 403 responses: comfyui_outdated vs security_level
- Block startup scripts execution on old ComfyUI
Requires ComfyUI v0.3.76+ for full functionality.
Backward compatible with older versions (uses legacy path).
* retain initial node_versions on serialize
* give precedence to workflow version
* set version info on node
* move patch to setup hook
* switch to nodeCreated