Three fixes. The CHANGELOG has an entry for each.
- Use the git executable set as git_exe
- Read the commit of a node pack whose refs are packed, and bring its
submodules to the commit that is checked out
- Fail an update whose pull or submodule update failed, leave the node pack
at its commit, remove what a clone that failed left, and refuse an install
of a node pack that another install is working on
Restarting through comfy-cli calls close_log() and then exits from the
request handler. asyncio logs the exit, the Manager's logging handler
passes the record to the logger for the log file, and the write to the
closed file raised ValueError: the console showed it twice at every
such restart.
- Write to the log file only while it is open; the console still gets
what is written to it
- Close the log file under the lock of the writes, so that a write
that has found it open is not overtaken by the close
- Add tests for writes to an open and to a closed log file, and for
the lock around the close
- Add a CHANGELOG entry
With file logging on, the logger that captures stdout and stderr
answered isatty() with False for every caller and had no closed
attribute. After colorama.init(), colorama took the console for a pipe
and removed the colors of every print(), and tqdm and rich took a
terminal for a pipe (#3259).
- Answer isatty() from the stream the logger wraps, and False when
that stream cannot answer
- Add closed, which colorama takes as True for a stream without it:
the state of the wrapped stream, False for a stream that has no such
attribute, and True for a detached stream
- Answer closed True once the log file is closed. Restarting through
comfy-cli calls close_log() and then exits, and colorama's exit
handler would write its reset through the logger
- Add tests for both answers on both streams, for streams that cannot
answer, and for what colorama does with the answers
- Add a CHANGELOG entry
The same change for manager-v4 is #3465.
Port the pip requirement checks of manager-v4 (#3489) to main, so that
both branches decide with the same code. #3431 had only replaced the
version class in main's own checks, which left ">" and "~=" answered
differently from v4.
- Parse requirements with packaging and share one parser and one
downgrade decision between manager_core and the startup check
- Treat '-', '_' and '.' as one separator in package names, in the
installed-package lookup, both lists, requirements and
pip_auto_fix.list (#3458)
- Read every version clause, so a lower bound written first no longer
hides an upper bound; read spaces, parentheses, markers, '===' and
direct references
- Install a requirement with extras unless it would downgrade the
protected package
- Check the requirement of every pip install command form, including
those with --index-url, on the immediate and reserved paths
- Skip a protected package when the requirement cannot be compared and
log why and how to install it
- At startup, recognize an installed package however its requirement
spells the name, install one older than its '~=' version or at the
version that '>' excludes, and stop reinstalling the '~=' version
itself
- Read downgrade_blacklist from config.ini in cm-cli, which read a
path attribute that does not exist and so protected only the
built-in packages
- Remove the unused is_installed copy from manager_core and the
pip_version helper that #3431 added
- Import packaging where it is used, because prestartup_script imports
manager_util before it installs missing dependencies
- Add the tests of #3489, adapted to main, and tests for the startup
loop, '>', pip_auto_fix.list names and the cm-cli setting; update
README and CHANGELOG
manager-v4 needs no counterpart: it has this code since #3489.
StrictVersion read each of the first three components of a version
with int(), so it raised on a suffix after the third number. On main
it read node pack versions and pip versions alike.
- Read a node pack version with a pre-release after the third number,
following '.' or '-', and write it with '-' as before: a registry
version such as 1.8.0-beta.1 is recognized, and 0.1.3.post1 no
longer stops the scan of installed node packs
- Compare pip versions with packaging in is_blacklisted and
is_installed of manager_core and in is_installed of
prestartup_script: an installed 2.5.1+cu124 or 4.41.0rc1 no longer
raises, which at the next start skipped the rest of a node pack's
requirements and its install.py
- Ask a packaging Specifier for the entries of pip_auto_fix.list, as
pip does; "~=" becomes a compatible-release clause
- Import packaging where it is used, because prestartup_script imports
manager_util before it installs missing dependencies
- Add tests that run the real scan and the real pip checks
- Add a CHANGELOG entry
The same change for manager-v4 is #3516. Fixes#1755.
os.execv on Windows joins its arguments with spaces and quotes nothing, so
only the interpreter and script path (quoted by hand) survived a restart.
Any other argument with a space, e.g. --browser-profile "Profile 1", was
split in two and ComfyUI failed to start with 'unrecognized arguments'.
Build the command in one helper, manager_util.build_restart_command, used by
both the reboot endpoint and the prestartup restart. On Windows every entry
is quoted with subprocess.list2cmdline; other platforms are unchanged.
Fixes#3339
- Migrate Manager data path: default/ComfyUI-Manager → __manager
- Force security_level=strong on outdated ComfyUI (block installations)
- Auto-migrate config.ini only; backup legacy files for manual verification
- Raise weak/normal- to normal during migration
- Add /manager/startup_alerts API for UI warnings
- Differentiate 403 responses: comfyui_outdated vs security_level
- Block startup scripts execution on old ComfyUI
Requires ComfyUI v0.3.76+ for full functionality.
Backward compatible with older versions (uses legacy path).
fixed: invalid environment setup for git_helper.py
fixed: default pip overrides doesn't work
modified: git_helper.py - use GIT_EXE_PATH env instead of config.ini
improved: print user_directory and ComfyUI-Manager config path on startup