Commit Graph
201 Commits
Author SHA1 Message Date
Alexander Brown 8afdee0416 Reload components on clear of any root graph (#3417)
* Reload components on clear of any root graph

ComfyUI_frontend is moving to one LGraph instance per workflow tab
(Comfy-Org/ComfyUI_frontend#21571), and app.clean() clears the new graph
before any extension hook fires. The instance patch on app.graph.clear
only reaches the graph that existed at startup, so components would not
be reloaded for later workflows.

Patch clear on the graph prototype and reload components when the
cleared graph is the current root graph. This also stops a subgraph
clear from clearing the root graph, which the old wrapper did by always
calling orig_clear on app.graph.

Amp-Thread-ID: https://ampcode.com/threads/T-d545a10a-f002-4dc5-9a74-f6402a836919

* Apply suggestion from @DrJKL
2026-10-28 14:22:55 -07:00
Alexander Brown b0b8bbe4e2 fix: replace PrimeVue styling with Manager-owned theme CSS (#3392)
Amp-Thread-ID: https://ampcode.com/threads/T-5e2d7b14-ee5c-40ff-b11a-1a158c0521c5
2026-10-18 14:57:03 -07:00
Dr.Lt.Data 572f363696 v3: Prevent HTML and URL injection in the Manager UI (#3296) 2026-09-19 08:22:26 +09:00
Dr.Lt.Data 79dd5e2358 Merge pull request #2152 from jfcantu/main
New feature: Node Usage Analyzer
2026-07-20 20:13:04 +09:00
Dr.Lt.Data 491f847bbc fix(security): harden CSRF with Content-Type gate and OpenAPI sync (#2819)
Defense-in-depth over GET→POST alone: reject the three CORS-safelisted
simple-form Content-Types (x-www-form-urlencoded, multipart/form-data,
text/plain) on 5 no-body POST handlers (snapshot/save,
manager/queue/{reset,start,update_comfyui}, manager/reboot) to block
<form method=POST> CSRF that bypasses method-only gating. Convert 10 pure
state-changing endpoints (fetch_updates, queue/{update_all,reset,start,
update_comfyui}, snapshot/{remove,restore,save}, comfyui_switch_version,
reboot) from GET to POST and split 5 config endpoints
(db_mode/preview_method/channel_url_list/policy/{component,update}) into
GET(read) + POST(write, JSON body). Emit the in_progress + done event pair
from the /manager/queue/install sync-enable fast-path so client UI
finalizes (previously only queue/start's empty worker done fired, leaving
item.restart unset and the Enable button visible after a successful enable).
Harden js/custom-nodes-manager.js completion path: await onQueueCompleted
with try/catch (surfaces silent turbogrid stale-item throws), replace the
{}.length == 0 no-op empty guard, set install_context before queue/install
to avoid a sync-completion race, wrap classList/updateCell in try/catch.
Resynchronize openapi.yaml with the converted routes (method → post, query
params → requestBody JSON schema, sibling post on 5 split endpoints).
Update 31 JS fetchApi call sites across 7 files; add
tests/test_csrf_content_type_helper.py covering 5 Content-Type cases via
aiohttp TestClient.

Reported-by: XlabAI Team of Tencent Xuanwu Lab
CVSS: 8.1 (AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:H)
2026-04-22 05:04:07 +09:00
Dr.Lt.Data f4fdd51ce9 feat(preview): disable Manager preview method when ComfyUI native feature is available
- Add detection for ComfyUI PR #11261 (per-queue preview override)
- Return DISABLED status when native feature is detected
- Improve UI loading state and prevent flash of enabled state
- Add accessibility attributes and visual feedback for disabled state
- Show user notification when feature transitions to native
- Version bump to 3.39
2025-12-19 23:05:52 +09:00
DavidandDr.Lt.Data ae6c7dd673 Changed Main Dialog to match aesthetics and close button location as Original ComfyUI Interface (#2349)
* Started changing UI to match the rest of ComfyUI

Completed Main Container

* - Added layout formatting to components of the Manager dialog box
- Pulled name from select and put it into a label (eg "DB: Channel" now has a label of DB and a dropdown with channel, etc)
- Fixed incorrect z-index

* Removed this.close() I added before finding z-index issue.

* Matched buttons and drop downs to match style of ComfyUI interface while keeping the colours the same as OG ComfyUI Manager

* - Took gui building out and put into its own .js
- Applied theme to Nodes Manager
- Made theme respect user theme colors

* - Themed model manager and snapshot manager
- fixed incorrect id in gui builder

* Fix syntax error in color property

---------

Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
2025-12-19 12:34:20 +09:00
John Cantu 1bdcd1bdbf Merge branch 'main' of https://github.com/jfcantu/ComfyUI-Manager 2025-12-14 18:11:34 -08:00
Dr.Lt.Data aaed1dc3d5 feat(security): Support System User Protection API with security migration (V3.38) (#2338)
- Migrate Manager data path: default/ComfyUI-Manager → __manager
- Force security_level=strong on outdated ComfyUI (block installations)
- Auto-migrate config.ini only; backup legacy files for manual verification
- Raise weak/normal- to normal during migration
- Add /manager/startup_alerts API for UI warnings
- Differentiate 403 responses: comfyui_outdated vs security_level
- Block startup scripts execution on old ComfyUI

Requires ComfyUI v0.3.76+ for full functionality.
Backward compatible with older versions (uses legacy path).
2025-12-03 00:42:12 +09:00
John Cantu 67d03530a3 Changes and new code for Node Usage Analyzer 2025-09-14 22:49:54 -07:00
Dr.Lt.Data 39eaa76b8a fixed: remove migration code completely
https://github.com/ltdrdata/ComfyUI-Manager/issues/1659
2025-03-14 18:24:30 +09:00
Dr.Lt.Data e71e68e298 modified: better error log when failed to update comfyui
https://github.com/ltdrdata/ComfyUI-Manager/issues/1576
2025-03-02 17:42:31 +09:00
Dr.Lt.Data 5a5a37dfee fixed: robust initial caching
https://github.com/comfyanonymous/ComfyUI/issues/7003#issuecomment-2690687621

modified: store `db_mode` setting to `config.ini`
https://github.com/ltdrdata/ComfyUI-Manager/issues/1582#issuecomment-2687332355

remove: fetch updates / skip updates
- 'updates' filter will trigger fetching
https://github.com/ltdrdata/ComfyUI-Manager/issues/1584

added: support for `disable_front` or `DISABLE_COMFYUI_MANAGER_FRONT`
2025-03-01 01:06:17 +09:00
Dr.Lt.Data 4fd17b0bf5 improved: advanced missing node detection based on embedded info
https://github.com/ltdrdata/ComfyUI-Manager/issues/1445

feat: Custom Nodes In Workflow
https://github.com/ltdrdata/ComfyUI-Manager/issues/990
https://github.com/ltdrdata/ComfyUI-Manager/issues/127

improved: show version on main dialog
modified: aux_id - use github_id if possible
removed: `fetch updates` button
2025-02-24 21:18:42 +09:00
Dr.Lt.Data e9df78c0e7 improved: When user do Switch ComfyUI, update the policy accordingly. 2025-02-20 12:20:04 +09:00
Dr.Lt.Data 5dd8ea8aab feat: update policy for updating ComfyUI
https://github.com/ltdrdata/ComfyUI-Manager/issues/1552

fixed: comfyui versions should be based on commit date
https://github.com/ltdrdata/ComfyUI-Manager/issues/1566

fixed: invalid identifying of nightly node packs which has `git@github.com:...` url
fixed: switch comfyui should be based on `master` branch instead of `main` branch
fixed: switch_to_default_branch - more robust switching
refactor: endpoints for policies
2025-02-19 21:34:13 +09:00
Dr.Lt.Data fa1b514440 improved: Update All - Show link on the result board
fixed: Update All - Updates for unknown nodes were not being applied
fixed: corner case crash whilte install/updating

https://github.com/ltdrdata/ComfyUI-Manager/issues/1168
2025-02-16 14:25:57 +09:00
Dr.Lt.Data 3b0709f5f2 improved: cm-cli.py save-snapshot - validate output path
fixed: Update all - Properly display the results of the ComfyUI update.
fixed: Update all - An issue where the action results of the custom nodes manager were reflected in the main dialog.

https://github.com/ltdrdata/ComfyUI-Manager/issues/1548
2025-02-15 09:23:04 +09:00
Dr.Lt.Data 6ff6e05408 improve: update all - background updating
modified: update all - don't update ComfyUI
2025-02-13 22:34:36 +09:00
Dr.Lt.Data 9963afa558 modified: remove comfyui-manager from list if desktop mode 2025-02-13 08:46:18 +09:00
Dr.Lt.Data ede8279c17 remove legacy ui components
- default_ui
- a1111
2025-02-02 15:27:29 +09:00
Dr.Lt.Data 0a67145d80 code formatting 2025-02-02 14:40:11 +09:00
bymyself 2e55bc470c Add commands to toggle visibility of manager and custom nodes manager menus (#1505)
* Add commands for manager keybindings

* use more consistent isVisible condition check

* remove hide method in favor of super class's close method

* fix formatting

* fix tabs formatting
2025-02-02 14:37:04 +09:00
Robin Huang 829784fa50 Fix conditional for switch ComfyUI. 2025-02-01 16:16:37 -08:00
Robin Huang 3c45f8dc91 Hide update comfyui buttons in electron. 2025-02-01 16:15:27 -08:00
Dr.Lt.Data 4760deaf9c feat: custom-nodes-manager - background tasks(install/update/fix/disable/enable) 2025-02-01 11:22:01 +09:00
Dr.Lt.Data b1b02dc8e5 double-click feature is removed.
The feature has been moved to
https://github.com/ltdrdata/comfyui-connection-helper
2025-01-29 02:45:37 +09:00
Dr.Lt.Data b114672e03 fixed: error when remote mode is selected
https://github.com/ltdrdata/ComfyUI-Manager/issues/1413
2025-01-10 00:38:32 +09:00
Dr.Lt.Data 585cc0d991 fixed: invalid skipping of pip dependencies installation if ==, ~=
removed: useless badge related code
2025-01-04 03:07:36 +09:00
Dr.Lt.Data de2b8fbd88 improved: add aboutBadge 2025-01-02 03:52:18 +09:00
Dr.Lt.Data 3c11361502 Merge branch 'main' into feat/cnr
improved: support new front's prompt, alert api
modified: z-indices
2025-01-02 02:58:55 +09:00
Dr.Lt.Data a148bb5aeb modified: apply new front's confirm api 2025-01-02 02:23:21 +09:00
Dr.Lt.Data b8f153e4eb Merge branch 'main' into feat/cnr 2024-12-18 09:08:15 +09:00
Dr.Lt.Data a32e551fd0 Revert "Bypass ComfyUI version check when in electron env (#1303)" (#1316)
This reverts commit 6f1bfae957.
2024-12-11 03:41:21 +09:00
6f1bfae957 Bypass ComfyUI version check when in electron env (#1303)
* Hacky: hide the features we do not want to ship with electron app

* Backup

* Take install path for cm-cli.

* Remove unused.

* Add no deps.

* Add no deps.

* Bypass ComfyUI version check when in electron env

* Fix exception when comfyui is not repo

* Fix version reporting always skipped

* Log unhandled errors

---------

Co-authored-by: Yoland Y <4950057+yoland68@users.noreply.github.com>
Co-authored-by: Robin Huang <robin.j.huang@gmail.com>
2024-12-11 03:02:58 +09:00
Dr.Lt.Data a9f8cecaec remove flowt.ai from workflow gallery.
https://github.com/ltdrdata/ComfyUI-Manager/issues/1275
2024-11-27 02:35:47 +09:00
Dr.Lt.Data f4442972bc Merge branch 'main' into feat/cnr 2024-10-08 19:47:38 +09:00
Dr.Lt.Data 8dd84bb0ec typo fix 2024-10-08 08:31:31 +09:00
Dr.Lt.Data e9eaff7f7e double click feature is fixed
MODIFIED: separate into copy-full and copy-all
FIXED: improper size copying

https://github.com/ltdrdata/ComfyUI-Manager/issues/1118
2024-10-08 08:28:33 +09:00
Dr.Lt.Data aa4b3d81ba Merge branch 'main' into feat/cnr 2024-10-05 15:35:48 +09:00
Dr.Lt.Data 61537d985d FIXED: component feature - compatibility patch
https://github.com/ltdrdata/ComfyUI-Manager/issues/1108
2024-10-05 15:33:22 +09:00
Dr.Lt.Data cbb6432803 Merge branch 'main' into feat/cnr 2024-09-29 17:18:47 +09:00
Dr.Lt.Data fbb1cd60d6 add docs.comfy.org
https://github.com/ltdrdata/ComfyUI-Manager/pull/1095
2024-09-29 17:18:06 +09:00
Dr.Lt.Data 2c3a11012f Merge branch 'main' into feat/cnr 2024-09-19 02:45:39 +09:00
Dr.Lt.Data 3701246fb1 use core badge feature if possible
https://github.com/ltdrdata/ComfyUI-Manager/pull/1051
2024-09-19 02:43:07 +09:00
Dr.Lt.Data ecda9bd34e add favorites button 2024-09-08 16:42:36 +09:00
Dr.Lt.Data 7b93c831de Merge branch 'main' into feat/cnr 2024-09-05 22:18:56 +09:00
Cesaryuan e0b88ce42a Fix white theme of Share window (#1036) 2024-09-05 21:49:24 +09:00
Dr.Lt.Data a1f7f7069f comfyui version switch 2024-08-21 01:33:55 +09:00
Dr.Lt.Data b3be556837 support CNR 2024-07-25 00:24:58 +09:00