With file logging on, the logger that captures stdout and stderr answered isatty() with False for every caller and had no closed attribute. After colorama.init(), colorama took the console for a pipe and removed the colors of every print(), and tqdm and rich took a terminal for a pipe (#3259). - Answer isatty() from the stream the logger wraps, and False when that stream cannot answer - Add closed, which colorama takes as True for a stream without it: the state of the wrapped stream, False for a stream that has no such attribute, and True for a detached stream - Answer closed True once the log file is closed. Restarting through comfy-cli calls close_log() and then exits, and colorama's exit handler would write its reset through the logger - Add tests for both answers on both streams, for streams that cannot answer, and for what colorama does with the answers - Add a CHANGELOG entry The same change for main is #3423.
ComfyUI-Manager: Core Backend (glob)
This directory contains the Python backend modules that power ComfyUI-Manager, handling the core functionality of node management, downloading, security, and server operations.
Directory Structure
- glob/ - code for new cacheless ComfyUI-Manager
- legacy/ - code for legacy ComfyUI-Manager
Core Modules
- manager_core.py: The central implementation of management functions, handling configuration, installation, updates, and node management.
- manager_server.py: Implements server functionality and API endpoints for the web interface to interact with the backend.
Specialized Modules
- share_3rdparty.py: Manages integration with third-party sharing platforms.
Architecture
The backend follows a modular design pattern with clear separation of concerns:
- Core Layer: Manager modules provide the primary API and business logic
- Utility Layer: Helper modules provide specialized functionality
- Integration Layer: Modules that connect to external systems
Security Model
The system implements a comprehensive security framework with multiple levels:
- Block: Highest security - blocks most remote operations
- High: Allows only specific trusted operations
- Middle: Standard security for most users
- Normal-: More permissive for advanced users
- Weak: Lowest security for development environments
Implementation Details
- The backend is designed to work seamlessly with ComfyUI
- Asynchronous task queuing is implemented for background operations
- The system supports multiple installation modes
- Error handling and risk assessment are integrated throughout the codebase
API Integration
The backend exposes a REST API via manager_server.py that enables:
- Custom node management (install, update, disable, remove)
- Model downloading and organization
- System configuration
- Snapshot management
- Workflow component handling