From 08eb5ef10b59701dbe4cf15a52c9817484a789c2 Mon Sep 17 00:00:00 2001
From: Vito Sansevero <vito.sansevero@gmail.com>
Date: Sun, 25 Oct 2026 06:54:11 -0700
Subject: [PATCH] test(backup): wait for the backup hold to end before reading
 its state

CI (py3.11/3.12 on Linux, every macOS) read the registry right after the
client had the last byte, before the handler left its hold and removed its
temp file: the job was still running. The tests now wait on that state.
---
 tests/test_api_backup_restore.py |  4 ++++
 tests/test_restore_plans.py      | 20 +++++++++++++++-----
 2 files changed, 19 insertions(+), 5 deletions(-)

diff --git a/tests/test_api_backup_restore.py b/tests/test_api_backup_restore.py
index 19b4d6d2..5317594d 100644
--- a/tests/test_api_backup_restore.py
+++ b/tests/test_api_backup_restore.py
@@ -132,6 +132,10 @@ class TestBackupRoute(BackupRestoreTestCase):
         self.assertTrue(disposition.rstrip('"').endswith(".db"))
 
         body = await resp.read()
+        # The handler removes its temp file as it leaves the registry hold,
+        # which can be just after the client holds the last byte.
+        while self.api._jobs.active("backup") is not None:
+            await asyncio.sleep(0)
         downloaded = self._write("downloaded.db", body)
         self.assertEqual(
             _texts(downloaded), ["backup me 0", "backup me 1", "backup me 2"]
diff --git a/tests/test_restore_plans.py b/tests/test_restore_plans.py
index de6079a2..9530d984 100644
--- a/tests/test_restore_plans.py
+++ b/tests/test_restore_plans.py
@@ -133,6 +133,18 @@ class RestoreTestCase(AdminAPITestCase):
         self.addAsyncCleanup(self._release, job, gate)
         return job, gate
 
+    async def download_backup(self):
+        """GET /backup, read every byte, then wait for its hold to end.
+
+        The client can hold the last byte before the handler has left its
+        hold, so the registry is read only once the hold says it is done.
+        """
+        resp = await self.client.get("/prompt_manager/backup")
+        data = await resp.read()
+        while self.api._jobs.active("backup") is not None:
+            await asyncio.sleep(0)
+        return resp, data
+
     async def _release(self, job, gate):
         gate.set()
         await asyncio.gather(job.task, return_exceptions=True)
@@ -519,8 +531,7 @@ class TestBackupDownload(RestoreTestCase):
             return path
 
         with patch("py.api.backup_restore.safety_temp", spy):
-            resp = await self.client.get("/prompt_manager/backup")
-            data = await resp.read()
+            resp, data = await self.download_backup()
         self.assertEqual(resp.status, 200)
         [temp] = created
         self.assertEqual(os.path.dirname(temp), self.tmpdir)
@@ -539,7 +550,7 @@ class TestBackupDownload(RestoreTestCase):
         self.assertEqual(
             body, {"success": True, "safety_backups": [], "last_download": None}
         )
-        await (await self.client.get("/prompt_manager/backup")).read()
+        await self.download_backup()
         body = await (await self.client.get("/prompt_manager/backup/status")).json()
         download = body["last_download"]
         self.assertEqual(set(download), {"at", "bytes", "verified"})
@@ -574,8 +585,7 @@ class TestBackupDownload(RestoreTestCase):
 
     async def test_backup_is_listed_while_it_streams(self):
         self.save("keep")
-        resp = await self.client.get("/prompt_manager/backup")
-        await resp.read()
+        await self.download_backup()
         [job] = self.api._jobs.list()
         self.assertEqual(
             (job.kind, job.title, job.admission, job.state),