From 30f83f2401cbc1c193c27a395ad427eaec7d3cb2 Mon Sep 17 00:00:00 2001 From: Vito Sansevero Date: Mon, 9 Feb 2026 05:46:38 -0800 Subject: [PATCH] =?UTF-8?q?fix:=20address=20code=20review=20=E2=80=94=20un?= =?UTF-8?q?used=20import,=20silent=20except,=20gallery=20cache?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove unused `patch` import from test_output_dir.py - Add debug log message to ImportError handler instead of bare pass - Invalidate gallery file listing cache alongside output dir cache when the user changes gallery_root_path in settings --- py/api/__init__.py | 4 +++- py/api/admin.py | 4 +++- tests/test_output_dir.py | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/py/api/__init__.py b/py/api/__init__.py index 4a496a0..723c78c 100644 --- a/py/api/__init__.py +++ b/py/api/__init__.py @@ -482,7 +482,9 @@ class PromptManagerAPI( f"Configured directory does not exist: {GalleryConfig.MONITORING_DIRECTORIES[0]}" ) except ImportError: - pass + self.logger.debug( + "GalleryConfig not available, skipping configured directory check" + ) current_file = Path(__file__).resolve() self.logger.debug(f"Starting ComfyUI output search from: {current_file}") diff --git a/py/api/admin.py b/py/api/admin.py index b5e49a3..b4060c6 100644 --- a/py/api/admin.py +++ b/py/api/admin.py @@ -448,8 +448,10 @@ class AdminRoutesMixin: GalleryConfig.MONITORING_DIRECTORIES = [new_path] else: GalleryConfig.MONITORING_DIRECTORIES = [] - # Invalidate cached output dir so next lookup uses new config + # Invalidate caches so next lookup uses new config self._cached_output_dir = None + self._gallery_cache = None + self._gallery_cache_time = 0 restart_required = True # Save to config file for persistence diff --git a/tests/test_output_dir.py b/tests/test_output_dir.py index 21b1ad7..4920690 100644 --- a/tests/test_output_dir.py +++ b/tests/test_output_dir.py @@ -9,7 +9,7 @@ import sys import tempfile import unittest from pathlib import Path -from unittest.mock import MagicMock, patch +from unittest.mock import MagicMock sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))