fix: address review-bot findings on merged PRs (#593)

Squashed from PR #595. Closes #593.
2026-10-31 23:13:59 -07:00
parent 01a4f1d989
commit 85441aa637
10 changed files with 165 additions and 40 deletions
@@ -113,7 +113,10 @@ def _start_daemon_observer(observer) -> None:
    def start() -> None:
        try:
            observer.start()
-        except BaseException as e:  # re-raised on the caller's thread
+        # BaseException on purpose: a KeyboardInterrupt or SystemExit raised
+        # by start() is not lost on this thread; _start_daemon_observer
+        # re-raises it on the caller's thread below.
+        except BaseException as e:
            raised.append(e)

    starter = threading.Thread(