From b85d2cc638f917796def17a36466833359d41bc7 Mon Sep 17 00:00:00 2001 From: Vito Sansevero Date: Fri, 30 Oct 2026 21:40:46 -0700 Subject: [PATCH] refactor(quality): use the precise unittest asserts --- tests/test_api_maintenance.py | 2 +- tests/test_bulk_library_delete.py | 2 +- tests/test_diagnostics_config.py | 2 +- tests/test_gallery_listing.py | 2 +- tests/test_library_delete_routes.py | 2 +- tests/test_local_inspect_parity.py | 22 +++++++++++----------- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/tests/test_api_maintenance.py b/tests/test_api_maintenance.py index 749a3af3..f700aa64 100644 --- a/tests/test_api_maintenance.py +++ b/tests/test_api_maintenance.py @@ -675,7 +675,7 @@ class TestBackupPoolAndDiskSpace(ApplyTestCase): self.assertEqual(len(backups), MAX_SAFETY_BACKUPS) self.assertNotIn(restore_style[0], backups) self.assertNotIn(restore_style[1], backups) - self.assertTrue(set(maintenance_style) <= set(backups)) + self.assertLessEqual(set(maintenance_style), set(backups)) # A restore prunes the same pool, maintenance backups included. self.old_backup("prompts.db.backup_20020101_000000", 3000) _prune_safety_backups(self.api.db.model.db_path) diff --git a/tests/test_bulk_library_delete.py b/tests/test_bulk_library_delete.py index 7fce13e1..2ff16997 100644 --- a/tests/test_bulk_library_delete.py +++ b/tests/test_bulk_library_delete.py @@ -642,7 +642,7 @@ class TestPairedDelete(LibraryDeleteCase): # The negatives stay, and the image file stays on disk. self.assertTrue((self.root / "owl.png").exists()) texts = [row[0] for row in rows(self.db, "SELECT text FROM prompts")] - self.assertTrue({"dark", "fog", "Bystander"} <= set(texts)) + self.assertLessEqual({"dark", "fog", "Bystander"}, set(texts)) def test_a_negative_used_by_another_positive_is_archived_never_deleted(self): shared = save(self.db, "Shared") diff --git a/tests/test_diagnostics_config.py b/tests/test_diagnostics_config.py index 2fca7ac4..e3cfb3e1 100644 --- a/tests/test_diagnostics_config.py +++ b/tests/test_diagnostics_config.py @@ -182,7 +182,7 @@ class TestAdminEndpointsUseConfigPath(unittest.TestCase): self.assertIsNone(warning) self.assertEqual(os.path.dirname(snapshot), folder) with open(snapshot, "rb") as handle: - self.assertTrue(handle.read(16) == b"SQLite format 3\x00") + self.assertEqual(handle.read(16), b"SQLite format 3\x00") finally: os.unlink(snapshot) finally: diff --git a/tests/test_gallery_listing.py b/tests/test_gallery_listing.py index ca796bfe..0e2ebf7f 100644 --- a/tests/test_gallery_listing.py +++ b/tests/test_gallery_listing.py @@ -312,7 +312,7 @@ class RootContainsTests(unittest.TestCase): root = os.path.normcase(os.path.realpath(tempfile.gettempdir())) inside = os.path.join(root, "x.png") self.assertTrue(root_contains(root, inside)) - self.assertTrue(root_contains(root, inside.upper()) == (os.name == "nt")) + self.assertEqual(root_contains(root, inside.upper()), os.name == "nt") if __name__ == "__main__": diff --git a/tests/test_library_delete_routes.py b/tests/test_library_delete_routes.py index 1582cbc7..4e3b1bf0 100644 --- a/tests/test_library_delete_routes.py +++ b/tests/test_library_delete_routes.py @@ -297,7 +297,7 @@ class TestLibraryDeleteRoutes(LibraryDeleteRouteCase): ) page = await response.json() self.assertEqual(page["archived_total"], 3) - self.assertTrue(set(item["id"] for item in page["items"]) <= set(kept)) + self.assertLessEqual(set(item["id"] for item in page["items"]), set(kept)) response = await self.client.request( "GET", "/prompt_manager/library?limit=2&shelf=archived" diff --git a/tests/test_local_inspect_parity.py b/tests/test_local_inspect_parity.py index e5ab5dde..e8c45d55 100644 --- a/tests/test_local_inspect_parity.py +++ b/tests/test_local_inspect_parity.py @@ -1112,10 +1112,10 @@ class LocalProjectionParityTests(unittest.TestCase): self.assertEqual(_canonical_bytes(local), _canonical_bytes(server)) seen.update(server["record_formats"].values()) seen.add(server["workflow_graph"]["status"]) - self.assertTrue( - {"reserialized-json", "original-text", "invalid", "limited"} <= seen + self.assertLessEqual( + {"reserialized-json", "original-text", "invalid", "limited"}, seen ) - self.assertTrue({"parsed", "malformed", "limited"} <= seen) + self.assertLessEqual({"parsed", "malformed", "limited"}, seen) def _server_evidence(records, file_name=None): @@ -1287,7 +1287,7 @@ class LocalResolverParityTests(unittest.TestCase): def test_local_roles_match_selection_record_sets(self): answers = self._compare(selection_cases.selection_cases()) reasons = {answer["resolution"]["reason"] for answer in answers.values()} - self.assertTrue( + self.assertLessEqual( { "Every sampler branch uses the same prompt pair", "Multiple sampler branches", @@ -1301,8 +1301,8 @@ class LocalResolverParityTests(unittest.TestCase): "Negative prompt delimiter is absent", "Parameters exceed the length limit", "No A1111 parameters", - } - <= reasons + }, + reasons, ) # A stage reaching only previews is dropped: one sampler is named. self.assertEqual( @@ -1352,7 +1352,7 @@ class LocalResolverParityTests(unittest.TestCase): def test_local_roles_match_golden_record_sets(self): answers = self._compare(resolver_cases.golden_cases()) codes = {answer["resolution"]["reason_code"] for answer in answers.values()} - self.assertTrue( + self.assertLessEqual( { "malformed", "unsupported-node", @@ -1364,16 +1364,16 @@ class LocalResolverParityTests(unittest.TestCase): "graph-ceiling", "no-sampler", None, - } - <= codes + }, + codes, ) sources = { side["source"] for answer in answers.values() for side in answer["prompts"].values() } - self.assertTrue( - {"execution", "graph-inferred", "zeroed-conditioning"} <= sources + self.assertLessEqual( + {"execution", "graph-inferred", "zeroed-conditioning"}, sources ) def test_committed_resolver_vectors_are_current(self):