From e3ee34bfd0e5311ce0041a4bc248068200d95e42 Mon Sep 17 00:00:00 2001 From: Vito Sansevero Date: Sun, 25 Oct 2026 08:04:54 -0700 Subject: [PATCH] test(system): wait for the renderer line before clicking Integrations rows CI Firefox (390 wide) clicked the LoraManager toggle while the renderer check's line above it changed text and moved the rows, so the click did not reach the switch. The specs now wait for that line to settle (a visible state) before interacting. --- tests/browser/system-integrations-concept.spec.mjs | 2 ++ tests/browser/workspace-system-integrations.spec.mjs | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/browser/system-integrations-concept.spec.mjs b/tests/browser/system-integrations-concept.spec.mjs index 6628c7a..1ba0752 100644 --- a/tests/browser/system-integrations-concept.spec.mjs +++ b/tests/browser/system-integrations-concept.spec.mjs @@ -264,6 +264,8 @@ async function conceptReview(page, theme) { async function productionReview(page, request, theme) { await openProduction(page, 'system/integrations', theme); await expect(page.locator('#workspace-main #lora-path')).toHaveValue('custom_nodes/ComfyUI-Lora-Manager'); + // The renderer line above settles first: its new text moves the rows below (a click must not land mid-shift). + await expect(page.locator('#workspace-main .setting-row [role="status"]')).toHaveText(RENDERER_NONE); // The import reviews what is enabled: save the integration on first. await page.locator('#workspace-main #lora-enable').check(); await page.getByRole('button', { name: 'Save preferences', exact: true }).click(); diff --git a/tests/browser/workspace-system-integrations.spec.mjs b/tests/browser/workspace-system-integrations.spec.mjs index 98751ec..ace020a 100644 --- a/tests/browser/workspace-system-integrations.spec.mjs +++ b/tests/browser/workspace-system-integrations.spec.mjs @@ -56,6 +56,8 @@ async function openIntegrations(page) { await expect(layoutOf(page).locator(':scope > section.surface')).toHaveCount(2); // The LoRA rows are painted once the server's LoRA state was read. await expect(settingOf(page, 'LoraManager integration').locator('input')).toBeEnabled(); + // The renderer line settles first: its new text moves the rows below, so no click lands mid-shift. + await expect(settingOf(page, 'Host compatibility').getByRole('status')).not.toHaveText('Looking for open ComfyUI windows…'); return layoutOf(page); }