A home folder named like a word (/home/info) no longer removes the log
level INFO from the report; the name still goes when it is a part of a
path. Documents the accepted residual risk of another user's home. (#329)
Review findings on #329 PR 1:
- report_path never uses a filesystem root or a strict ancestor of the
home folder (/home, C:\Users) as its anchor, so a path inside home needs
an anchor at or below it and otherwise reads "outside ComfyUI"; no path
starts with a user name. The scrub matches the home folder only as whole
path parts (in full, without its root, and its name).
- A download serves only a regular file (a FIFO, socket or device is a
404) and opens it non-blocking.
- One unreadable timestamp no longer breaks the log listing, stats,
download, review or Clear.
- The report tests read a temporary log folder, never the process's own.
Review findings on #329 PR 1:
- Clear empties the active log through the handler only when the handler's
open stream is the listed file (same inode); a log the user renamed while
ComfyUI runs is no longer emptied.
- A download is refused when the opened file is not the one listed (inode),
or has another name (a hard link).
- Windows reparse points that name another file (the name-surrogate bit:
symlinks, junctions, WSL links) are links under Rule R; cloud placeholders
stay regular files.
- The report's paths use the closest anchor that is not a filesystem root,
and the scrub also catches the home folder without its root.
GET /system/diagnostics builds the report on the server, off the event loop
and under a registry lease (409 busy while a restore runs): the project and
Viewer.js versions, Python and the platform, the four legacy checks (one
helper, legacy_checks, that GET /diagnostics also calls), public database
info, source counts, the log configuration and statistics, the last health
summary and the config.json-only keys from an explicit list. The CivitAI key
is reported only as has_civitai_api_key; every path is relative to ComfyUI
or reads "outside ComfyUI". A scrub replaces anything still absolute, the
key or the home folder and counts it in redacted (0 for a correct build).
The version parser moves unchanged to utils/version.py. (#329)
Vito Sansevero