4 Commits

Include renames

Author	SHA1	Message	Date
Vito	00bda8f442	feat(inspector): concept prompt blocks, side panel and viewer details (#260) ... * feat(workspace): concept prompt blocks Shared prompt blocks (Images panel, viewer details, Library cards and saved texts, recorded runs) now render the approved mock's markup (app.js promptBlock a298-302, concept.css s550-588), #249 D22: - section.prompt-section.<role>[aria-label="<Role> prompt"] > .prompt-heading (span.role-label "+ Positive prompt" / "- Negative prompt"; .prompt-actions: copy button.icon-btn "Copy <role> prompt", then send button.send.icon-btn "Send <role> prompt to ComfyUI") + p.prompt-text. - No per-block source line; a file's evidence moves to the panel badge (D2) and "File & provenance" (D3). Recorded runs keep every field's source in "Frozen field provenance". - Empty text reads "No negative prompt (explicitly empty)" and still sends an explicit clear. Absent, ambiguous and unresolved roles render p.prompt-text.muted with the existing status strings and no actions; unknown role names render nothing and cannot be sent or copied. - Copy shows the shared toast "Prompt copied."; without a clipboard it opens the concept's "Copy prompt" select-to-copy dialog. - The data-send-role / data-copy-role contract is unchanged. The D22 interim overrides (26px actions, prompt-text margins, copy status, source line) are retired so the concept's rules apply; the action buttons measure the mock's 31x31. pre.prompt-text styling stays only for the Library editor's Archive dialog and frozen field provenance, which keep their own markup until their page rebuilds. Test selector mapping: .prompt-block / .prompt-positive -> .prompt-section(.positive) .prompt-block-heading h3 -> .prompt-heading span.role-label region pre / pre.prompt-text -> p.prompt-text "Empty negative prompt" -> "No negative prompt (explicitly empty)" "Send <role> prompt" -> "Send <role> prompt to ComfyUI" .prompt-source / copy status line -> removed (toast or Copy prompt dialog) copy button 30x26 -> 31x31 (measured in the mock) * feat(inspector): concept side panel The Images side panel is the concept's aside#image-inspector.detail-panel in the order of app.js imageDetails: plain cover, heading with the format chip, filename, the D21 evidence badge and category chip, prompt blocks, tag chips, the six facts and the footer (Send to ComfyUI pair, Prompt history). Provenance, raw records and downloads stay in the viewer's full details. Positive-scope tag chips set the Images Tags filter to that tag. * fix(inspector): mark the side panel's overlay rules with their D2 decision The overlay lint (tests/vendor/concept-css.test.mjs) requires a /* D<n> */ marker on every workspace.css rule that overrides a concept selector; the three .detail-panel rules from D2 lacked one. * feat(inspector): full details in the viewer The viewer's #viewer-details renders the concept's imageDetails(i, true): the side panel content without the cover in a class-less wrapper, then "File & provenance" and "Workflow & raw metadata" (pre[tabindex=0] > code and the two downloads with their unavailable reasons), then the pair send ("Send to ComfyUI", labelled "Send prompt pair to ComfyUI: <title>") and Prompt history buttons. One renderer now serves both variants. Provenance wording (maintainer, 2026-10-20): the six per-fact "<Fact>: Configuration evidence · <source>" lines and FACT_SOURCES are gone; the concept's "Prompt evidence: <badge>" line carries the D21 badge in lower case and is left out without a badge. The honest facts stay (current-file note, Source, Path, Size, Dimensions, Format, Media type, Modified, occurrence, association, Download original). An unverified format reads "PNG extension", no stray leading dot. inspector.css and images.css are deleted; only rules with a live consumer moved to the overlay under #249 D3 (inspector wrapping, the inert aria-disabled download, the narrow Images container, the Library and recorded-run prompt blocks, the Archive negative's prompt-block, the prompt sender) plus a D20 wrap rule for the viewer's buttons at 200% zoom. D1 review follow-ups: library.css no longer restyles recorded-run p.prompt-text.muted (m2); the copy fallback has a seam and unit tests for a missing clipboard and a refused write (m3); a stale test title is renamed (m4); the fallback trigger falls back to the same-role button when the clicked one was detached by a re-render (m7); TESTING.md records the D20 and D22 deviations (m1). Selector mapping in tests: .file-inspector-inner -> .panel-heading, .generation-facts -> .meta-grid (first), .file-facts -> details .meta-grid, .file-name -> #viewer-details > div > p.small, .file-inspector-footer -> #viewer-details, viewer "Send prompt pair" -> /^Send prompt pair to ComfyUI: /. * test(comfyui): real-host specs read the concept prompt blocks library-sender: an explicitly empty saved negative now reads the concept's "No negative prompt (explicitly empty)" (D22). The prompt-sender spec's panel and viewer selectors (complementary "Selected image details", the card image opening the viewer, .meta-grid facts, the labelled pair send) moved with the D3 commit. * test(comfyui): the frozen run's prompt regions read the concept prompt text * fix(inspector): coarse viewer-detail targets and Prompt history on the shown route - Prompt history closes the viewer and, when its target is the route already shown, re-renders it as the concept's go() does (navigateTo plus a router refresh event), instead of doing nothing. - The viewer details' disclosure summaries and "Download original" keep 40px targets on coarse pointers (#249 D34), as TESTING.md promises. - Drop the dead `.prompt-positive` rules and merge the two `pre.prompt-text` rules. - TESTING.md records the side panel's D20/D21 deviations.	2026-10-20 20:15:21 -07:00
Vito	86d82186ee	feat(images): concept Images page — toolbar, cards, star, viewer, compared against the mock (#258) ... * feat(workspace): shared concept toolbar and dialogs Add the concept's shared page toolbar (search.toolbar with the search field, category filter, sort and Filters) and its dialogs in one modal shell: "Refine this view" (Source / Folder / Media / Tags, Apply filters), "Import & inspect" with only the real operations (Open inspector, Rescan), and the "Copy prompt" select-to-copy fallback. The sort lists the concept's three options first (D14); there is no Save view (D16). Every dialog returns focus to its trigger on close or Escape. Refs #249 * fix(workspace): bind shared dialogs to the page and its route - Drop the invented Refine note; every field is real (D14). - Ignore a late close event once the shell was reopened or replaced, so an action that opens the next dialog keeps it open. - Dialog openers require the page scope; disposing it closes and removes the shell unless a newer page's dialog is open. Every route change closes the shared dialog before the next page mounts. - Clear filters also reports category '' so the page clears the toolbar category, as the concept does. - The toolbar requires its scope and falls back to the first sort for an unknown value; dialog callbacks are validated up front. Refs #249 * feat(images): concept toolbar, filter row and caption The Images page now renders the approved mock's heading, shared toolbar, filter row, section caption and infinite continuation (#249, Task C2). - Heading: "Your generations, their prompts, and the next idea." with Import (upload icon) before New prompt (primary). - Toolbar (shared mountToolbar): search over filenames, linked prompt text, titles and tags; category (the Library's categories); sort Recently added / Name A–Z / Highest rated, then Oldest first and Name Z–A (D14). - Filter row: Grid/List/Masonry segmented control, Thumbnail size, the scope chip ("All output folders" or "<source> · <folder>") and "Group by positive prompt →". - Caption: "N of M images · K positive prompts" from positive_count; a plain cursor page keeps the first page's count and an unknown count hides the "· K positive prompts" part. The date span shows "<Today|Yesterday|weekday> · <Month D>" of the newest loaded result under a date sort and is hidden otherwise (D17). - Continuation: "N of M images · more load as you scroll" with Load more, the concept's end copy, Retry for a failed page, and the concept's "K more images loaded. N of M." toast. - The listing sends category, tags and sort=rating (PR B params). Old control -> new control: - "Search filenames" field -> toolbar search "Search workspace" (placeholder "Search prompts, tags, filenames…"), also matching prompt text and tags - Source select -> Filters -> "Refine this view" Source - Folder select -> Refine Folder (all sources' folders and ancestors) - Media select -> Refine Media - (new) Tags -> Refine Tags; Category -> toolbar category select - Sort select (Newest/Oldest/Filename A–Z/Z–A) -> toolbar sort (Recently added/Oldest first/Name A–Z/Name Z–A, plus Highest rated) - Layout buttons -> .segmented Grid/List/Masonry in the filter row - Thumbnail size field -> label.small + select#image-size - "Group by positive prompt" link -> button.chip "Group by positive prompt →" (#/library) - Refresh -> Import -> "Scan an output folder" -> Rescan (D15) - "Current gallery" link -> removed; Overview's tool cards link the legacy gallery (D29) - "All images" h2 + count -> .section-caption #result-count - .image-continuation -> .infinite-continuation (Retry kept) Legacy behavior kept: video items, keyboard grid navigation, scroll and filter restoration, bounded DOM, continuation retry, source-change recovery (now disabling the toolbar, Filters and Import). The Filters and Import dialogs close on route change and browser Back. The shared toolbar (C1) called .some() on select.options, which is an HTMLOptionsCollection in a browser (only the unit tests' fake DOM gave an array); setValue and setCategories now spread it first. The layout segmented control may wrap at extreme zoom (D31) instead of scrolling the 390px page sideways. The retired .image-filters, .image-view-controls, .image-toolbar, .image-layouts, .image-collection, .image-continuation and duplicated .image-workspace grid rules are gone from images.css. * test(workspace): model select.options as a browser collection The toolbar units' fake DOM returned select.options as an Array, so the toolbar's .some() call passed there while it threw in every browser (fixed in 12228e2). options is now an indexed, iterable, frozen HTMLOptionsCollection-like object without Array methods; against the C1 toolbar three units fail with "sort.options.some is not a function". The units also assert that an unknown sort falls back to the first option and that a still-listed category survives a category refresh. * fix(images): concept Load more focus, empty state and review rulings Review of #249 C2: - Load more and Retry focus the first appended image, as the concept does (app.js loadMoreImages). Focus moves without scrolling so the visible cards keep their place (bounded-DOM anchor), and only while focus is still on the pressed control: a viewer or a field the user moved to keeps it. When a last page adds nothing and the button hides, focus goes to the last image, never to the page; a failed page focuses Retry. - The concept's empty state beside the grid: .empty "No matching images. Try another search or category." - D17: the caption date shows only under Newest first (", YYYY" outside the current year) and is hidden under Oldest first and the name and rating sorts. - en-US number grouping in the embedded count too. - Refine "Folder" defaults to the concept's "All output folders". It is not narrowed by Source: the concept has no Source field, and the list holds every source's folders, so any pair can be chosen in one dialog. - The shared toast moves to toast.mjs; library-editor re-exports it. - The D32 overlay (extreme zoom) wraps the layout segmented control and the continuation row instead of pushing them out of the 390px column. - The legacy gallery checks moved to Overview's "Open existing image gallery" card (D29). Mapping additions: grid with no results -> .empty concept copy beside the grid; Load more press -> focus the first new image (concept). * feat(images): concept image cards; image opens the viewer Cards are the concept media card: .media-art > button.image-open with the image or video, and .media-info with the D10 title (linked title only when the link is confirmed, else the filename; title attribute = path), the D11 subtitle "W x H · EXT · Seed N" (seed shown as the listing's string) and an Inspect info button. The byte size and the Preview button are gone. Activating the image (click, Enter, Space) opens the viewer and focus returns to it on Escape; Info selects the image into the panel (D19). Arrow, Home and End navigation, bounded rendering and scroll restoration are kept. Columns and gap now come from the concept grid's computed style (gridMetrics) instead of a production breakpoint table, so the concept breakpoints apply; a 120px minimum card bounds extreme zoom (D3, D31). images.css card rules are retired into marked overlay rules. The scope chip reads "All output folders" when no folder is chosen (D14). * fix(images): pair-linked cards take the positive's title; concept Info, alt and size - Pair links title the card, inspector and viewer from the linked positive's Library title or confirmed first line, never the pair title (the negative variant's name). The card now equals the concept card, title included. - Info drops aria-pressed; the card's .selected carries selection, as in the concept. - Card images take the card title as alt and the listing's width/height. - One shared minimum card width for layout and the narrow-card class. - A debounced search that lands after a sort change no longer reloads page 1. - 200% zoom test also runs at an 800px viewport and device scale 2. Refs #249 * feat(images): concept hover zoom * feat(images): favorite images from the card * feat(images): concept viewer shell * fix(images): one favorite request per file across leaving and returning The pending set and the receiver of each answer now live at module level beside the saved visit. A press on a returned Images page waits for the request the earlier page sent, and its success or rollback reaches the card on screen, or the saved visit when no Images page is mounted. * fix(images): mark a star busy while its favorite request is pending The star carries aria-disabled="true" until the answer arrives, also on a card rendered after returning to Images, so the ignored second press is announced as unavailable instead of doing nothing silently. * perf(images): repaint one card on a favorite toggle instead of the collection stream.updateItem tells onChange which item it patched, and the Images page then skips the full layout pass (computed style, grid metrics and layout over every loaded item) because no card changed size or place. * docs(images): say the lone-star overlay rule is interim until the checkbox PR * test(images): concept comparison for the Images page images-concept.spec.mjs compares the production Images page with the immutable concept on the concept-shaped fixture: heading, toolbar, filter row, caption, grid, the first six cards, continuation and panel box in Grid, List and Masonry, at 1600x1100 and 390x844, dark and light, normal and reduced motion; plus hover zoom, the viewer title, focus restore, Info selection, search and Load more with its toast. mapImagesConcept applies only recorded deviations (D3, D8 and D16 follow-up PRs, D9, D10, D14, D15, D17, D29, D31, D32); removed row items flow again from the concept's own boxes. A mutation check proves the comparison fails on a .media-info padding change and on removed Inspect buttons. Corrections the comparison demonstrated: - the grid and continuation carry the concept's ids (image-grid, gallery-continuation); - bounded rendering reserves the card footer at its fractional height: offsetHeight rounded a wrapped 67.5px row up, so at 390px every card was a pixel taller and the grid 6px taller than the concept. Two mismatches wait for a ruling and are pinned on both sides: the category order (concept prompt order, production alphabetical) and the singular count line ("1 positive prompt"). * fix(images): ignore sub-pixel noise when the measured card footer grows Under page zoom the fractional footer height (rect / scale) can carry float noise above the stored value, which relaid the grid and scrolled for nothing. * test(images): map D35-D37 and widen the Images concept comparison - D35 (singular counts) and D36 (alphabetical categories) are mapped deviations instead of pinned values; a search for exactly one image checks both singular nouns, and a one-image Load more checks the toast and continuation. - Grid, cards and panel at 1200x900 (2 columns, 275px panel) and 1800x1100 (4 columns); Large and Compact join the layout loop. - Masonry tops and heights compare unrounded within one layout unit per card above in the column (D3), not as rounded integers. - The Save view and sample-tag re-layout is checked against the concept page with those items removed at runtime. - The Load more row is compared before the press in both documents (D37). - Two seedless fixture images (seedless_images on the concept reset) prove every row reserves the tallest footer (D3). - D10 paths come from the fixture manifest; the D8 star margin is mapped; list-row derivations cite D3 and D9. * fix(images): search never matches a pair's own variant title Search covers the filename, the linked positive's text and Library title, and its tags (#249 D12). The pair title names a negative variant, so a variant name alone no longer admits the positive's images. * fix(viewer): keep the Media controls group and drop a stale position description The concept viewer toolbar is again a named group (#249 D34 #8), and Previous/Next are described by the position line only while a single item is loaded. * docs(history): drop the remaining-polish notes the concept viewer and cards closed The viewer now takes the concept stage and toolbar, and Images cards open the viewer, select into the panel and favorite. Only the select checkbox (#249 D8 follow-up) and the tag button (#249 D9) stay outside #209. * test(images): the singular copy when scrolling loads one image; countCopy in the shared inventory helper * refactor(images): retire the replaced images.css rules and lint the kept page sheets The unused .image-facts rules go. The three prompt-block overrides on concept selectors are marked #249 D22 interim until PR D deletes the file, and every kept page stylesheet now passes the overlay lint. * test(images): the extreme-zoom anchor probe reads the fractional footer measurement Since the concept comparison (#249 C7) the grid measures footers with getBoundingClientRect, so the probe that hooked offsetHeight never fired. * test(images): cover the masonry fallback when a finite size underflows its ratio * docs(images): concept Images page and recorded deviations TESTING.md documents the Images page controls, the recorded #249 deviations and how the earlier workspace filters moved, and notes that every kept page stylesheet is linted. The frontend coverage baseline adds the toast, toolbar and workspace dialog modules. * fix(images): show that Import → Rescan runs, and how it ended The old Refresh button disabled itself while /gallery/rescan ran; Import → Rescan closed its dialog and showed nothing. Now a toast says the rescan started ("Rescanning output folders…") and how it ended ("Rescan finished. N files in M output folders.", from the scan's own total and roots, or "Rescan could not finish. Try again."). A reopened Import dialog shows Rescan as "Rescanning…" and aria-disabled, and ignores a press on it. Failing before: the held-rescan browser test saw no toast and no busy state; the dialog unit test found no "Rescanning…" button. * fix(images): rewrite the live status only when its text changes A star press republishes the stream, and the textContent setter replaced the continuation status, the count and the caption date with the same text, so a polite role="status" region could announce it again. Text and the role attribute are now written only when they change. Failing before: a MutationObserver saw 10 records on those nodes after a favorite toggle; now none. * fix(images): Refine's Folder list follows the chosen Source The workspace subfolder discovery returned only the union of every source's folders, so "Source: temp" could be paired with a folder that exists only under output and silently match nothing. In workspace mode each root now lists its own folders, and "Refine this view" offers only the chosen Source's folders: changing Source keeps a folder it also has and otherwise returns Folder to "All output folders", as the old field row did when it reloaded a Source's folders. Failing before: the API test found no per-root folders (KeyError), the dialog unit test and the browser test still offered output-only folders under the input source. * fix(images): an unchanged Refine apply keeps the loaded page "Apply filters" (and "Clear filters" with nothing set) reset the stream, refetched the first page and dropped the reader's scroll position even when no filter changed. Like the toolbar's equality guard, an unchanged refinement now does nothing. Failing before: the browser test counted one listing fetch after an unchanged Apply; now none, and the loaded cards stay in place. * fix(images): one discovery alert when sources and categories both fail With the server unreachable on load, the sources and the categories status paragraphs each fired role="alert" back to back. The page now keeps one alert, written once both first loads settled, naming whatever failed ("Sources, folders and categories could not be loaded. Rescan from Import to retry." when both did). Failing before: getByRole('alert') resolved to two elements. * fix(images): sort toolbar categories alphabetically on the client D36 promises alphabetical real categories, which held only while the server sorted them and a restored category was among its list. The page now sorts them case-insensitively itself, a restored category included. Failing before: the toolbar listed a server's [zeta, Alpha, beta] in that order. * refactor(db): drop the unused pair title from the link summary query _link_summary has not read the pair's own title since the card took the linked positive's Library title (D10), so the query no longer selects it; the row indexes and the stale comment are updated. All values stay bound. Failing before: the summary SQL still selected pp.title. * test(images): end negative checks on real signals, not fixed sleeps The "no second request" checks waited a fixed 150 ms or 1000 ms and the hover probe 450 ms, which can pass vacuously on a slow Firefox or WebKit run. They now read the fetches the page's code started (the API client calls fetch in the same task as the press), wait for a timer of the toolbar's own debounce delay set after the debounced report, and wait for the hover transition to finish. Checked by mutation: without the favorite pending guard or the toolbar equality guard, the rewritten checks fail. * docs(testing): record the Rescan feedback, Source-bound folders and category sort The Images contract now names the Rescan toasts and busy state (D15), the Folder list that follows Source and the no-op unchanged refinement (D14), and the page-side category sort (D36). * test(viewer): escape every regex metacharacter in the filename match * fix(viewer): title a linked card at once instead of waiting for its inspection On a slow runner the viewer showed only the filename until the inspection answered, while the concept titles it immediately. The card's linked title is already loaded, so the header uses it on open. The favorite test now waits for the first request to settle before the Space press, which the one-request-per-file guard otherwise ignores. * fix(images): cap the search at the listing API's 500 characters A longer paste was sent as is, the API rejected it and the collection showed "Images could not be loaded". The legacy search capped it.	2026-10-20 11:31:53 -07:00
Vito	d9537a726c	feat(workspace): complete shared inspector and collection viewer (#224) ... * feat(inspector): expose bounded physical file evidence * fix(inspector): distinguish ambiguous saved associations * feat(inspector): derive conservative generation facts * fix(inspector): guard fact ancestry and inspection state * feat(inspector): share complete file details and exports * fix(inspector): preserve fact states and touch targets * feat(viewer): navigate the loaded media collection Refs #216 * fix(viewer): refit after current stage geometry changes Ref #216. Observe the current media stage after readiness and wrapped title changes without rebuilding focused controls or resetting transforms at unchanged dimensions. * feat(viewer): add lifecycle-safe slideshow and media preferences * fix(viewer): resume gallery continuation after close (#216) * fix(images): guard source recovery and wrap viewer actions Clear stale root and folder intent, cancel old pages, and wait for current source discovery before loading a refreshed collection. Preserve safe retry through failed, superseded, and disposed discovery. Wrap narrow viewer footer actions and wait for measured gallery viewport settling in responsive checks. Refs #216; addresses PR #224 review. * test(viewer): await gallery layout after viewport changes Require actual inner, root client, and document widths to agree after each responsive-case viewport and CSS zoom transition. Keep the existing exact frame, overflow, focus, and coarse target assertions unchanged. Observed PR #224 CI initial mobile resize at537px before pending card relayout settled to356px. Refs #216.	2026-10-18 09:41:53 -07:00
Vito	dc345671ae	feat(workspace): inspect and send positive and negative prompts (#206) ... * feat(workspace): inspect and send positive and negative prompts * docs(workspace): capture complete inspector and viewer previews * docs(inspector): explain the subprocess cleanup race * fix(workspace): defer observed gallery layout writes (#207) * fix(inspector): keep path-only prompt associations unverified	2026-10-17 13:43:19 -07:00