Files
ComfyAssets-ComfyUI_PromptM…/tests/test_pair_ingestion.py
Vito caa9649f32 feat: reuse positive and negative prompt combinations (#195)
* feat(db): add pair schema and stage restore migrations for #193

* feat(database): persist reusable ordered prompt pairs (#193)

* feat(api): expose reusable pairs and atomic metadata enrichment (#193)

* feat(metadata): resolve canonical prompt pairs with bounded provenance (#193)

* feat(scan): enrich image pairs without guessing or duplicate links (#193)

* fix(database): preserve pair tags during global maintenance (#193)

* feat(tracking): enrich live image pairs and cancel scans safely (#193)

* feat(nodes): encode paired prompts and count cached recipe runs (#193)

* fix(database): validate restored pair ownership and provenance (#193)

* feat(admin): report pair scan outcomes and cancellation (#193)

* feat(ui): add paired prompt editor and explicit recipe library for #193

* fix(autocomplete): include reusable pair metadata vocabulary (#193)

* fix(pairs): honor recent sorting and conservative scan outcomes (#193)

* fix(ui): protect paired draft saves and clarify negative variants (#193)

* fix(metadata): preserve bounded paired execution evidence (#193)

* fix(tracking): follow actual pair output roles and prefer execution evidence (#193)

* docs(pairs): document live validation and retain renderer screenshots (#193)

* test(api): inject disposable databases before API startup (#194)

* test(api): canonicalize portable temporary gallery roots (#194)

* docs(ui): prototype branching negative variant history (#193)

* docs(ui): show selected negative beneath positive in timeline concept (#193)

* docs: retain approved timeline for later gallery redesign (#193)

* test(db): close restore fixture connections before cleanup (#194)

* test(db): reuse existing handle guards in all pair fixtures (#194)

* chore: clarify rollback test and intentional exception handling (#193)
2026-10-17 08:00:42 -07:00

163 lines
7.0 KiB
Python

"""Atomic, repeatable metadata enrichment without changing usage counts."""
import tempfile
import unittest
from pathlib import Path
from unittest.mock import patch
try:
from tests.open_handles import assert_closed
except ImportError: # discovered with tests/ as the top-level directory
from open_handles import assert_closed
from database.operations import PromptDatabase
from database.pair_ingestion import ingest_resolved_pair
from utils.hashing import generate_prompt_hash
def resolved(positive="cat", negative="blur"):
return {
"state": "resolved",
"positive": {"text": positive, "provenance": {"source": "api"}},
"negative": {"text": negative, "provenance": {"source": "api"}},
}
class TestPairIngestion(unittest.TestCase):
def setUp(self):
self.temp = tempfile.TemporaryDirectory()
self.db = PromptDatabase(str(Path(self.temp.name) / "test.db"))
self.path = str(Path(self.temp.name) / "image.png")
def tearDown(self):
self.db.close_all()
assert_closed(self, self.temp.name)
self.temp.cleanup()
def test_first_scan_repeat_and_negative_variants_reuse_components(self):
first = ingest_resolved_pair(self.db, self.path, {}, resolved())
self.assertEqual(first["status"], "added")
self.assertEqual(first["pairs_added"], 1)
second = ingest_resolved_pair(self.db, self.path, {}, resolved())
self.assertEqual(second["status"], "unchanged")
self.assertEqual(second["pairs_added"], 0)
pairs = self.db.list_prompt_pairs()["pairs"]
self.assertEqual(len(pairs), 1)
self.assertEqual(pairs[0]["image_count"], 1)
self.assertEqual(pairs[0]["run_count"], 0)
self.assertEqual(
self.db.get_prompt_by_hash(generate_prompt_hash("cat"))["run_count"], 0
)
ingest_resolved_pair(self.db, self.path + "2", {}, resolved(negative="noise"))
self.assertEqual(
self.db.model.get_connection()
.execute("SELECT count(*) FROM prompts")
.fetchone()[0],
3,
)
def test_existing_image_enriched_in_place_and_metadata_preserved(self):
pid = self.db.save_prompt(
"cat", category="Personal", prompt_hash=generate_prompt_hash("cat")
)
image_id = self.db.link_image_to_prompt(pid, self.path)
result = ingest_resolved_pair(
self.db, self.path, {"prompt": {"a": 1}}, resolved()
)
self.assertEqual(result["status"], "enriched")
self.assertEqual(result["image_id"], image_id)
self.assertEqual(self.db.get_prompt_by_id(pid)["category"], "Personal")
row = self.db.get_image_by_id(image_id)
self.assertIn("a", row["prompt_metadata"])
def test_conflicting_image_is_not_reassigned_or_duplicated(self):
pid = self.db.save_prompt("dog", prompt_hash=generate_prompt_hash("dog"))
self.db.link_image_to_prompt(pid, self.path)
result = ingest_resolved_pair(self.db, self.path, {}, resolved())
self.assertEqual(result["status"], "conflict")
self.assertEqual(self.db.list_prompt_pairs()["total"], 0)
self.assertEqual(
self.db.model.get_connection()
.execute("SELECT count(*) FROM generated_images")
.fetchone()[0],
1,
)
def test_unknown_and_missing_negative_never_become_empty_pairs(self):
for state in ("absent", "ambiguous", "unresolved"):
value = resolved()
value["state"] = state
result = ingest_resolved_pair(self.db, self.path, {}, value)
self.assertEqual(result["status"], state)
self.assertEqual(self.db.list_prompt_pairs()["total"], 0)
result = ingest_resolved_pair(self.db, self.path, {}, resolved(negative=""))
self.assertEqual(result["status"], "added")
def test_failure_after_inserts_rolls_back_all_rows(self):
with patch.object(
self.db, "_link_image_to_pair", side_effect=RuntimeError("injected")
):
with self.assertRaises(RuntimeError):
ingest_resolved_pair(self.db, self.path, {}, resolved())
conn = self.db.model.get_connection()
for table in (
"prompts",
"prompt_pairs",
"generated_images",
"image_prompt_pairs",
):
self.assertEqual(
conn.execute(f"SELECT count(*) FROM {table}").fetchone()[0], 0
)
def test_distinct_paths_are_not_collapsed_and_effective_text_stays_in_provenance(
self,
):
value = resolved("prefix cat suffix")
value["positive"]["storage_text"] = "cat"
a = ingest_resolved_pair(self.db, self.path, {}, value)
b = ingest_resolved_pair(
self.db, self.path.replace("image.png", "other/image.png"), {}, value
)
self.assertEqual(a["pair_id"], b["pair_id"])
pair = self.db.get_prompt_pair(a["pair_id"])
self.assertEqual(pair["positive_text"], "cat")
self.assertEqual(pair["image_count"], 2)
association = self.db.get_image_prompt_pairs(a["image_id"])[0]
self.assertEqual(
association["provenance"]["positive"]["text"], "prefix cat suffix"
)
def test_image_lookup_exposes_its_recorded_pair_not_latest_negative(self):
value = resolved("trigger cat", "blur")
value["positive"]["storage_text"] = "cat"
first = ingest_resolved_pair(self.db, self.path, {}, value)
ingest_resolved_pair(self.db, self.path + "2", {}, resolved("cat", "noise"))
info = self.db.get_image_prompt_info(self.path)
self.assertEqual(info["pair"]["id"], first["pair_id"])
self.assertEqual(info["pair"]["negative_text"], "blur")
self.assertEqual(info["pair_context"]["positive_text"], "trigger cat")
self.assertEqual(info["pair_context"]["negative_text"], "blur")
def test_overwritten_file_with_different_negative_reports_conflict(self):
ingest_resolved_pair(self.db, self.path, {}, resolved())
result = ingest_resolved_pair(
self.db, self.path, {}, resolved(negative="noise")
)
self.assertEqual(result["status"], "conflict")
self.assertEqual(self.db.list_prompt_pairs()["total"], 1)
def test_execution_evidence_wins_over_a_prior_inferred_context(self):
inferred = resolved()
for side in ("positive", "negative"):
inferred[side]["provenance"]["text_source"] = "graph-inferred"
ingest_resolved_pair(self.db, self.path, {}, inferred)
execution = resolved("cat, lora_trigger", "blur")
execution["positive"]["storage_text"] = "cat"
for side in ("positive", "negative"):
execution[side]["provenance"]["text_source"] = "execution"
ingest_resolved_pair(self.db, self.path, {}, execution)
info = self.db.get_image_prompt_info(self.path)
self.assertEqual(info["pair_context"]["positive_text"], "cat, lora_trigger")
self.assertEqual(info["pair_context"]["text_source"], "execution")