* fix(gallery): clear only Prompt Manager cache entries (#222)
The legacy gallery's Clear cache deleted every localStorage key starting
pm_ or promptManager_ (the workspace theme and the dismissed update notice
among them) and every CacheStorage cache whose name held gallery or
thumbnail, which on ComfyUI's shared origin can belong to another tool.
web/js/cache-ownership.js names what a clear may remove from an inventory
of the real writers: every key Prompt Manager writes is a preference and no
page opens CacheStorage or IndexedDB, so nothing is removed and the toast
says so. A test fails when a new storage writer is not classified. The
server thumbnail clear stays its own request; a refused or unreachable
server changes nothing and is reported, and refused browser storage is
reported as such.
* feat(system): run reviewed maintenance natively
System › Maintenance is native: the concept's notice and its Database and
Images & cache surfaces replace the hand-off.
- Integrity & relationship checks runs the health check; the report's
Review missing links reviews a fresh Missing-file links plan.
- Review plan shows the server's read-only plan (D100): scope, protected,
backup policy and media lines, the listed records, how long the review
holds and the backup box; Apply reviewed operation sends only its token
and opens the job in Activity. busy names the running job, plan-used links
the job that applied it, an expired or replaced review is reviewed again,
and a lost answer says Outcome not confirmed and points to Activity.
- Find duplicates starts the search; its view offers Review groups (D101):
ten groups at a time, Keep radios per copy, each keeper sent as
{group_id, root_index, path}; the dialog says History keeps the removed
paths in its run records.
- Thumbnail cache opens the thumbnail dialog; Metadata cache is disabled
with its reason while nothing is owned (D102, Q5).
- Activity descriptors for maintenance, duplicates and duplicate_cleanup.
- The legacy duplicates dialog's View Full names its source (?root=).
* test(system): compare Maintenance with the concept
system-maintenance-concept.spec compares System › Maintenance, the plan
dialog of each operation and the duplicates dialog with the concept in both
themes and both viewports, mapped only by D100–D102, and proves a mutated
row, label, danger mark or token is noticed. The duplicates dialog's Review
duplicate cleanup is the concept's plain button.
* test(system): Maintenance no longer hands off; raise coverage floors
The System shell test expected Maintenance's D94 hand-off; the section is
native now. coverage:update sets the new modules' floors from the
measured run (cache-ownership 94, maintenance-review 94,
system-maintenance 92 lines) and raises the floors other files passed.
* test(admin): close the preview worker after the last job in teardown
A scan publishes its last event, which ends the stream the test reads,
before it hands its missing previews to the automatic worker. That
hand-off can run after tearDownAsync closed the worker, so it starts a new
one whose .part files were still open when the final drain checked for
open handles (py3.10 on ubuntu, test_scan_reads_metadata_on_several_threads).
The drain now closes the worker for good once every job has ended.
* fix(system): address the S7 final review
- I1: an apply answer is a refusal only when our server sent it (a known
code, or a 4xx whose body says success:false); a proxy's 5xx, an
unreadable 2xx or a dropped connection says Outcome not confirmed and
reads Activity again. ApiError gains 'refused'; the server's own
pre-start failure is coded 'apply-failed'.
- M1: the lost-response test lets the apply run, then drops its answer.
- M2: a failed apply records its code in the job's scope; Activity offers
Review again for an overtaken plan (Maintenance for a duplicate cleanup
whose sources changed).
- M3: a failed duplicate cleanup toasts the server's reason.
- M4: a review button holds while its preview is read (one preview per
double press).
- M5: the storage guard also catches bracket and property assignment and
CacheStorage/IndexedDB opens; why the Toolkit build is skipped is
written down.
- M6: a refused storage listing says so on the Metadata cache row.
- M7, M8: D100 text corrected; workflow_storage has its title.
- M9: a busy start names the job the server named.
* test: follow #319 in the Maintenance tests
- The thumbnail dialog has only Scope since #319.
- The admin teardown refuses new preview workers on its own API instead
of closing with final=True, which since #319 also shuts the process-wide
encoders that later test modules use.
* fix(system): keep the server's search-again line on a duplicate review
A duplicate cleanup review the server refuses with 409 sources-changed
showed the generic "could not be reviewed" message; it now shows the
server's "The sources changed since the search. Search for duplicates
again."
* fix(system): a plan with nothing to do offers only Close
A reviewed maintenance plan whose scope is 0 records ("No duplicate
prompt text") offered Apply reviewed operation, which started an empty
job. It now shows its rows, "There is nothing to apply; nothing was
changed." and a Close button.
* fix(system): wrap long copy paths in the duplicates review
A Keep label is the copy's source and path, and dataset folders often have
long names with no space to break at, so the review scrolled sideways.
The label now wraps anywhere inside its compare item (D101).
Vito
9ab25f9aaa