Vito
d88cf9e7c6
* fix(quality): preserve cursor iteration and option validation Keep prefetched rows on ManagedCursor so partial loops and explicit fetches share one position, and stop existing iterators after close or retirement. Preserve chunked reads and native SQLite result lifetime on reexecution and errors. Catch OptionError before ValueError so legacy auto-tag requests receive the actual validation error. Remove the overwritten ViewerJS title option. Regression tests failed before the fixes for lost rows, reads after close/retirement, and misleading option errors. Focused Python checks pass; cursor checks also pass on Python 3.13 and 3.14. Refs #321. * fix(quality): make the test doubles legal raises and hashes The fake queue no longer raises an attribute that starts as None. The oversized kind records hashes instead of raising from __hash__, which also catches a hash that production code swallows. Hostile.__bool__ raises the TypeError a truth test may raise. * fix(quality): drop the extra saveCoverage argument * refactor(quality): remove assignments that are overwritten before use * refactor(quality): remove the remaining overwritten test assignments * refactor(quality): drop imports repeated inside functions * refactor(quality): give duplicate identity keys one shape * refactor(quality): name the unused job event loop variable * refactor(quality): release model gates in finally, not except BaseException * refactor(quality): end the job runners with an explicit return * refactor(quality): use the precise unittest asserts * refactor(quality): import unittest.mock one way in the tests * fix(quality): say why each empty except is safe, log the broad ones * refactor(quality): stop binding values the tests never read * refactor(quality): remove the unused preview aliases and tag page query * refactor(quality): remove re-exports nothing imports * refactor(quality): parenthesize deliberate string joins in lists * refactor(quality): remove unused JavaScript variables and imports * refactor(quality): use the precise assert in the model status test
93 lines
3.1 KiB
Python
93 lines
3.1 KiB
Python
"""#516: the browser test server pins glibc's mmap threshold.
|
|
|
|
Large frees then go back to the OS instead of fragmenting per-thread arenas.
|
|
"""
|
|
|
|
import ctypes
|
|
import sys
|
|
import unittest
|
|
import unittest.mock as mock
|
|
|
|
from tests.browser import malloc_tuning
|
|
|
|
|
|
class FakeLibc:
|
|
def __init__(self, result=1):
|
|
self.calls = []
|
|
self.result = result
|
|
|
|
def mallopt(self, option, value):
|
|
self.calls.append((option, value))
|
|
return self.result
|
|
|
|
|
|
class PinMmapThresholdTests(unittest.TestCase):
|
|
def test_sets_a_fixed_threshold_through_mallopt(self):
|
|
libc = FakeLibc()
|
|
with mock.patch.object(sys, "platform", "linux"):
|
|
self.assertTrue(malloc_tuning.pin_mmap_threshold(libc))
|
|
# M_MMAP_THRESHOLD is -3; setting it also turns off glibc's dynamic
|
|
# raising of the threshold.
|
|
self.assertEqual(libc.calls, [(-3, 128 * 1024)])
|
|
|
|
def test_reports_a_refused_setting(self):
|
|
with mock.patch.object(sys, "platform", "linux"):
|
|
self.assertFalse(malloc_tuning.pin_mmap_threshold(FakeLibc(result=0)))
|
|
|
|
def test_skips_a_libc_without_mallopt(self):
|
|
with mock.patch.object(sys, "platform", "linux"):
|
|
self.assertFalse(malloc_tuning.pin_mmap_threshold(object()))
|
|
|
|
def test_skips_other_platforms_without_loading_a_libc(self):
|
|
for name in ("win32", "darwin"):
|
|
with (
|
|
self.subTest(name),
|
|
mock.patch.object(sys, "platform", name),
|
|
mock.patch.object(
|
|
ctypes, "CDLL", side_effect=AssertionError("no libc load")
|
|
),
|
|
):
|
|
self.assertFalse(malloc_tuning.pin_mmap_threshold())
|
|
|
|
def test_skips_when_the_process_libc_cannot_be_loaded(self):
|
|
with (
|
|
mock.patch.object(sys, "platform", "linux"),
|
|
mock.patch.object(ctypes, "CDLL", side_effect=OSError("no libc")),
|
|
):
|
|
self.assertFalse(malloc_tuning.pin_mmap_threshold())
|
|
|
|
@unittest.skipUnless(
|
|
sys.platform.startswith("linux")
|
|
and hasattr(ctypes.CDLL(None), "gnu_get_libc_version"),
|
|
"glibc only",
|
|
)
|
|
def test_glibc_accepts_the_setting(self):
|
|
# This pins the threshold for the rest of this test process too; the
|
|
# test server does the same at start, so nothing here depends on it.
|
|
self.assertTrue(malloc_tuning.pin_mmap_threshold())
|
|
|
|
|
|
class ServerMainTests(unittest.TestCase):
|
|
def test_main_pins_the_threshold_before_it_starts_serving(self):
|
|
from tests.browser import server
|
|
|
|
order = []
|
|
|
|
def bind(port):
|
|
order.append("bind")
|
|
raise RuntimeError("stop before serving")
|
|
|
|
with (
|
|
mock.patch.object(
|
|
server, "pin_mmap_threshold", side_effect=lambda: order.append("pin")
|
|
),
|
|
mock.patch.object(server, "bind_listener", side_effect=bind),
|
|
):
|
|
with self.assertRaises(RuntimeError):
|
|
server.main(["--port", "0"])
|
|
self.assertEqual(order, ["pin", "bind"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|