Vito Sansevero
4ac9df6006
The history's Negative variants panel is the concept's (app.js a598,
style.css 1059-1154): section.surface.timeline-panel with the panel
heading (h2, p.small "Choose a red dot to change the negative and filter
this gallery."), row actions Compare negatives (aria-pressed; its section
is Task F3), + Add negative and the approved Show archived; a .timeline of
.positive-lane and .variant-lane rows (--lane-offset 38 + 47i) with the
"−" .variant-dot, "<name> · N runs" and a .run-dot when the pair's
run_count > 1; and .timeline-lower with the legend and All images for
this positive.
D26: All images for this positive opens the concept dialog with the
embedded, bounded (Load more) media gallery instead of filtering the
shared gallery. The run dot opens Recorded run for the pair's newest
recorded execution, else a Repeat run dialog with the pair's newest
linked image. Backing data:
- library variants carry prompt_pairs.run_count;
- GET /prompt_manager/library/{positive_id}/history/pairs/{pair_id}/newest
reads the newest run in the positive's exact raw-text scope whose
current-epoch saved-pair hint still resolves to that pair (the
get_history_run hint rule), inside the fenced history snapshot.
- workspace-dialogs gains openContentDialog (onClose releases the body).
- mountRecordedHistory returns openRun.
D45 (new deviations):
- a dot is named "Select negative <title>" when no other loaded lane has
that title, else "Select negative variant N", so names stay unique;
- the bounded "N of M saved negative variants" count stays a visually
hidden status; "Saved combinations, not an execution timeline." is gone;
- archived lanes (#235) are concept lanes marked .library-variant-archived
at .6 emphasis with their Restore button; coarse dots keep a 47px
target; the heading, legend row and All images button wrap at 390px
and 200% zoom.
Retired CSS: .library-branches, .library-positive-lane,
.library-variant-lane, .library-variant-dot, .library-variants,
.library-panel-heading, .library-variant-footer, .library-variant-summary.
Selector mapping:
- .library-variants -> .library-history .timeline-panel (region "Saved
negative variants" unchanged)
- .library-branches -> .timeline; .library-positive-lane -> .positive-lane
- .library-variant-lane -> .variant-lane; .library-variant-dot -> .variant-dot
- .library-variant-archived and .library-variant-restore unchanged
- .library-variant-footer / button:last-child -> .timeline-lower / button
- .library-variants > p.muted -> .timeline-panel .panel-heading .small
- "Select negative variant N" -> "Select negative <title>" for titled
pairs (history, native library, inspector, visual and real-host
fixtures); untitled pairs unchanged
- lane text "· N linked image(s)" -> "· N run(s)"
- All images for this positive: aria-pressed filter -> dialog "All images
for this positive"; tests that used it for the whole gallery select the
lane linking the image, or read the dialog
- variant panel row actions gain Compare negatives first
Tests: new workspace-history "variants panel matches the concept", "run
dot appears only for pairs with more than one run and opens its run",
"all images dialog lists every image for the positive"; new
workspace-library-editor "show archived and restore still work" (all four
failed before the change). Python: variants carry run_count, newest pair
run (DB and route). Unit: content dialog. The history fixture counts two
canonical pairs and links one image to Clean geometry.
50 lines
3.8 KiB
JavaScript
50 lines
3.8 KiB
JavaScript
import {test,expect} from '../../tools/vendor/node_modules/@playwright/test/index.mjs';
|
|
import {captureCanonicalState} from './history-canonical-comparison.mjs';
|
|
|
|
// Artifact-only captures of the editor states that have no concept counterpart (archive confirmation, Show archived,
|
|
// busy and error). The four concept-referenced modes are captured as concept/production pairs by
|
|
// workspace-library-editor.spec.mjs. There are deliberately no pixel assertions or baselines: the maintainer accepts
|
|
// these captures visually before any baseline is added.
|
|
test.use({locale:'en-US',timezoneId:'UTC',reducedMotion:'reduce'});
|
|
const workspace='/prompt_manager/workspace';
|
|
const editor=page=>page.locator('dialog.library-editor');
|
|
const variants=page=>page.getByRole('region',{name:'Saved negative variants',exact:true});
|
|
const note=page=>editor(page).locator('.warning-note');
|
|
|
|
test.beforeEach(async({page,request})=>{
|
|
const reset=await request.post('/__test__/library-editor/reset',{data:{}});await expect(reset).toBeOK();page.fixture=await reset.json();
|
|
});
|
|
|
|
for(const [width,height,theme] of [[1600,1100,'dark'],[390,844,'light']])test(`editor state captures for maintainer acceptance ${width} ${theme}`,async({page},testInfo)=>{
|
|
await page.setViewportSize({width,height});const f=page.fixture;
|
|
await page.goto(`${workspace}#/library/${f.positive_id}`);await expect(variants(page)).toBeVisible();
|
|
await page.getByRole('combobox',{name:'Theme',exact:true}).selectOption(theme);
|
|
const shot=name=>captureCanonicalState(page,testInfo,`production-${name}-${width}-${theme}`,name.startsWith('editor-archived')?'.library-history .timeline-panel':'dialog.library-editor');
|
|
|
|
await variants(page).getByRole('button',{name:'Select negative variant 2',exact:true}).click();
|
|
await page.getByRole('button',{name:'Edit metadata',exact:true}).click();await expect(editor(page)).toBeVisible();
|
|
await expect(editor(page).getByRole('button',{name:'Save',exact:true})).toBeEnabled();
|
|
await editor(page).getByRole('button',{name:'Archive…',exact:true}).click();
|
|
await expect(editor(page).getByRole('button',{name:'Archive',exact:true})).toBeEnabled();await shot('editor-archive');
|
|
|
|
let release;const held=new Promise(resolve=>{release=resolve;});
|
|
await page.route(`**/prompt_manager/pairs/${f.pair_id}`,async route=>{if(route.request().method()==='PATCH')await held;await route.continue();});
|
|
await editor(page).getByRole('button',{name:'Archive',exact:true}).click();
|
|
await expect(note(page)).toBeVisible();await shot('editor-busy');
|
|
release();await expect(editor(page)).toHaveCount(0);await page.unroute(`**/prompt_manager/pairs/${f.pair_id}`);
|
|
|
|
await variants(page).getByRole('button',{name:/^Show archived/}).click();
|
|
await expect(variants(page).locator('.library-variant-archived').first()).toBeVisible();await shot('editor-archived-library');
|
|
|
|
await page.goto(`${workspace}#/library`);await page.getByRole('button',{name:'+ New prompt',exact:true}).click();
|
|
await expect(editor(page).getByRole('button',{name:'Save',exact:true})).toBeEnabled();
|
|
await page.route('**/prompt_manager/library',route=>route.request().method()==='POST'
|
|
?route.fulfill({status:400,contentType:'application/json',body:'{"success":false,"error":"Title is too long.","code":null}'}):route.continue(),{times:1});
|
|
await editor(page).getByLabel('Title',{exact:true}).fill(`Long title ${'W'.repeat(160)} with a very long tail`);
|
|
await editor(page).getByLabel('Positive prompt',{exact:true}).fill('A quiet harbor at dawn');
|
|
await editor(page).getByLabel('Notes',{exact:true}).fill(Array.from({length:40},(_,index)=>`Long note line ${index}`).join('\n'));
|
|
await editor(page).getByRole('button',{name:'Save',exact:true}).click();
|
|
await expect(note(page)).toHaveText('Not saved: Title is too long. Your entries are kept.');
|
|
await shot('editor-long-error');
|
|
});
|