* feat(system): share browser display defaults
The workspace reads and writes the legacy gallery's gallerySettings object
through preferences.mjs: workspaceLayout and workspaceDensity join the
shared keys, a write re-reads the stored object and writes only the changed
keys, denied storage or a full quota keeps the change for this tab and says
so, and storage events report changes from other pages. The legacy gallery
Save keeps keys it does not edit, and the viewer reads its video defaults
through the shared module.
* feat(system): Appearance defaults used by Images and the viewer
System > Appearance is the concept's Browsing & display surface on real
values: the browser rows edit this browser's display defaults through the
shared gallerySettings object, and Open from ComfyUI and the node search
auto-hide save to the server settings with their revision. A new Images
visit starts from the default layout and size (the current view and saved
views keep theirs); metadata off waits for Load metadata; cache off re-reads
the shown file; paths off hides the Path row; the viewer reads the video
defaults. D97 adds card details, collapsed viewer details and Reset display
defaults; storage refused says Saved for this tab only.
* fix(system): flag changes made while System was closed and keep embedded galleries fixed
Final review fixes for System S3 (Appearance):
- I1: the on-demand metadata deviation is D124 (TESTING.md, inspector
markers); TESTING.md names the spec that pins it, since no concept
comparison renders that state.
- I2: System checks the display defaults for conflicts on mount, not only
on storage events, and a browser write refuses a draft another page
overtook, so a draft is never saved over another tab's value without
the conflict status first. New two-tab spec.
- I3: the layout and size defaults start the Images page only; embedded
galleries (a prompt history's Shared gallery and dialogs) keep
Grid/Comfortable.
- M1: host rows whose /settings read failed say "Server settings could
not be read."
- M2: a rejected timeout shows the "Some changes were not saved" status.
- M3: the browser loads on mount and on storage events never reject
unhandled.
- M4: the next accepted write stores the tab-only changes and clears the
overlay.
- M5: cache off never re-reads a source-changed selection, and refresh()
never loads a deferred one.
- M6: the System fixture refuses a config.json outside its temp root and
restores it with os.replace.
- M7: the inspection read counts wait on a request barrier, not frames.
- M8 recorded as an open saved-views question in TESTING.md.
* fix(system): answer a failed System read only after its other reads finish
CI (py3.10 on ubuntu) crashed with a segfault inside SQLite in
test_statistics_failure_is_an_error_envelope: the statistics and overview
routes used asyncio.gather without return_exceptions, so the 500 answered
on the first failure while get_statistics still ran in the executor, and
the test tore the database down under it. Both routes now await every
read before raising the first failure (failing before, passing after:
TestFailedReadsSettleFirst).
The frontend coverage merge failed on workspace/activity.mjs branches
(86.3 < 87): no test asserted Activity's empty and failed-read states, so
their branch was only reached in passing, depending on timing. A spec now
asserts both.
Vito
785b744554