* feat(maintenance): reviewed, read-only maintenance plans POST /prompt_manager/maintenance/preview reviews duplicate_prompts, optimize, unused_components or missing_links on its own mode=ro snapshot and answers a Plan (scope, protected reasons, backup policy, media, at most 50 detail rows). The fingerprint, targets and judged sources stay in a server-side PlanStore under a single-use token (15 min, 8 plans, 16 MiB, never truncated; a restart forgets them), bound to the database it read. The previews reuse the legacy queries: duplicate groups and the merge are shared with cleanup_duplicates, ORPHANED_PROMPTS_SQL is built from the #239 protection predicates the plan reports, and missing links are judged by the health check's link_states. Legacy /maintenance keeps its shape; vacuum now reports success:false when VACUUM fails, and cleanup_orphaned_images skips links under unavailable sources. * feat(maintenance): apply reviewed plans as Activity jobs POST /prompt_manager/maintenance/apply {token} starts a maintenance job (records admission, not cancellable, groups changed/protected/errors). The token is consumed on the loop turn the job starts: a second apply is 409 plan-used naming the job, a busy refusal keeps the token, an unknown or expired one is 410 plan-expired, and a restore since the review is 409 storage-changed. With the safety backup policy on (maintenance.safety_backup, default true, saved through the settings route with the revision), the job first writes a backup into a temp file beside the database, makes it a standalone rollback-journal file, verifies it, fsyncs it and renames it onto a unique <db>.backup_<YYYYmmdd_HHMMSS_ffffff>[_n] name; any failure leaves no file and nothing changed. The apply then rechecks the reviewed fingerprint inside BEGIN IMMEDIATE (plan-changed writes nothing), deletes in batches of 400 ids, counts changed and protected records, logs the backup by name only and prunes old safety backups. With the policy off the log and the status line say "No safety backup". * feat(maintenance): find and remove duplicate files through Activity Duplicate image files move onto the job registry: - POST /prompt_manager/jobs/duplicates finds content-identical media files over every effective source as a cancellable read job ("Find duplicate image files", group groups_found); the server holds the groups per job and GET /prompt_manager/maintenance/duplicates/{id} pages them ten at a time. - The duplicate_files preview binds a removal to the reviewed keepers. Every keeper and removal is checked again: containment as text before any filesystem access, then not a link, still inside its source, same size and hash. The plan lists the database links that move. - Apply runs duplicate_cleanup (records, not cancellable): the promised safety backup, then per file a recheck, the unlink with every handle closed and its thumbnail. A changed file is kept, the first failed unlink stops the job with a coded message (never the OS text), and only removed files have their image links and favorites moved to the kept copy. - The legacy scan, stream, status and delete routes keep their shapes on the same registry kinds; the hashing, grouping and thumbnail removal are shared with them. Coordinator rulings on Tasks 15-16: - Safety backups share the restore pool of 10 `<db>.backup_*` files; the pool is now also pruned when an apply fails after its backup. - Plans report the safety backup's size and the free disk space, and apply refuses up front (507 insufficient-space) when the backup or VACUUM does not fit, so no job fails halfway for space. * fix(maintenance): never remove the kept copy; move records before unlink Final review of #313: - C1: the duplicate find tells files apart by (st_dev, st_ino), so a source listed twice, a symlinked source inside another and a hardlink are one file. The preview and the job refuse a removal that os.path.samestat matches with its kept copy. - I1: each file's records move to its verified kept copy in one short transaction before that file is unlinked; a failed move deletes nothing and a failed unlink leaves the records on the identical kept copy. The status line counts files removed and not removed. - I2: links are looked up under every spelling of the source (the real path, the configured and monitored folders, ComfyUI's output). - I5: image tags join the kept copy as their union and the removed copy's pending, undecided Needs review items are settled; the plan says so. - I3: the VACUUM disk check measures SQLite's real temporary folder. - M1: the token is looked at again with no await before the job starts. - M2: the backup decision is made once and handed to the job. - M3: backups are linked into place; startup sweeps interrupted temps. - M4: Optimize runs alone (new "exclusive" admission) and its plan says the database is locked while VACUUM runs. - M5: the reviewed duplicate merge is strict: collisions and Library titles are protected, and errors roll back. The legacy cleanup is unchanged. - M7: 2,000 keep entries within a 1 MiB body. M8: event waits in tests. - M9: the preview binds files by size, mtime and inode without hashing; the job hashes right before each unlink. * fix(maintenance): protect one file reached through two mounts Re-review of #313, round 2: - R1: a removal on another device than its kept copy, with the same size and mtimes within 2 s, is protected when its inode is equal or its path within its source is the same ("May be the same file reached through another mount or share"), in the preview and again right before each unlink. The job holds the kept copy open during the unlink, so on Windows deleting the kept copy itself through another path fails. - R2: a file's spellings are found by containment: every configured, monitored, ComfyUI-output or listed folder whose stat identity is a folder above the file. Parent spellings of nested sources and case variants match; favorites move under every listed root holding the file. Lookups stay index searches. - m1: a failed unlink's row says the links now name the kept copy. - m2: a volume with no file ids reads "Can't confirm this is a separate file on this drive". * fix(maintenance): stat duplicate candidates with os.stat Python 3.10's Path.stat uses the os.stat bound when pathlib was imported, so the find and the per-file checks could see different stat calls. The find now calls os.stat directly, like every other check; the mount tests failed on py3.10 only. * fix(maintenance): recheck the kept copy right before each unlink Re-review 2 of #313: - n1: the cross-mount guard also matches when one path within its source ends with the other on a whole folder name (sources listed at different depths, e.g. 2024/x.png and x.png on a FUSE or noserverino mount). - n2: after a file's records move and right before its unlink, the held kept copy must still be the file at its path (fstat of the hold against os.stat) and the cross-mount guard must still hold; otherwise the file is kept, its records move back to it, and it counts as not removed. * test(maintenance): the kept-copy race tests hold on Windows On Windows the removal job holds the kept copy open without FILE_SHARE_DELETE, so the tests' attempt to delete or replace it during the record move is refused. The tests now assert that native outcome: the kept copy stays and the removal goes ahead. * feat(database): store each workflow and prompt graph once generated_images.workflow_data and prompt_metadata repeated the same large JSON text for every image of a run. Each distinct text now lives once in workflow_documents, keyed by the sha256 of its exact UTF-8 bytes and zlib-compressed; image rows reference it through workflow_document_id and prompt_document_id. - New writes (link_image_to_prompt, pair ingestion for scan, monitor and Needs review) store the new form. Old rows keep their inline text and read the same until the migration rewrites them. - Every reader goes through one accessor (read_stored_text, resolve_image_row): gallery and legacy image lists, image by id, prompt info for the inspector and metadata page, diagnostics. Payloads keep their shape. Inline text wins when present; a document that fails its length or hash check reads as unreadable, never as other text. - No trigger (restore validators refuse them): a document goes in the same transaction as its last reference (image and prompt deletes, missing-link cleanup, duplicate merges, duplicate-file link merges, ingestion updates), and a sweep at startup catches anything a path missed. - verify_database_file validates the table, the id columns, their foreign keys and indexes, and the stored values. * feat(database): migrate old workflow rows in batches, then reclaim space The workflow storage migration rewrites old-form image rows (text inline) to document ids, batch by batch: - Each batch is one BEGIN IMMEDIATE transaction of at most 200 rows or 16 MB of text, found by a rowid range search and read one row at a time. - Each text is stored or reused, then read back through the one accessor before its row changes; a text that would not come back identical fails and rolls back the whole batch. - A value that is not text stays inline and is counted as protected. - A crash or a stop leaves committed batches new form and the rest old form; both read the same, and a rerun continues. No media file is opened. - Unreferenced documents are swept at the end. The maintenance preview gains a read-only workflow_storage plan (records to rewrite, inline bytes where SQLite has octet_length, the Reclaim space and older-version notes). reclaim_space sweeps, runs VACUUM and truncates the WAL so the freed pages go back to the disk. * feat(maintenance): store each workflow once as an Activity job The reviewed maintenance plan gains workflow_storage. Applying it starts "Store each workflow once": kind maintenance, records admission, cancellable, groups changed/protected/errors. - The promised verified safety backup comes first; a failed backup ends the job with nothing rewritten. The apply's up-front disk check covers it. - Old-form rows are rewritten batch by batch on the event loop's executor, with progress after each committed batch. Cancel stops between batches; a failed batch rolls back whole and fails the job with a coded message. Either way every record reads as before and the next apply continues. - When every row was looked at, "Reclaim space" starts: exclusive (runs alone), not cancellable. It checks the disk for VACUUM's copies of the live pages, then sweeps, runs VACUUM and truncates the WAL. If another job holds the registry it does not start, and the finished migration says so and names Optimize database. - No image or video file is opened; tests track every open under the output folder and compare the media bytes and mtimes. * feat(maintenance): document the workflow storage contract TESTING.md's maintenance contract gains the workflow storage rules: the documents table and its two forms, the one accessor, garbage in the same transaction plus the sweeps, the batched migration and Reclaim space, the media and memory guarantees, and that a deduped backup cannot be restored into an older version. A test covers the preview on SQLite before 3.43 (no octet_length, as in older Windows Python builds): the inline-bytes detail is left out. * feat(database): keep the migration safe row by row and beside other writers Final review fixes M1, M2, M3 and M5 for the workflow storage dedupe: - M1: a batch also ends after 0.5 s, and the loop leaves the write lock free for 0.15 s after each committed batch (longer than SQLite's longest busy poll), so the image monitor and run counting on another connection get in between. RED: a threaded writer with a 2 s busy timeout hit "database is locked" (4 of 5 links landed). - M2: each row runs in its own savepoint. A row that cannot be rewritten (undecodable text, a text that would not come back) is rolled back alone, stays inline and is listed in errors; the rest of the batch goes on. - M3: a reused document is decompressed and checked before its id is handed out, and repaired from the text (whose hash is its key) when damaged; verify_database_file reads every document and refuses a damaged one. - M5: the two legacy generated_images rebuilds refuse a file that already has the document id columns instead of dropping them. - The preview names the pre-migration backup and says it is always taken. * feat(maintenance): always back up before storing workflows once Final review fixes I1, I2 and I3 for the workflow storage dedupe: - I1: the migration always takes a verified backup, whatever maintenance.safety_backup says; the plan reports backup.policy "required" and the disk check counts it. - I2: that backup is prompts.db.pre-workflow-storage_<stamp>, outside the pruned prompts.db.backup_* pool and kept until the user removes it; the job's last line and the preview name it, and the legacy restore accepts it. README's changelog warns that an older version opens and restores a rewritten database but shows no workflows, and says how to go back. - I3: tools/workflow_text_digests.py writes the sha256 of every record's stored texts (read-only; inline before the rewrite, through the accessor after), so a diff before and after proves byte identity. - A row the migration could not rewrite is listed in the job's errors and named in its last line, and Reclaim space still runs. * feat(database): fail the batch on system errors and name a damaged document Re-review fixes R1 and R6 (database side), plus R3's helpers: - R1: a row is kept inline only for its own cause: text SQLite cannot decode, or a text that would not come back. A full disk, an I/O error, a malformed database or a bug now fails the batch and rolls it back, instead of listing every remaining row as "could not be rewritten". - R6: verify_database_file names the damaged document and says what to do (restore a backup from before the damage, or store an image with the same workflow, which repairs it). - R3: pre_migration_backups lists the kept backups, earliest first; the plan says "Nothing to rewrite" and names an existing kept backup, and the older version note says new images use the new form from the first start and names the earliest backup as the way back. * feat(maintenance): one kept pre-migration backup and nothing-to-do refusal Re-review fixes R2, R3, R4, R5 and R6 (job side): - R3: Apply refuses a plan with nothing to rewrite (409 nothing-to-do, no job, no backup). Only the first apply keeps a pre-workflow-storage backup; later applies (after a Cancel, a rerun) take a pooled safety backup, forced on whatever the policy, so one copy is never pruned. - R4: a second-connection writer test runs against the live job loop; with its pause removed the writer hits "database is locked" (4 of 5 links). - R5: the digest tool loads only database/workflow_documents.py by path (no package start-up, no log handler) and opens a stopped database with immutable=1, so it leaves no -wal/-shm; a live one is read through its WAL. - R6: a backup that fails on a damaged document says which one in the job line. - R2: README's changelog says images recorded by this version use the new form from the first start, and the way back is the earliest pre-workflow-storage backup (or a pre-update backup if the job never ran).
478 lines
20 KiB
Python
478 lines
20 KiB
Python
"""Each workflow and prompt graph stored once, compressed (#249 S6 carry-over).
|
|
|
|
``generated_images.workflow_data`` (the UI workflow) and ``prompt_metadata``
|
|
(the API prompt graph) used to hold the same large JSON text again for every
|
|
image of a run. Now each distinct text is one ``workflow_documents`` row:
|
|
|
|
- ``sha256``: the SHA-256 of the text's exact UTF-8 bytes (unique key);
|
|
- ``byte_length``: the length of those bytes;
|
|
- ``data``: ``zlib.compress`` of those bytes.
|
|
|
|
An image row references its texts through ``workflow_document_id`` and
|
|
``prompt_document_id``. Two forms coexist until the migration has rewritten
|
|
every row, and both stay readable forever:
|
|
|
|
- old form: the text inline in ``workflow_data`` / ``prompt_metadata``, no id;
|
|
- new form: the inline column NULL and the document id set.
|
|
|
|
The text is stored and hashed exactly as written, never parsed and
|
|
re-serialized, because a JSON round trip can change bytes (key order,
|
|
spacing, number spelling, duplicate keys, ComfyUI's ``NaN`` tokens).
|
|
|
|
``read_stored_text`` is the one decoder. Inline text, when present, wins (a
|
|
row an older app version rewrote inline stays right); otherwise the document
|
|
is read by its rowid, decompressed within its recorded length and checked
|
|
against its length and hash. A document that fails a check reads as
|
|
unreadable (None, logged), never as other text. ``resolve_image_row`` puts
|
|
the texts back into a ``generated_images`` row and drops the id keys, so
|
|
every payload keeps its shape.
|
|
|
|
No trigger: every restore validator refuses triggers in a restored file. A
|
|
document is removed in code: ``release_documents`` in the same transaction
|
|
that drops a row's last reference, and ``sweep_documents`` (at startup, after
|
|
the migration and before Reclaim space) for anything a path missed.
|
|
"""
|
|
|
|
import hashlib
|
|
import logging
|
|
import re
|
|
import sqlite3
|
|
import zlib
|
|
from collections import OrderedDict
|
|
from typing import Any, Dict, Iterable, Optional, Set
|
|
|
|
logger = logging.getLogger("prompt_manager.database.workflow_documents")
|
|
|
|
TABLE = "workflow_documents"
|
|
# (inline text column, document id column) on generated_images.
|
|
TEXT_COLUMNS = (
|
|
("workflow_data", "workflow_document_id"),
|
|
("prompt_metadata", "prompt_document_id"),
|
|
)
|
|
DOCUMENT_ID_COLUMNS = tuple(reference for _column, reference in TEXT_COLUMNS)
|
|
INDEXES = {
|
|
"workflow_document_id": "idx_image_workflow_document",
|
|
"prompt_document_id": "idx_image_prompt_document",
|
|
}
|
|
COMPRESSION_LEVEL = 6
|
|
# A text larger than this stays inline: a document is decompressed in one
|
|
# piece, and its recorded length bounds that (a restored file cannot make a
|
|
# small row expand without limit).
|
|
MAX_DOCUMENT_BYTES = 256 * 2**20
|
|
ID_BATCH = 400 # ids bound per statement (under SQLite's old 999 limit)
|
|
|
|
_DDL = (
|
|
f"CREATE TABLE {TABLE} (id INTEGER PRIMARY KEY, sha256 BLOB NOT NULL UNIQUE, "
|
|
"byte_length INTEGER NOT NULL, data BLOB NOT NULL)"
|
|
)
|
|
_AUTOINDEX = f"sqlite_autoindex_{TABLE}_1"
|
|
_REFERENCE_TYPE = f"INTEGER REFERENCES {TABLE}(id)"
|
|
|
|
_UNREFERENCED = (
|
|
"NOT EXISTS (SELECT 1 FROM generated_images g "
|
|
"WHERE g.workflow_document_id=workflow_documents.id) "
|
|
"AND NOT EXISTS (SELECT 1 FROM generated_images g "
|
|
"WHERE g.prompt_document_id=workflow_documents.id)"
|
|
)
|
|
LOOKUP_SQL = (
|
|
"SELECT id, sha256, byte_length, data FROM workflow_documents WHERE sha256=?"
|
|
)
|
|
REPAIR_SQL = "UPDATE workflow_documents SET byte_length=?, data=? WHERE id=?"
|
|
ALL_DOCUMENTS_SQL = "SELECT sha256, byte_length, data, id FROM workflow_documents"
|
|
READ_SQL = "SELECT sha256, byte_length, data FROM workflow_documents WHERE id=?"
|
|
INSERT_SQL = (
|
|
"INSERT INTO workflow_documents (sha256, byte_length, data) VALUES (?, ?, ?)"
|
|
)
|
|
# Built from constants only; the ids are bound as "?" marks.
|
|
RELEASE_SQL = "DELETE FROM workflow_documents WHERE id IN ({marks}) AND "
|
|
RELEASE_SQL += _UNREFERENCED
|
|
# The sweep walks the ids through the small unique index, not the blobs.
|
|
SWEEP_SQL = (
|
|
"DELETE FROM workflow_documents WHERE id IN (SELECT id FROM workflow_documents "
|
|
"INDEXED BY sqlite_autoindex_workflow_documents_1 WHERE "
|
|
)
|
|
SWEEP_SQL += _UNREFERENCED + ")"
|
|
IMAGE_DOCUMENTS_SQL = (
|
|
"SELECT workflow_document_id, prompt_document_id FROM generated_images WHERE "
|
|
)
|
|
|
|
# Statements whose query plans tests/test_workflow_documents.py records.
|
|
QUERY_PLAN_STATEMENTS = {
|
|
"lookup by hash": (LOOKUP_SQL, (b"\0" * 32,)),
|
|
"read by id": (READ_SQL, (1,)),
|
|
"release": (RELEASE_SQL.format(marks="?,?"), (1, 2)),
|
|
"sweep": (SWEEP_SQL, ()),
|
|
"documents of images": (IMAGE_DOCUMENTS_SQL + "id IN (?,?)", (1, 2)),
|
|
"documents of prompts": (IMAGE_DOCUMENTS_SQL + "prompt_id IN (?,?)", (1, 2)),
|
|
}
|
|
|
|
|
|
class DocumentMismatch(Exception):
|
|
"""A document would not give back exactly the text it was made from."""
|
|
|
|
|
|
def _compact(sql: str) -> str:
|
|
return re.sub(r"\s+", "", sql or "").lower()
|
|
|
|
|
|
# ── schema ────────────────────────────────────────────────────────────
|
|
|
|
|
|
def _reference_columns(conn: sqlite3.Connection) -> Dict[str, tuple]:
|
|
return {
|
|
row[1]: tuple(row)
|
|
for row in conn.execute("PRAGMA table_info(generated_images)")
|
|
if row[1] in DOCUMENT_ID_COLUMNS
|
|
}
|
|
|
|
|
|
def _reference_error(conn: sqlite3.Connection, columns: Dict[str, tuple]):
|
|
for name, info in columns.items():
|
|
# (cid, name, type, notnull, default, pk)
|
|
if (str(info[2]).upper(), info[3], info[4], info[5]) != ("INTEGER", 0, None, 0):
|
|
return "Workflow document references have an invalid column"
|
|
keys = {
|
|
(row[3], row[2], row[4])
|
|
for row in conn.execute("PRAGMA foreign_key_list(generated_images)")
|
|
if row[3] in DOCUMENT_ID_COLUMNS
|
|
}
|
|
if keys != {(name, TABLE, "id") for name in DOCUMENT_ID_COLUMNS}:
|
|
return "Workflow document references have invalid foreign keys"
|
|
for column, index in INDEXES.items():
|
|
info = conn.execute(f'PRAGMA index_info("{index}")').fetchall()
|
|
owner = conn.execute(
|
|
"SELECT tbl_name FROM sqlite_master WHERE type='index' AND name=?",
|
|
(index,),
|
|
).fetchone()
|
|
if [row[2] for row in info] != [column] or not owner:
|
|
return "Workflow document references are missing their index"
|
|
if owner[0] != "generated_images":
|
|
return "Workflow document references are missing their index"
|
|
return None
|
|
|
|
|
|
def _value_error(conn: sqlite3.Connection):
|
|
if conn.execute(
|
|
"SELECT 1 FROM workflow_documents WHERE typeof(sha256)!='blob' "
|
|
"OR length(sha256)!=32 OR typeof(byte_length)!='integer' OR byte_length<0 "
|
|
"OR byte_length>? OR typeof(data)!='blob' LIMIT 1",
|
|
(MAX_DOCUMENT_BYTES,),
|
|
).fetchone():
|
|
return "Workflow documents contain invalid values"
|
|
for column in DOCUMENT_ID_COLUMNS:
|
|
# typeof() reads no overflow page; a dangling id is a rowid probe.
|
|
# ``column`` is one of DOCUMENT_ID_COLUMNS, never caller data.
|
|
sql = (
|
|
f"SELECT 1 FROM generated_images g WHERE typeof(g.{column}) " # nosec B608
|
|
f"NOT IN ('null','integer') OR (g.{column} IS NOT NULL AND NOT EXISTS "
|
|
f"(SELECT 1 FROM workflow_documents d WHERE d.id=g.{column})) LIMIT 1"
|
|
)
|
|
if conn.execute(sql).fetchone():
|
|
return "Workflow document references point at missing documents"
|
|
return None
|
|
|
|
|
|
def damaged_message(document_id: int) -> str:
|
|
"""The verify reason for a damaged document: which one, and what to do."""
|
|
return (
|
|
f"Workflow document {document_id} is damaged: its text no longer matches "
|
|
"its checksum, and the images that use it show no workflow. To fix it, "
|
|
"restore a backup from before the damage, or store a new image with the "
|
|
"same workflow (that repairs it)."
|
|
)
|
|
|
|
|
|
def _damaged_document(conn: sqlite3.Connection) -> Optional[int]:
|
|
"""The first document failing its length or hash check, or None."""
|
|
for row in conn.execute(ALL_DOCUMENTS_SQL):
|
|
if _decode(row[:3], row[3], quiet=True) is None:
|
|
return row[3]
|
|
return None
|
|
|
|
|
|
def workflow_documents_schema_error(
|
|
conn: sqlite3.Connection, *, allow_missing: bool = True, documents: bool = False
|
|
) -> Optional[str]:
|
|
"""Reject an unsupported document schema or invalid stored values (reads only).
|
|
|
|
A database from before the dedupe has neither the table nor the id
|
|
columns; that is acceptable unless ``allow_missing`` is false. Half of
|
|
the schema never is.
|
|
"""
|
|
objects = conn.execute(
|
|
"SELECT type,name,sql FROM sqlite_master WHERE name=? "
|
|
"OR (type IN ('index','trigger') AND tbl_name=?)",
|
|
(TABLE, TABLE),
|
|
).fetchall()
|
|
has_images = conn.execute(
|
|
"SELECT 1 FROM sqlite_master WHERE type='table' AND name='generated_images'"
|
|
).fetchone()
|
|
columns = _reference_columns(conn) if has_images else {}
|
|
if not objects and not columns:
|
|
if allow_missing or not has_images:
|
|
return None
|
|
return "Missing workflow document schema"
|
|
if not objects or set(columns) != set(DOCUMENT_ID_COLUMNS):
|
|
return "Incomplete workflow document schema"
|
|
tables = [sql for kind, _name, sql in objects if kind == "table"]
|
|
others = {(kind, name, sql) for kind, name, sql in objects if kind != "table"}
|
|
if len(tables) != 1 or others != {("index", _AUTOINDEX, None)}:
|
|
return "Workflow documents name is reserved by an unsupported schema object"
|
|
# The exact definition fixes the columns, their types and constraints.
|
|
if _compact(tables[0]) != _compact(_DDL):
|
|
return "Workflow documents have an invalid table definition"
|
|
error = _reference_error(conn, columns) or _value_error(conn)
|
|
if error is None and documents:
|
|
# Restore and backup verification only: every document is read.
|
|
damaged = _damaged_document(conn)
|
|
if damaged is not None:
|
|
return damaged_message(damaged)
|
|
return error
|
|
|
|
|
|
def migrate_workflow_documents(conn: sqlite3.Connection) -> None:
|
|
"""Install the table, the id columns and their indexes atomically.
|
|
|
|
Runs after every older migration (the table rebuilds only run on
|
|
databases without ``file_path``, before this). Validates before and
|
|
after, then sweeps documents no row references.
|
|
"""
|
|
conn.execute("SAVEPOINT workflow_documents_schema")
|
|
try:
|
|
error = workflow_documents_schema_error(conn)
|
|
if error:
|
|
raise sqlite3.DatabaseError(error)
|
|
conn.execute(_DDL.replace("CREATE TABLE", "CREATE TABLE IF NOT EXISTS", 1))
|
|
present = _reference_columns(conn)
|
|
for column in DOCUMENT_ID_COLUMNS:
|
|
if column not in present:
|
|
conn.execute(
|
|
f"ALTER TABLE generated_images ADD COLUMN {column} "
|
|
f"{_REFERENCE_TYPE}"
|
|
)
|
|
for column, index in INDEXES.items():
|
|
conn.execute(
|
|
f"CREATE INDEX IF NOT EXISTS {index} ON generated_images({column})"
|
|
)
|
|
error = workflow_documents_schema_error(conn, allow_missing=False)
|
|
if error:
|
|
raise sqlite3.DatabaseError(error)
|
|
sweep_documents(conn)
|
|
conn.execute("RELEASE workflow_documents_schema")
|
|
except BaseException:
|
|
conn.execute("ROLLBACK TO workflow_documents_schema")
|
|
conn.execute("RELEASE workflow_documents_schema")
|
|
raise
|
|
|
|
|
|
# ── write ─────────────────────────────────────────────────────────────
|
|
|
|
|
|
def storable(text: Any) -> bool:
|
|
"""Whether ``text`` can be a document (text within MAX_DOCUMENT_BYTES)."""
|
|
if not isinstance(text, str):
|
|
return False
|
|
# UTF-8 takes at most 4 bytes a character: most texts need no encoding.
|
|
if len(text) * 4 <= MAX_DOCUMENT_BYTES:
|
|
return True
|
|
return len(text.encode("utf-8")) <= MAX_DOCUMENT_BYTES
|
|
|
|
|
|
def store_text(
|
|
conn: sqlite3.Connection, text: Optional[str], verified: Optional[set] = None
|
|
) -> Optional[int]:
|
|
"""The id of the document holding exactly ``text``; None for None.
|
|
|
|
Reuses the document with the same hash, or inserts a new one whose
|
|
compressed bytes were checked to decompress to ``text``'s bytes. A reused
|
|
document is decompressed and checked first; a damaged one (a restored
|
|
file's corruption under a valid hash) is repaired from ``text``, whose
|
|
hash is its key, so every row that references it reads right again.
|
|
``verified``, when given, holds the ids already checked (a migration
|
|
batch), which are then not read again. Opens a write transaction first
|
|
when none is open, so a concurrent ``release_documents`` cannot remove a
|
|
reused document before the caller references it. Raises TypeError for a
|
|
non-text value and ValueError for a text over MAX_DOCUMENT_BYTES.
|
|
"""
|
|
if text is None:
|
|
return None
|
|
if not isinstance(text, str):
|
|
raise TypeError("Only text is stored as a workflow document")
|
|
raw = text.encode("utf-8")
|
|
if len(raw) > MAX_DOCUMENT_BYTES:
|
|
raise ValueError("Text is too large for a workflow document")
|
|
digest = hashlib.sha256(raw).digest()
|
|
if not conn.in_transaction:
|
|
conn.execute("BEGIN IMMEDIATE")
|
|
row = conn.execute(LOOKUP_SQL, (digest,)).fetchone()
|
|
if row is not None and verified is not None and row[0] in verified:
|
|
return row[0]
|
|
data = zlib.compress(raw, COMPRESSION_LEVEL)
|
|
if zlib.decompress(data) != raw: # pragma: no cover - zlib is exact
|
|
raise DocumentMismatch("Compression did not round-trip")
|
|
if row is None:
|
|
document_id = conn.execute(INSERT_SQL, (digest, len(raw), data)).lastrowid
|
|
else:
|
|
document_id = row[0]
|
|
if _decode(row[1:], document_id, quiet=True) != text:
|
|
logger.warning(f"Workflow document {document_id} was damaged; repaired")
|
|
conn.execute(REPAIR_SQL, (len(raw), data, document_id))
|
|
if verified is not None:
|
|
verified.add(document_id)
|
|
return document_id
|
|
|
|
|
|
def stored_values(
|
|
conn: sqlite3.Connection, texts: Dict[str, Optional[str]]
|
|
) -> Dict[str, Any]:
|
|
"""New-form column values for ``{text column: text}`` (writers).
|
|
|
|
Each text becomes ``{column: None, id column: document id}``; None
|
|
stays ``{column: None, id column: None}``; a value that cannot be a
|
|
document (not text, or too large) stays inline with no id.
|
|
"""
|
|
references = dict(TEXT_COLUMNS)
|
|
values: Dict[str, Any] = {}
|
|
for column, text in texts.items():
|
|
reference = references[column]
|
|
if text is None or not storable(text):
|
|
values[column], values[reference] = text, None
|
|
else:
|
|
values[column], values[reference] = None, store_text(conn, text)
|
|
return values
|
|
|
|
|
|
# ── read ──────────────────────────────────────────────────────────────
|
|
|
|
|
|
def _decode(row, document_id, quiet=False) -> Optional[str]:
|
|
"""``(sha256, byte_length, data)`` as checked text, or None (logged)."""
|
|
if row is None:
|
|
logger.warning(f"Workflow document {document_id} is missing")
|
|
return None
|
|
digest, length, data = bytes(row[0]), row[1], row[2]
|
|
try:
|
|
if not isinstance(length, int) or not 0 <= length <= MAX_DOCUMENT_BYTES:
|
|
raise ValueError("invalid length")
|
|
inflater = zlib.decompressobj()
|
|
raw = inflater.decompress(bytes(data), length + 1)
|
|
if len(raw) != length or inflater.unconsumed_tail or not inflater.eof:
|
|
raise ValueError("length differs")
|
|
if hashlib.sha256(raw).digest() != digest:
|
|
raise ValueError("hash differs")
|
|
return raw.decode("utf-8")
|
|
except (zlib.error, ValueError, TypeError) as error:
|
|
if not quiet:
|
|
logger.warning(f"Workflow document {document_id} is unreadable: {error}")
|
|
return None
|
|
|
|
|
|
def read_stored_text(
|
|
conn: sqlite3.Connection, inline: Any, document_id: Optional[int]
|
|
) -> Any:
|
|
"""The stored text of one column: inline when present, else the document.
|
|
|
|
Returns None when there is neither, or when the document is missing or
|
|
fails its checks (logged). An inline value is returned unchanged.
|
|
"""
|
|
if inline is not None:
|
|
return inline
|
|
if document_id is None:
|
|
return None
|
|
return _decode(conn.execute(READ_SQL, (document_id,)).fetchone(), document_id)
|
|
|
|
|
|
class DocumentReader:
|
|
"""``read_stored_text`` with a small memo for list reads on one connection."""
|
|
|
|
MEMO = 32
|
|
|
|
def __init__(self, conn: sqlite3.Connection):
|
|
self.conn = conn
|
|
self._memo: "OrderedDict[int, Optional[str]]" = OrderedDict()
|
|
|
|
def text(self, inline: Any, document_id: Optional[int]) -> Any:
|
|
if inline is not None or document_id is None:
|
|
return read_stored_text(self.conn, inline, document_id)
|
|
if document_id in self._memo:
|
|
self._memo.move_to_end(document_id)
|
|
return self._memo[document_id]
|
|
text = read_stored_text(self.conn, None, document_id)
|
|
self._memo[document_id] = text
|
|
if len(self._memo) > self.MEMO:
|
|
self._memo.popitem(last=False)
|
|
return text
|
|
|
|
|
|
def resolve_image_row(reader: DocumentReader, row) -> Dict[str, Any]:
|
|
"""A ``generated_images`` row as a dict with its texts read back.
|
|
|
|
The id columns are dropped, so a payload built from it has the shape it
|
|
had before the dedupe. Columns the row did not select stay absent.
|
|
"""
|
|
data = dict(row)
|
|
for column, reference in TEXT_COLUMNS:
|
|
has_reference = reference in data
|
|
document_id = data.pop(reference, None)
|
|
if column in data or has_reference:
|
|
data[column] = reader.text(data.get(column), document_id)
|
|
return data
|
|
|
|
|
|
# ── garbage ───────────────────────────────────────────────────────────
|
|
|
|
|
|
def _chunks(values):
|
|
values = list(values)
|
|
for start in range(0, len(values), ID_BATCH):
|
|
yield values[start : start + ID_BATCH]
|
|
|
|
|
|
def image_documents(conn: sqlite3.Connection, where: str, params) -> Set[int]:
|
|
"""The document ids the image rows matching ``where`` reference.
|
|
|
|
``where`` is a fixed condition written in this package (``id IN (...)``,
|
|
``prompt_id IN (...)``), never caller data; values go in ``params``.
|
|
"""
|
|
ids: Set[int] = set()
|
|
sql = IMAGE_DOCUMENTS_SQL + where
|
|
for row in conn.execute(sql, list(params)): # nosec B608
|
|
ids.update(value for value in row if value is not None)
|
|
return ids
|
|
|
|
|
|
def documents_of_rows(
|
|
conn: sqlite3.Connection, column: str, values: Iterable[Any]
|
|
) -> Set[int]:
|
|
"""Document ids of the image rows whose ``column`` is in ``values``.
|
|
|
|
``column`` is ``id`` or ``prompt_id`` (the rows a prompt delete cascades to).
|
|
"""
|
|
if column not in ("id", "prompt_id"):
|
|
raise ValueError(f"Unsupported column {column!r}")
|
|
ids: Set[int] = set()
|
|
for chunk in _chunks(values):
|
|
marks = ",".join("?" for _ in chunk)
|
|
ids |= image_documents(conn, f"{column} IN ({marks})", chunk)
|
|
return ids
|
|
|
|
|
|
def release_documents(conn: sqlite3.Connection, ids: Iterable[Optional[int]]) -> int:
|
|
"""Delete the documents in ``ids`` that no image row references now.
|
|
|
|
Runs in the caller's transaction, right after the delete or update that
|
|
dropped the references. Returns how many documents were removed.
|
|
"""
|
|
removed = 0
|
|
for chunk in _chunks(sorted({i for i in ids if i is not None})):
|
|
marks = ",".join("?" for _ in chunk)
|
|
# Only "?" marks are interpolated.
|
|
sql = RELEASE_SQL.format(marks=marks)
|
|
removed += conn.execute(sql, chunk).rowcount # nosec B608
|
|
return removed
|
|
|
|
|
|
def sweep_documents(conn: sqlite3.Connection) -> int:
|
|
"""Delete every document no image row references; returns the count."""
|
|
return conn.execute(SWEEP_SQL).rowcount
|