Vito
8a81114dfc
* perf(images): read PNG text without decoding pixels (#523) Pillow's PngImageFile.text loads every pixel to reach text chunks written after IDAT. The scan's metadata batch and the image monitor now read PNG text through utils/png_text.py, which runs Pillow's own chunk handlers after the first IDAT and seeks over the pixel data. The legacy .text read is the floor: a differential test compares both readers on every fixture image, a curated corpus and a seeded fuzz. The only difference is a file whose pixel data is undecodable or cut short: it now keeps the text read before its pixels instead of reading nothing. Animated PNGs still use .text. * test(images): cover the text budget, XMP and layout guard of the PNG text walk (#523) * perf(images): run image work on two own pools and trim after jobs (#523) Image work no longer spreads over the default executor's threads, where glibc kept an image-sized malloc arena per thread. - Interactive image work (view previews behind their gate, workspace card facts, both inspector routes) runs on the API's fixed pm-image pool of 3 threads; the on-demand preview pool is merged into it. - map_parallel (scan metadata, thumbnail and convert jobs, the legacy gallery generation, capture previews) shares one long-lived pm-worker pool of Worker threads, reused between jobs. The package teardown stops it within its bound (part "workers"). - After a scan, thumbnail or convert job, glibc's malloc_trim(0) returns free pages once; a no-op on Windows, macOS and musl. - tools/perf/memory_drive.py measures RSS, heap, threads and arenas under the #523 load on the disposable browser test server (manual only). * fix(images): start no image thread after the teardown; join retired job pools (#523)
83 lines
3.2 KiB
Python
83 lines
3.2 KiB
Python
"""``release_free_memory``: glibc's malloc_trim(0), a no-op elsewhere (#523)."""
|
|
|
|
import sys
|
|
import unittest
|
|
from unittest import mock
|
|
|
|
from utils import native_memory
|
|
|
|
|
|
class ReleaseFreeMemoryTests(unittest.TestCase):
|
|
def setUp(self):
|
|
# Each test looks the symbol up again.
|
|
patcher = mock.patch.multiple(native_memory, _trim=None, _looked_up=False)
|
|
patcher.start()
|
|
self.addCleanup(patcher.stop)
|
|
|
|
@unittest.skipUnless(native_memory._glibc(), "glibc only")
|
|
def test_glibc_trims_once_per_call(self):
|
|
self.assertTrue(native_memory.release_free_memory())
|
|
self.assertTrue(native_memory.release_free_memory())
|
|
|
|
def test_other_platforms_do_nothing(self):
|
|
for platform in ("win32", "darwin", "cygwin"):
|
|
with self.subTest(platform), mock.patch.object(sys, "platform", platform):
|
|
native_memory._looked_up = False
|
|
with mock.patch.object(native_memory.ctypes, "CDLL") as cdll:
|
|
self.assertFalse(native_memory.release_free_memory())
|
|
cdll.assert_not_called()
|
|
|
|
def test_musl_does_nothing(self):
|
|
with (
|
|
mock.patch.object(sys, "platform", "linux"),
|
|
mock.patch.object(
|
|
native_memory.os, "confstr", side_effect=ValueError("unknown name")
|
|
),
|
|
mock.patch.object(native_memory.ctypes, "CDLL") as cdll,
|
|
):
|
|
self.assertFalse(native_memory.release_free_memory())
|
|
cdll.assert_not_called()
|
|
|
|
def test_a_missing_symbol_is_false(self):
|
|
library = mock.Mock(spec=[]) # no malloc_trim attribute
|
|
with (
|
|
mock.patch.object(native_memory, "_glibc", return_value=True),
|
|
mock.patch.object(native_memory.ctypes, "CDLL", return_value=library),
|
|
):
|
|
self.assertFalse(native_memory.release_free_memory())
|
|
|
|
def test_an_unloadable_libc_is_false(self):
|
|
with (
|
|
mock.patch.object(native_memory, "_glibc", return_value=True),
|
|
mock.patch.object(native_memory.ctypes, "CDLL", side_effect=OSError),
|
|
):
|
|
self.assertFalse(native_memory.release_free_memory())
|
|
|
|
def test_a_failing_trim_never_raises(self):
|
|
trim = mock.Mock(side_effect=OSError("boom"))
|
|
library = mock.Mock(malloc_trim=trim)
|
|
with (
|
|
mock.patch.object(native_memory, "_glibc", return_value=True),
|
|
mock.patch.object(native_memory.ctypes, "CDLL", return_value=library),
|
|
):
|
|
self.assertFalse(native_memory.release_free_memory())
|
|
trim.assert_called_once_with(0)
|
|
|
|
def test_the_symbol_is_looked_up_once(self):
|
|
trim = mock.Mock(return_value=1)
|
|
library = mock.Mock(malloc_trim=trim)
|
|
with (
|
|
mock.patch.object(native_memory, "_glibc", return_value=True),
|
|
mock.patch.object(
|
|
native_memory.ctypes, "CDLL", return_value=library
|
|
) as cdll,
|
|
):
|
|
self.assertTrue(native_memory.release_free_memory())
|
|
self.assertTrue(native_memory.release_free_memory())
|
|
cdll.assert_called_once_with(None)
|
|
self.assertEqual(trim.call_count, 2)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|