* test(browser): one test server per Playwright worker The page workflows started one global webServer and ran with one worker. Each worker now owns its own tests/browser/server.py on an OS-chosen port, with its own temp root and database, through a shared `test` in tests/browser/fixtures.mjs. baseURL, and so page, request and browser.newContext, point at that worker's server. A server that dies fails the running test with its stderr tail and the next test gets a fresh one. The worker count comes from PM_TEST_WORKERS, else 1 under CI, else a quarter of the CPUs up to 8. Chromium workflows in the pinned image: 510 tests in 606 s with one worker on main, 511 (one new isolation spec) in 119 s with eight. * test(browser): test servers bind an OS-chosen port themselves tests/browser/server.py accepts --port 0: it binds 127.0.0.1:0 before building the app, holds that socket for its whole life and prints PM_TEST_SERVER_PORT=<n> to stdout. startBrowserServer defaults to port 0 and reads the announced port, so no port is reserved and released before the server binds and two launchers can no longer race for one. The "address already in use" retry and free-port.mjs are gone; --port N still works and is checked against the announcement. * ci(coverage): shard and merge modes for the frontend coverage run frontend-coverage.mjs now plans its steps from the command line. No arguments still runs everything, then reports and checks. --shard I/N runs one slice of the chromium+touch workflows into coverage/js/raw without wiping it or reporting; shard 1 also runs the node units and the viewer suite. --merge-only reports and checks over raw coverage the shards wrote, with --update-baseline as before, and refuses an empty or missing raw dir. npm scripts: test:coverage:shard and coverage:merge. * ci(viewerjs): run browser suites with workers and shards Frontend coverage runs as three shards (PM_TEST_WORKERS=3 each) that upload their raw V8 files as coverage-raw-N; a merge job downloads them, fails unless all three arrived with raw files and no clashing names, then runs coverage:merge. Firefox and WebKit page workflows run as two shards each with three workers. The required viewerjs context keeps its name and now needs the shards, the merge and the browser shards, failing unless every one succeeded. * ci(viewerjs): cache npm downloads and size timeouts from the first sharded run The first sharded run lost a webkit shard to its 12-minute limit after all 267 tests passed, and npm ci stalled for 5 minutes in six of eight jobs. Each npm ci now restores npm's download cache keyed on the vendor lockfile, and browser job timeouts are the measured times plus at least 50%, never under 20 minutes. The workflow comment records the measurements. * test(browser): wait for rendering frames, not timers or luck, under load Two Library workflows failed in CI's webkit shard 2/2 (run 39714840809) under parallel load: - "library infinite loading ..." counted cards right after the last page hid "Load more". That render queues the window update for the next frame, so a slow frame left the 120 cards of the all-rows layout in place (received 120, expected < 80). It now waits for the next frame, which runs after every callback the page queued. - "row measurement preserves anchor ..." settled with a 60 ms timer. A scroll event is delivered in a rendering frame, so on a starved renderer the timer ended before the scroll's frame and no card was in view (null anchor). settleLibrary now waits for two consecutive native frames with no Library frame queued, checked inside the frame callback. Before/after: a scratch copy that delays every frame by 120 ms (as a starved runner) failed the old helpers 19 of 40 runs, at the CI lines, and passed the new ones 40 of 40 on chromium and webkit. Throttled to 1 CPU with 4 workers, the original spec failed 1 of 42 for each test. The Tags viewer workflow closed the viewer as soon as its image was visible, before ViewerJS rendered the title, so CI's coverage never ran the page's title callback (tags-page.js functions 26/46 = 56.52%, one function above the floor of 56; locally 27/46). The test now asserts the title names the shown file, which always runs the callback. * test(browser): stable under parallel workers Document how to run the browser suites in parallel and sharded, with the measured times, and what keeps specs stable beside each other: wait for a rendering frame, a response or a visible state, never for time. Withb665aa6the full workflows suite passed on chromium, touch, firefox and webkit with 8 workers, each test 3 times (6132 passed, 0 failed, 24 minutes), and once at CI size (docker --cpus=4, 3 workers: 2044 passed, 25.5 minutes). The npm download cache removed the npm ci stall: 0 to 2 s in every job of run 39722172529, against about 300 s in most jobs before. The workflow's timing comment now records that run; the whole workflow took 8m54s against about 33 minutes before sharding. Shard imbalance (shard 1 carries the concept-comparison specs) is documented, not tuned. * test(browser): server stderr on failures, no orphan servers, waits on state Final review fixes for the per-worker test servers (#274): - A failed test gets the stderr its server wrote during that test attached as `server-stderr`, so an aiohttp traceback behind a 500 reaches the CI report. The launcher keeps the newest 256 KB with a stream position per test (stderrMark/stderrSince), and the fixture attaches it only when the test did not end as expected. - The port announcement counts only as a complete line; a chunk ending mid-number was read as a shorter port. - server.py --exit-on-stdin-eof shuts down gracefully (database closed, temp root removed) when stdin closes. The launcher holds that pipe, so a SIGKILLed worker leaves no server behind, on every OS. - settled() gives up after 600 frames with the observation stats instead of hanging to the test timeout. - The Classic text-sync test waits for the page's 50 ms timer to install serializeValue instead of sleeping 60 ms. With that timer run 100 ms late (a scratch copy), the old wait failed 20/20 and the poll passed 20/20; the spec passed 240/240 at 8 workers x10 and 240/240 at 1 CPU with 4 workers. - The workflow test checks each npm cache key names its job's pinned image tag. Every new unit test failed before its change (missing export, the old regex timing out on the split announcement, an unknown server flag, a hung settle, a mismatched cache key). * docs(testing): server lifetime, stderr attachments and the final measured CI times TESTING.md describes the stdin-EOF shutdown and the server-stderr attachment, states that the npm cache key names the job's image tag (now tested), quotes run 39725176320 atcbc8a61(8m38s) and explains the 20-minute browser job limit. The workflow timing comment quotes the same run. * fix(browser): server shutdown and its tests on Windows, Python < 3.13 and CI Three CI failures oned809f7: - Windows: server.py exited 1 on stdin EOF because create_app works with the temp root as its cwd, and Windows cannot remove a process's cwd. main() now restores the original cwd before the root is removed. - Python 3.10 to 3.12: the lifetime test's cleanup called communicate() after closing stdin, which flushes the closed pipe (ValueError); 3.13 tolerates it. It now waits and closes the pipes itself, and the exit assertion shows the server's stderr. Under 3.12: errors=2 before, OK after. - Tooling (CI container): the SIGKILLed-worker tests treated an exited server as alive, because the container's PID 1 does not reap orphans and kill(pid, 0) succeeds on a zombie. Reproduced locally with docker without --init (2 failed); a zombie now counts as exited (2 passed).
235 lines
12 KiB
JavaScript
235 lines
12 KiB
JavaScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { createServer } from 'node:net';
|
|
import { spawn } from 'node:child_process';
|
|
import { once } from 'node:events';
|
|
import { readFileSync } from 'node:fs';
|
|
import { fileURLToPath, pathToFileURL } from 'node:url';
|
|
import { setTimeout as delay } from 'node:timers/promises';
|
|
import { startBrowserServer, createServerSupervisor, attachServerStderr } from '../../tools/vendor/start-browser-server.mjs';
|
|
import { workflowWorkers } from '../../tools/vendor/test-workers.mjs';
|
|
|
|
const fakeServer = fileURLToPath(new URL('./fake-browser-server.mjs', import.meta.url));
|
|
const fake = (...extra) => ({ command: process.execPath, args: port => [fakeServer, '--port', String(port), ...extra] });
|
|
const REAL_SERVER_TIMEOUT_MS = 90_000;
|
|
const launcher = fileURLToPath(new URL('../../tools/vendor/start-browser-server.mjs', import.meta.url));
|
|
|
|
/** Polls `check` until it is truthy, failing with `what` after `ms`. */
|
|
async function waitFor(check, what, ms = 5_000) {
|
|
const deadline = Date.now() + ms;
|
|
while (!check()) {
|
|
if (Date.now() > deadline) throw new Error(`timed out waiting for ${what}`);
|
|
await delay(20);
|
|
}
|
|
}
|
|
|
|
async function writeStderr(server, text) {
|
|
await (await fetch(`${server.url}/__stderr?text=${encodeURIComponent(text)}`)).text();
|
|
await waitFor(() => server.stderrTail().endsWith(text.trimEnd()), `stderr ${JSON.stringify(text)}`);
|
|
}
|
|
|
|
/** A process that exited counts as gone even while a non-reaping PID 1 (CI's container) leaves it a zombie. */
|
|
function alive(pid) {
|
|
try { process.kill(pid, 0); } catch { return false; }
|
|
try { return readFileSync(`/proc/${pid}/stat`, 'utf8').replace(/^.*\) /s, '')[0] !== 'Z'; } catch { return true; }
|
|
}
|
|
|
|
/** Starts a server from a separate Node worker process, SIGKILLs that worker and returns the server's pid. */
|
|
async function serverOfKilledWorker(options) {
|
|
const script = `import { startBrowserServer } from ${JSON.stringify(pathToFileURL(launcher).href)};
|
|
const server = await startBrowserServer(${options});
|
|
console.log('SERVER_PID=' + server.pid);
|
|
setInterval(() => {}, 1000);`;
|
|
const worker = spawn(process.execPath, ['--input-type=module', '-e', script], { stdio: ['ignore', 'pipe', 'inherit'] });
|
|
let out = '';
|
|
worker.stdout.setEncoding('utf8');
|
|
worker.stdout.on('data', chunk => { out += chunk; });
|
|
await waitFor(() => /SERVER_PID=\d+\n/.test(out) || worker.exitCode !== null, 'the worker to start its server', REAL_SERVER_TIMEOUT_MS);
|
|
const pid = Number(/SERVER_PID=(\d+)/.exec(out)?.[1]);
|
|
assert.ok(pid > 0, `the worker started a server (output: ${out})`);
|
|
assert.ok(alive(pid), 'the server runs while its worker lives');
|
|
worker.kill('SIGKILL');
|
|
await once(worker, 'exit');
|
|
return pid;
|
|
}
|
|
|
|
function listen(port = 0) {
|
|
return new Promise((resolve, reject) => {
|
|
const server = createServer();
|
|
server.once('error', reject);
|
|
server.listen(port, '127.0.0.1', () => resolve(server));
|
|
});
|
|
}
|
|
|
|
async function releasedPort() {
|
|
const probe = await listen();
|
|
const { port } = probe.address();
|
|
await new Promise(resolve => probe.close(resolve));
|
|
return port;
|
|
}
|
|
|
|
test('free port allocation never reuses a bound port', async t => {
|
|
const held = await listen();
|
|
t.after(() => held.close());
|
|
const heldPort = held.address().port;
|
|
const servers = await Promise.all(Array.from({ length: 6 }, () => startBrowserServer(fake())));
|
|
t.after(() => Promise.all(servers.map(server => server.stop())));
|
|
const ports = servers.map(server => server.port);
|
|
for (const server of servers) {
|
|
assert.ok(Number.isInteger(server.port) && server.port > 0 && server.port < 65536, `port ${server.port} is a TCP port`);
|
|
assert.equal(server.url, `http://127.0.0.1:${server.port}`);
|
|
assert.equal(await (await fetch(`${server.url}/prompt_manager/test`)).text(), 'ready');
|
|
}
|
|
assert.ok(!ports.includes(heldPort), 'a port another process holds is never handed out');
|
|
assert.equal(new Set(ports).size, ports.length, 'concurrent servers never share a port');
|
|
});
|
|
|
|
test('startBrowserServer asks the server to bind port 0 and reads the port it announces', async () => {
|
|
const asked = [];
|
|
const server = await startBrowserServer({ command: process.execPath, args: port => { asked.push(port); return fake().args(port); } });
|
|
try {
|
|
assert.deepEqual(asked, [0], 'no port is reserved and released before the server binds');
|
|
assert.ok(server.port > 0);
|
|
} finally {
|
|
await server.stop();
|
|
}
|
|
});
|
|
|
|
test('startBrowserServer serves the readiness page on a requested port and stops cleanly', async () => {
|
|
const port = await releasedPort();
|
|
const server = await startBrowserServer({ port, ...fake() });
|
|
assert.equal(server.port, port);
|
|
assert.equal(server.url, `http://127.0.0.1:${port}`);
|
|
assert.equal(await (await fetch(`${server.url}/prompt_manager/test`)).text(), 'ready');
|
|
await server.stop();
|
|
await assert.rejects(fetch(`${server.url}/prompt_manager/test`));
|
|
});
|
|
|
|
test('startBrowserServer reports a startup failure with the server\'s stderr tail', async () => {
|
|
await assert.rejects(startBrowserServer(fake('--fail')), error => {
|
|
assert.match(error.message, /exited with code 4 before it was ready/);
|
|
assert.match(error.message, /last fake stderr line/);
|
|
return true;
|
|
});
|
|
});
|
|
|
|
test('startBrowserServer gives up on a server that never announces a port or becomes ready', async () => {
|
|
const silent = { command: process.execPath, args: () => ['-e', 'setInterval(() => {}, 1000)'] };
|
|
await assert.rejects(startBrowserServer({ ...silent, timeoutMs: 500 }), /not ready .* within 500 ms/);
|
|
});
|
|
|
|
test('worker server restarts after an unexpected exit', async t => {
|
|
const supervisor = createServerSupervisor({ start: () => startBrowserServer(fake()) });
|
|
t.after(() => supervisor.stop());
|
|
const first = await supervisor.ensure();
|
|
assert.equal(supervisor.crash(first), null, 'a running server reports no crash');
|
|
await fetch(`${first.url}/__exit`);
|
|
await first.exited;
|
|
const crash = supervisor.crash(first);
|
|
assert.match(crash.message, /test server on port \d+ exited unexpectedly \(code 3\)/);
|
|
assert.match(crash.message, /crashed on purpose/);
|
|
const second = await supervisor.ensure();
|
|
assert.notEqual(second, first, 'the next test gets a fresh server');
|
|
assert.equal(await (await fetch(`${second.url}/prompt_manager/test`)).text(), 'ready');
|
|
assert.equal(await supervisor.ensure(), second, 'a healthy server is reused');
|
|
});
|
|
|
|
test('supervisor reports a startup failure once and tries again on the next ensure', async t => {
|
|
let attempts = 0;
|
|
const supervisor = createServerSupervisor({
|
|
start: async () => {
|
|
attempts += 1;
|
|
if (attempts === 1) throw new Error('ImportError: no module');
|
|
return startBrowserServer(fake());
|
|
},
|
|
});
|
|
t.after(() => supervisor.stop());
|
|
await assert.rejects(supervisor.ensure(), /ImportError/);
|
|
assert.equal(attempts, 1, 'a failed startup is not retried behind the caller\'s back');
|
|
const server = await supervisor.ensure();
|
|
assert.equal(attempts, 2);
|
|
assert.equal(await (await fetch(`${server.url}/prompt_manager/test`)).text(), 'ready');
|
|
});
|
|
|
|
test('the port announcement counts only once its line is complete', async t => {
|
|
const server = await startBrowserServer({ ...fake('--split-announce'), timeoutMs: 5_000 });
|
|
t.after(() => server.stop());
|
|
assert.equal(await (await fetch(`${server.url}/prompt_manager/test`)).text(), 'ready');
|
|
assert.equal(server.url, `http://127.0.0.1:${server.port}`);
|
|
});
|
|
|
|
test('server stderr since a mark holds only what came after it, bounded to the newest output', async t => {
|
|
const server = await startBrowserServer({ ...fake(), stderrLogChars: 64 });
|
|
t.after(() => server.stop());
|
|
await writeStderr(server, 'earlier test\n');
|
|
const mark = server.stderrMark();
|
|
assert.equal(server.stderrSince(mark), '');
|
|
await writeStderr(server, 'Traceback: this test\n');
|
|
assert.equal(server.stderrSince(mark), 'Traceback: this test\n');
|
|
const flood = `${'x'.repeat(80)}newest\n`;
|
|
await writeStderr(server, flood);
|
|
const kept = server.stderrSince(mark);
|
|
assert.match(kept, /^\[earlier server stderr dropped\]\n/);
|
|
assert.ok(kept.endsWith('newest\n'), 'the newest output is kept');
|
|
assert.ok(kept.length <= 64 + '[earlier server stderr dropped]\n'.length, `bounded, got ${kept.length} chars`);
|
|
});
|
|
|
|
test('a failed test gets the server stderr written during it attached; a passing one does not', async t => {
|
|
const server = await startBrowserServer(fake());
|
|
t.after(() => server.stop());
|
|
const attached = [];
|
|
const info = status => ({ status, expectedStatus: 'passed', attach: async (name, options) => { attached.push({ name, ...options }); } });
|
|
await writeStderr(server, 'before the test\n');
|
|
const mark = server.stderrMark();
|
|
await attachServerStderr(info('failed'), server, mark);
|
|
assert.deepEqual(attached, [], 'nothing to attach when the server wrote nothing');
|
|
await writeStderr(server, 'Traceback (most recent call last): boom\n');
|
|
await attachServerStderr(info('passed'), server, mark);
|
|
assert.deepEqual(attached, [], 'a passing test attaches nothing');
|
|
await attachServerStderr(info('timedOut'), server, mark);
|
|
assert.equal(attached.length, 1);
|
|
assert.equal(attached[0].name, 'server-stderr');
|
|
assert.equal(attached[0].contentType, 'text/plain');
|
|
assert.equal(String(attached[0].body), 'Traceback (most recent call last): boom\n');
|
|
});
|
|
|
|
test('a server exits with its worker even when the worker is SIGKILLed', async () => {
|
|
const pid = await serverOfKilledWorker(`{ command: process.execPath, args: port => [${JSON.stringify(fakeServer)}, '--port', String(port), '--exit-on-stdin-eof'] }`);
|
|
await waitFor(() => !alive(pid), `server ${pid} to exit after its worker died`);
|
|
});
|
|
|
|
test('tests/browser/server.py exits with a SIGKILLed worker', { timeout: 2 * REAL_SERVER_TIMEOUT_MS }, async () => {
|
|
const pid = await serverOfKilledWorker(`{ timeoutMs: ${REAL_SERVER_TIMEOUT_MS} }`);
|
|
await waitFor(() => !alive(pid), `server.py ${pid} to exit after its worker died`, 15_000);
|
|
});
|
|
|
|
test('tests/browser/server.py binds an OS-chosen port for --port 0 and still honours --port N', { timeout: 2 * REAL_SERVER_TIMEOUT_MS }, async t => {
|
|
const held = await listen();
|
|
t.after(() => held.close());
|
|
const chosen = await startBrowserServer({ timeoutMs: REAL_SERVER_TIMEOUT_MS });
|
|
try {
|
|
assert.notEqual(chosen.port, held.address().port);
|
|
assert.equal((await fetch(`${chosen.url}/prompt_manager/test`)).status, 200);
|
|
} finally {
|
|
await chosen.stop();
|
|
}
|
|
const port = await releasedPort();
|
|
const fixed = await startBrowserServer({ port, timeoutMs: REAL_SERVER_TIMEOUT_MS });
|
|
try {
|
|
assert.equal(fixed.port, port);
|
|
assert.equal((await fetch(`http://127.0.0.1:${port}/prompt_manager/test`)).status, 200);
|
|
} finally {
|
|
await fixed.stop();
|
|
}
|
|
});
|
|
|
|
test('worker count follows PM_TEST_WORKERS, then one in CI, then a quarter of the CPUs up to eight', () => {
|
|
assert.equal(workflowWorkers({ env: { PM_TEST_WORKERS: '3', CI: '1' }, cpus: 32 }), 3);
|
|
assert.equal(workflowWorkers({ env: { CI: '1' }, cpus: 32 }), 1);
|
|
assert.equal(workflowWorkers({ env: {}, cpus: 32 }), 8);
|
|
assert.equal(workflowWorkers({ env: {}, cpus: 12 }), 3);
|
|
assert.equal(workflowWorkers({ env: {}, cpus: 2 }), 1);
|
|
assert.throws(() => workflowWorkers({ env: { PM_TEST_WORKERS: 'many' }, cpus: 8 }), /PM_TEST_WORKERS must be a positive integer/);
|
|
assert.throws(() => workflowWorkers({ env: { PM_TEST_WORKERS: '0' }, cpus: 8 }), /PM_TEST_WORKERS must be a positive integer/);
|
|
});
|