* perf(images): share and warm one listing per output root (#348)
The Images page, its sidebar counts, the subfolder list and the legacy
gallery each rebuilt the output listing when the 30 s cache expired, all
at once, and the subfolder list computed relative paths on the event
loop. Thumbnail writes also threw the listing away.
Keep one RootListing per output root (py/api/gallery_listing.py):
- one walk per root at a time; concurrent readers wait for it (shielded)
- a listing older than 30 s is served at once and refreshed in the
background
- the walk, the comparison with the previous listing and both folder
sets run in the executor; an unchanged walk keeps the same list object
- os.scandir probe: a missing root fails the walk and keeps the previous
listing (one warning per failure streak)
- Rescan waits for a walk started after the click and is a 500 when it
fails, even with a previous listing
- deletes keep the blocking invalidation; a generation counter that
survives drops discards walks that raced it
- thumbnail jobs, conversion and the legacy generate/clear routes no
longer drop the listing
- warm-up on the host's on_startup, cancelled on on_cleanup
Adds tools/vendor/perf/images_load_probe.mjs (maintainer tool, not CI)
and the TESTING.md section "Images listing cache (#348)".
* fix(images): drop listings on the loop when invalidated from a worker thread (#348)
A settings save (gallery roots change) and the browser-test seeds call
invalidate_gallery_cache() from the executor. Listing records are only
touched on the event loop, so an off-loop call now hands the drop to the
loop and waits for it, keeping the call synchronous for its callers.
The shared-Rescan test waits for the later Rescans to take their walk
number instead of sleeping.
* test(images): bound the shared-listing test waits (#348)
A macOS py3.12 run stopped inside the shared-listing tests and sat until
the 6 h job limit with no traceback. It does not reproduce locally (about
300 runs on 3.12 and 3.14, pinned to one core). Requests and background
settles in TestSharedListing now give up after 30 s, so a recurrence
fails with the stuck await instead of hanging the run.
* test(images): let the settle loops yield so a finished walk leaves the set (#348)
On CI (ubuntu and macOS py3.12) the runner's watchdog dumped
test_a_root_that_recovers_warns_again_on_its_next_failure spinning in
_settle: asyncio.gather over tasks that are already done returns without
yielding, so the set's discard callback, queued when the walk finished,
never ran and the loop never ended (wait_for could not fire either).
Delaying discard by one loop turn reproduces it locally; both settle
loops now yield one turn after each gather.
* test(browser): poll the import review's rows instead of reading them once
gridOf reads the dialog's rows once; right after the click the review may
not have rendered them yet (firefox CI: received undefined).
* perf(images): walk the output with scandir entries and build folders from strings (#348)
The live test showed a read during a background refresh taking 2.2 s instead
of 0.07 s: the walk held the GIL for about 2 s in the server. py-spy split
that walk into two halves: Path.relative_to per file in folder_sets, and
Path.stat + Path.is_symlink + Path joins per file in the scan.
- _walk_media visits folders in os.walk's order with os.scandir entries:
the file type comes from the listing (no lstat per file) and the mtime
from entry.stat (one call, none on Windows). _iter_media_files is now a
thin wrapper, so its other caller is unchanged.
- folder_sets slices the path strings (in the path flavour's separator)
instead of calling relative_to, falling back to it for a path that does
not start with the root string.
On the maintainer's 19,935-file output folder: scan 0.386 s -> 0.112 s,
folder sets 0.452 s -> 0.007 s, both results identical to the previous code.
A reference copy of the os.walk version checks order, filters, the depth
cap, symlinks and the file cap.
* perf(images): build the workspace caches behind the warm-up and changed walks (#348)
The live test after the faster walk still took 2.9-5.2 s for the first
Images open after a restart. py-spy showed the walk was now small; the time
went to the workspace's own caches, cold after a restart and built by three
parallel first requests at once: the favorites listing (Path.relative_to per
file), the per-file values and newest order, and the prompt-link read.
- Once the host's startup warm-up has run, a stored walk that changed a
listing schedules one executor job that builds what a first page reads,
through the request path itself (_select_workspace_page with the default
filters, then _workspace_favorite_paths). A walk stored during a build
asks for one more build; an unchanged walk (same list kept) builds
nothing; a failed build only warns; on_cleanup stops it. Servers that
never ran the warm-up (the test servers) start no build.
- _favorite_listing slices the path strings as _listed does, falling back
to relative_to for a path outside the root string.
* perf(images): start a stale listing's refresh walk a second after the read (#348)
After the faster walk, a read that found the listing stale still took
0.5-1.0 s against 0.07 s: it was served from the old listing but ran beside
the refresh walk it had just started, sharing the GIL. The refresh now starts
REFRESH_DELAY (1 s) after that read through a per-root rewalk_handle, so the
page's own requests finish first. One pending refresh per root and none while
a walk runs; any walk start (a cold read, Rescan, the warm-up) cancels a
pending one; on_cleanup cancels them before its first await.
* test(browser): accept KB or MB for the picked safety backup's size
The restore preview showed '2.5 MB' for the test server's database copy in a
CI coverage shard: its size depends on what earlier tests on that server
wrote, and the formatter switches to MB at 1 MiB.
* fix(images): keep the 3.10-3.13 suffix rule in the scandir walk and harden the warm-up (#348)
Review of the walk speedup:
- os.path.splitext drops names like ..png that Path.suffix listed on Python
3.10-3.13 (3.14 changed Path.suffix, which hid it from the parity test on
a 3.14 venv). _name_suffix spells out the 3.10-3.13 rule; the test now
asserts ..png and ...webp are listed and g. is not.
- _warm_workspace reads the roots inside its try, so a failing
_get_all_output_dirs warns instead of leaving an unretrieved task error.
- The folder_sets fallback test now takes the fallback (a Windows case
mismatch); the coalescing test pins the walk count.
Vito
9ac471eb72