Vito Sansevero
7b6b7ecf3d
web/js/api-client.js wraps fetch with one failure path (ApiError for non-2xx,
success:false and non-JSON bodies) and latestOnly(), which aborts the previous
in-flight request and resolves superseded calls to STALE. The admin search and
recent-page loads share one guard, the gallery page load has its own, so fast
typing or clicking can no longer paint an older result over a newer one.
In-place prompt editing used a blur listener with {once:true} plus a keydown
listener added on every edit, which sent the PUT twice and stacked handlers.
The list now has one keydown/focusout pair bound at construction and
finishEdit() clears the edit state before touching the element, so a save is
sent exactly once. Mutations re-fetch the page currently shown (refreshList)
instead of calling search(), and delete, bulk delete, edit, restore and scan no
longer reload the whole page.
Pagination state is committed only after a successful fetch via the pure
ListState.nextPageState(current, response) in both admin and gallery, so a
failed or aborted page request leaves the current page intact. The gallery
lightbox removed its keydown handlers on a non-existent 'remove' event; a
MutationObserver now drops them when the modal leaves the document.
web/js/sse-stream.js reads server-sent events over fetch so POST-only progress
endpoints can stream.
52 lines
2.6 KiB
JavaScript
52 lines
2.6 KiB
JavaScript
// Run with: node --test tests/js/
|
|
const test = require("node:test");
|
|
const assert = require("node:assert/strict");
|
|
const { nextPageState, shouldSaveEdit, hasMorePages } = require("../../web/js/list-state.js");
|
|
|
|
test("hasMorePages follows pagination.has_more only while pages keep arriving", () => {
|
|
assert.equal(hasMorePages({ pagination: { has_more: true } }, 5000), true);
|
|
assert.equal(hasMorePages({ pagination: { has_more: false } }, 5000), false);
|
|
assert.equal(hasMorePages({ pagination: { has_more: true } }, 0), false, "an empty page ends the loop");
|
|
assert.equal(hasMorePages({}, 10), false, "no pagination block means a single page");
|
|
assert.equal(hasMorePages(null, 10), false);
|
|
});
|
|
|
|
const current = { page: 2, limit: 50, total: 120, totalPages: 3 };
|
|
|
|
test("nextPageState moves to the requested page once the fetch succeeded", () => {
|
|
assert.deepEqual(nextPageState(current, { page: 3, total: 120 }), { page: 3, limit: 50, total: 120, totalPages: 3 });
|
|
});
|
|
|
|
test("nextPageState clamps a page beyond the end when the total shrank", () => {
|
|
assert.deepEqual(nextPageState(current, { page: 3, total: 60 }), { page: 2, limit: 50, total: 60, totalPages: 2 });
|
|
});
|
|
|
|
test("nextPageState never goes below page 1 and has at least one page", () => {
|
|
assert.deepEqual(nextPageState(current, { page: 0, total: 0 }), { page: 1, limit: 50, total: 0, totalPages: 1 });
|
|
assert.equal(nextPageState(current, { page: -5, total: 10 }).page, 1);
|
|
});
|
|
|
|
test("nextPageState keeps the current page and total when the response omits them", () => {
|
|
assert.deepEqual(nextPageState(current, {}), current);
|
|
assert.deepEqual(nextPageState(current, { total: "many", page: "x" }), current);
|
|
});
|
|
|
|
test("nextPageState accepts a new limit and recomputes totalPages", () => {
|
|
assert.deepEqual(nextPageState(current, { page: 1, limit: 25, total: 120 }), { page: 1, limit: 25, total: 120, totalPages: 5 });
|
|
assert.equal(nextPageState(current, { limit: 0 }).limit, 50, "a zero limit is ignored");
|
|
});
|
|
|
|
test("nextPageState does not mutate its input", () => {
|
|
const before = { ...current };
|
|
nextPageState(current, { page: 1, total: 5 });
|
|
assert.deepEqual(current, before);
|
|
});
|
|
|
|
test("shouldSaveEdit is true only for a non-empty text that changed", () => {
|
|
assert.equal(shouldSaveEdit("old", "new"), true);
|
|
assert.equal(shouldSaveEdit("same", "same"), false);
|
|
assert.equal(shouldSaveEdit("same", " same \n"), false, "whitespace-only changes are not saved");
|
|
assert.equal(shouldSaveEdit("old", " "), false, "an emptied prompt is not saved");
|
|
assert.equal(shouldSaveEdit("old", null), false);
|
|
});
|