Vito
b4c7a15045
* feat(review): add review queue schema with restore validation
Add the Needs review schema group (media_review_metadata,
media_review_items, media_review_decisions) beside the image annotation
group it cites. review_schema_error validates the catalog, columns,
foreign keys, row values and canonical 8 MiB evidence read-only;
migrate_review_state installs it in a SAVEPOINT after the annotation
group, and verify_database_file requires it under require_library_state.
A review group without a valid annotation group is refused. Decisions
null their pair and image navigation through indexes when those are
deleted. Old backups and annotation-era backups restore and gain the
group; browser fixtures clear the new tables on reset.
* feat(review): persist ambiguous sampler evidence from scans and new outputs
The output scan and the live monitor now queue every file the ingestion
resolver finds ambiguous for Needs review. The file is captured, its metadata
is read again from the capture and resolved with the default profile, and only
an ambiguous result is stored, bound to the capture's annotation byte record
and fenced by its storage epoch. Evidence holds one hashed projection per
selectable candidate; none, more than 16 or over 8 MiB is a limited item.
Recording is idempotent per bytes and evidence and never touches a decision.
Scan statuses, counters, outcome rows and legacy SSE events are unchanged; the
job scope gains review_items/review_errors and the log a Needs review line.
The monitor records after its fallback link, best effort.
* feat(review): explicit association decisions with compatible linking
Needs review gains its queue reads and decisions:
- GET /prompt_manager/review/items lists pending items oldest first with
the exact pending total and an HMAC keyset cursor bound to the storage
epoch and the review index revision.
- GET /prompt_manager/review/items/{id} adds the candidates (role texts,
label, selectability), the dependency fingerprint and the digest.
- POST /prompt_manager/review/items/{id}/decision applies a candidate only
for a capture of the item's bytes that the current file still hashes to
and whose evidence is unchanged, through the ingester's compatible-only
rules in the same transaction as the decision row; a conflict writes
nothing. Leave unresolved records the decision and links nothing.
ingest_resolved_pair keeps its contract; its body moves into
_ingest_resolved_pair_in, which runs in the caller's transaction.
Items keep the file's recorded spelling so targets keep their case on
Windows, and a rescan skips the copy and hash of a file whose size and
mtime match the bytes an item already cites.
* fix(review): build the spelling validation test from native paths
On Windows the locator is case-folded and uses backslashes, so the fixed
POSIX pair /out/a.png no longer folded to itself and the new spelling
check refused the good case. The test now spells a mixed-case native path
and folds it with os.path.normcase, and also refuses a locator of another
file.
* fix(review): Apply sees the file under every spelling and rechecks only its choice
Apply now finds the legacy rows of the same physical file however its root
is reached. The roots are real paths while the monitor links under the
directory it watches, so a symlinked or junctioned root, subst or a mapped
drive used to hide the monitor's row and Apply added a second, differently
linked row. Same-name rows are resolved to their physical identity
(normcase(realpath), else samefile); the dependency fingerprint covers all
of them, two rows refuse the choice, one row is enriched under the
ingester's compatible-only rules, and a same-name row the request did not
classify is a changed association.
Apply re-verifies only what the decision depends on: the bytes are still
ambiguous and still offer the chosen candidate. A resolver change that
rewords the reason or reorders candidates leaves pending items applicable.
The resolver version is one constant in prompt_pair_resolver, shared by
ingestion provenance and Needs review.
The transaction's byte check receives the re-hashed digest (or the body's
for Leave unresolved), every Apply refusal branch is tested with zero
writes, and the root listing and realpath calls run on a worker thread.
* fix(review): validate stored review evidence once per startup
Startup used to run the full review validation twice (the early guard and
the install) and the annotation group's row checks inside each, so every
evidence document was parsed and re-encoded twice. The early guard is now
catalog-only (a review group without annotation tables), and the install
validates the group once, trusting the annotation group it has just
validated. The evidence predicate no longer pattern-scans every document in
SQL, because the streamed canonical pass proves it, and the codec is built
once.
Measured on a database with 40,000 items of 4 KiB evidence: startup open
went from 7.7 s to 2.5 s. A test pins one evidence pass per reopen.
Restore and verify_database_file keep the full validation.
* fix(review): keep one capture worker for interactive requests
Needs review recording from the scan and the monitor shared the capture
store's two workers with the Tag dialog and Apply, so a busy scan could
answer a user's preview or decision with "Too many previews are open".
Background captures now never take the last worker or capture slot, and
wait up to two seconds for room before counting the file as not added.
Interactive captures are admitted or refused at once, as before.
* fix(review): refresh the recorded spelling when a file is seen under a new one
A case-only rename on Windows or macOS keeps size and mtime_ns, so the
rescan skipped the file and the item kept the old spelling. Its target was
then formatted from a name the directory no longer lists, the capture
refused it, and the item stayed pending with no way to apply it. The skip
path and a duplicate insert now record the current spelling for every item
at the locator and move the review index revision; item revisions do not
change, so an open decision stays valid. Tested under case-folding
semantics on every platform.
* fix(review): final capture store close and recoverable stale cursors
Closing the capture store at shutdown now runs under the store lock and is
final: a monitor recording or scan batch still in flight gets a capture
error instead of creating a new temp directory and restore subscription
after the cleanup.
A well-formed queue cursor this process cannot verify (opened before a
ComfyUI restart, whose cursor secret is per process) now answers 409
review-conflict with the current total, like any other stale page, instead
of an uncoded 400. Malformed cursors stay 400.
* fix(review): make only the shutdown cleanup final
The previous commit made every close of the capture store final, which
also refused the explicit closes that swap in a fresh store. Only the host's
on_cleanup hook is final now; an observe after it answers a coded capture
error instead of an unhandled 500.
* refactor(admin): move Needs review recording into its own mixin
_record_scanned_review, _record_review_sync, record_review_file and
_log_review_items move unchanged from py/api/admin.py to
py/api/review_recording.py (ReviewRecordingMixin), keeping admin.py from
growing further past the size ceiling. No behaviour change.
* fix(review): record the review fix round and the skip's residual risks in TESTING.md
The Needs review paragraphs now state the rescan skip's residual risks (an
in-place rewrite that keeps size and mtime_ns is never re-queued; a deleted
or moved file leaves its pending item counted), the physical identity rule
for Apply, the candidate-only recheck and shared resolver version, the
spelling refresh, background capture admission, the final shutdown close,
the stale-cursor answer and the measured startup validation cost.
* feat(review): bind queue cursors to the storage epoch only
A decision or a new item (the monitor records one per generation) no
longer makes an open cursor stale: the (created_at, id) keyset stays
ordered when items leave or are appended. A restore still answers
storage-changed and an unverifiable cursor review-conflict.
* feat(review): Needs review page, SAVED VIEWS row and Activity hook
The concept's Metadata review page at #/review: the notice with the
exact pending count, the queue's media cards (shared with Images through
image-card.mjs), and the Resolve the association panel with the sampler
context, the chosen path's prompt blocks, Leave for later and Apply
association. Apply takes a fresh capture; refusals keep the selection
and explain inline; an unanswered decision is resent once. SAVED VIEWS
lists Needs review after Favorites with its count (retires D50), and an
ended scan that recorded review items offers Review metadata in Activity
(D87). Queue items carry the card's media url.
* feat(review): re-read an open Needs review page when its queue changes
An open Needs review page now follows the queue without polling. A new
server-sent event stream, GET /prompt_manager/review/events, sends
"ready" when it opens and "change" after every committed queue change:
an item the scan or the monitor recorded, a spelling refresh, a decision
from any tab, and a restore. database/review_changes.py notifies after
the commit from whichever thread wrote it. The page re-reads its first
page on each event, keeps the open item, its choice and an unanswered
decision, and re-reads the SAVED VIEWS count with it. When the open item
left the queue, the next one opens with a note. A keepalive comment
every 25 s lets the server drop a closed tab; shutdown ends every stream.
Leaving the page mid-decision now releases that decision's capture.
D-NEW-F1 is renumbered D119 in markers and TESTING.md.
* test(review): Needs review page workflows
The review fixture now seeds a real monitor-fallback conflict (the
monitor pipeline links a new output to the most recent prompt, then
queues it), a limited item and a file under no current root, and can add
an output through the monitor or leave one for a metadata scan.
New workflows: Apply links the chosen pair to that file only; a real
association conflict leaves the links unchanged and explains; a limited
item and an unavailable file can only be left unresolved; a tag save
leaves the item pending; keyboard focus, labels and touch targets; an
open page shows items the monitor and a scan add and a decision made in
another tab; leaving the page releases captures, the change stream and
requests. The faked 409 conflict test is replaced by the real one.
* test(review): cover the card Tag button and raise the review floors
The card's Tag on Needs review now has a workflow, and the page's queue
change hook has no unused default. review.mjs and review-state.mjs
floors rise to their measured coverage; no other floor changes.
* feat(review): keep the loaded depth on live re-reads and read once per visit
A queue change re-read only the first 40 items, so the pages Load more had
shown vanished and the page jumped. Each re-read now reads page after page
until it holds as many items as were shown (a restore met after the first
page reads again from the start), so the cards and the scroll position stay.
The stream's ready made every visit read the queue twice. List reads now
answer the queue's version (library_epoch, review_revision) and ready names
the version read after subscribing; the page re-reads on ready only when the
queue it shows is older. The SAVED VIEWS count follows the page's total, so a
change costs no count read. A stream counts as open only once ready is sent.
* test(review): compare Needs review with the approved concept
review-concept.spec.mjs measures the whole Metadata review page as a tree
in the concept and in production, on the review fixture's new
concept-shaped queue (the concept's first three image names and sizes and
its first prompt). mapConceptReview applies only D29, D119, D3, production's
hooks and accessible names and sample data, and the page then matches at
1600x1100 and 390x844 in both themes. The gallery layout follows the
concept at every breakpoint, the SAVED VIEWS rows match with Needs review
after Favorites, the queue's Tag image dialog matches the needs-review
reference, and a dropped notice border or reordered actions fail.
The comparison found one gap: an unavailable file's card lost its media
area. Its empty media button now keeps the concept's 1.33 ratio (D119).
TESTING.md records the comparison, the extended D119 and a summary of the
image-tagging slice (routes, S1, capture limits, the record-changing job,
the no-download rule, the restart note). A ready whose version cannot be
read re-reads the queue (covered by a page test).
* test(review): give the multi-route shell comparison a fitting time budget
The dispatched CI run failed "shell geometry, tokens and controls match the
concept 390x844 light" on WebKit with a 30 s test timeout (no assertion
failed). Each of these tests makes twelve page loads with captures, hovers
and focus checks: 15-19 s on a CI WebKit runner on main, 22-31 s on this
run's loaded shard. With 2 CPUs and 3 workers it fails locally the same way
(6 of 12 timed out); with a 90 s budget, as the other multi-state concept
comparisons have, all 12 pass.
* fix(review): coalesce queue change events and answer queue thumbnails
- The change stream sends the first notice at once and collapses the
notices of the next 0.4 s into one trailing change, so a busy scan costs
an open page one re-read per 0.4 s at most (COALESCE_SECONDS).
- Queue items answer thumbnail_url, the same URL the Images listing builds
(one shared helper, media_thumbnail_url), or null without a thumbnail.
- The "duplicate and refused decision send nothing" test spies on
notify_review_change instead of reading the next event.
* fix(review): keep the live queue right through applies, Load more and lost streams
- A change heard while a decision is in flight is owed and read once the
decision is refused or unanswered (I1).
- Load more has its own read: during a re-read it waits and continues from
the re-read queue; a re-read started during Load more takes the click
over, and a failed re-read leaves Load more clickable (I2, M7).
- A stream the browser gave up on (503, proxy error) reopens after 3 s,
doubling to 30 s, with a quiet "Live updates are paused" line while it is
down (I3, D-NEW-F2).
- A hidden tab closes its stream and a visible one reopens it; the ready
version keeps that to at most one read (I4).
- Apply fences on the detail's epoch and a re-read under another epoch reads
the open item again (M3); leaving during the observe releases its capture
(M4); an unanswered decision that landed finishes as recorded (M5); cards
follow a re-read's url, target and availability and show thumbnails
(M6, M10).
- The unreadable-ready test asserts exactly one re-read (M1); the panel's
long-file-name wrap carries its D119 marker and TESTING.md entry (M8).
* docs(review): number the live-updates-paused deviation D120
* fix(review): refuse monitor recording beside record-changing jobs
System S1 (#289) gives every record change a registry admission class. The
scan already records Needs review items under its own records job. The
monitor's recording lasts one file and is not a job, so it now checks the
records admission: while a records or guarded job or hold runs it records
nothing, logs that the file waits for the next scan, and answers deferred.
The fallback link stands and the next "new" scan reads the ambiguous file
again, because a fallback link is not a resolved one.
JobRegistry.blocker and active iterate a snapshot of the jobs, since the
monitor's worker thread now asks them too.
* test(backup): wait for the restore, not a 5 s timer, in the thread test
test_database_is_usable_from_every_thread_after_restore let its worker
wait 5 s for the restore. On a stalled Windows runner (py3.11, where the
previous restore test also took 25 s instead of 0.3 s) the restore took
longer, the wait timed out, and the worker read the old database before
the restore ran. The worker now waits for the event under a 120 s bound
that only a hung test reaches, reports a timeout as an error, and the
main thread releases it even when the restore raises. With a restore
delayed by 6 s the old test fails and the new one passes.
* fix(activity): drop Cancel job from a job that had ended before Activity opened
Since #289 the Activity list removed an item's actions only when they were
isConnected. On the first render the item is not in the page yet, so a job
that had already ended when Activity opened kept its "Cancel job" (and a
running job's progress was moved after its actions, then back). The list
now asks parentNode instead. The review spec "a scan job with review items
offers Review metadata in Activity" failed on this before the change
(Expected 0 buttons on a finished job, Received 1) and passes after it.
* fix(review): store non-finite evidence as null and count pending items
canonical_evidence now follows main's non-finite policy (#303): NaN and
±Infinity are written as null instead of raising, so a NaN-stamped graph
never turns a review item limited. The System Overview reports the review
queue's pending total in needs_review.pending, read in the same snapshot
as the Library counts.
* fix(review): show the pending count on the System Overview review row
The Overview's review row now reads "N ambiguous image links" with the
concept's line, from needs_review.pending. Its Review metadata action
stays aria-disabled until the Needs review page ships. The system specs
and their concept comparison follow the real count.
* feat(review): open Needs review from the System Overview review row
Review metadata on the Overview's review row now opens #/review, the
concept's go-review, instead of staying aria-disabled.
* fix(system): answer the Overview and Statistics only after every read ended
asyncio.gather answered at the first failed read while its sibling
executor reads were still inside SQLite. In the suite the test teardown
then deleted the database under the running read, and py3.10 on Ubuntu
segfaulted in get_statistics (test_statistics_failure_is_an_error_envelope).
Both routes now wait for all their reads before answering.
* fix(review): queue only ambiguous files that nothing links, and heal the queue
The maintainer's live scan (19,908 files, scope "new") reported 4,677 files
under Needs review, but the queue held 10,232 items: every file the strict
resolver found ambiguous was queued, including the ones the legacy
browser-parser fallback then linked (all sampled "added" rows) and the ones
already linked to a known prompt (135 of 200 sampled "known" rows).
A file is now queued only when its final outcome is ambiguous and unlinked:
the resolver finds it ambiguous, the fallback links nothing and no saved row
links it already. An ambiguous file that a saved row links is reported as
unchanged ("Already linked to its prompt"), not as Needs review.
The queue heals itself. After each batch, the scan removes the pending items
of every listed file (read, or skipped as known) that a saved row now links.
The monitor does the same for each ambiguous output it links, and never
queues one. Only an undecided item is removed (pending, revision 0, no
decision row), so a decision is never deleted or changed and the schema
needs no new state.
The scan job's scope.review_items now counts this scan's files that are in
the pending queue after it, new or already there, so it agrees with the
review group's ambiguous rows and with the queue total. review_added and
review_settled are new, and the log gains "already in Needs review" and
"left Needs review · now linked" lines. A duplicate whose item is decided is
reported as "decided" and is not counted.
* fix(review): announce items that leave the queue, and seed only queueable files
#284 now queues a file only when its final outcome is ambiguous and unlinked,
and it removes the pending items of files that are now linked. That removal
is a queue change, so it calls notify_review_change after its commit, like
recording and decisions: an open Needs review page re-reads its queue, and
its count follows.
The review browser fixture wrote graphs that the scan's fallback links, and
it produced the conflict item through the monitor's fallback link. Neither is
queued any more. Its files now carry ComfyUI's Infinity stamp, which the
legacy parser cannot read, so they stay unlinked with the same two
candidates. The conflict item is queued first and its file is linked to
another prompt afterwards. "monitor" additions go through
record_review_file from a worker thread.
* fix(review): never queue an ambiguous file with nothing to choose
The maintainer's live queue held 39 items whose candidates all read
"unresolved" ("No positive / No negative"). An ambiguous result is now
reviewable only when at least two candidates are resolved with non-blank
positive text. With none the file could not be traced; with exactly one,
the untraced branches may still have made the file, so that text is not
certain either. Both are reported unresolved, never linked and never
queued (also the A1111 two-delimiter case, which has no candidates).
A rescan removes the pending items of such files whose own evidence
offers no choice, with the same safe delete as the linked settle
(pending, revision 0, no decision row). A limited item (over 16 candidates) that holds at least two
candidates is kept. The job scope gains review_untraced and the log
"= N images left Needs review · nothing to choose".
* test(review): seed the limited item from a graph with more candidates than stored
An A1111 block with two negative lines offers no candidate to choose, so
Needs review no longer queues it (#284). The fixture now records a graph of
17 samplers, which the recorder stores limited.
557 lines
33 KiB
JavaScript
557 lines
33 KiB
JavaScript
// Needs review (#249 PR F, plan Tasks F1 and F2, Mock inventory M4): the SAVED VIEWS row and its count, the Metadata
|
|
// review page over the real review routes, and Activity's Review metadata. Items are recorded by the real recorder
|
|
// (tests/browser/workspace_review_fixture.py) through the monitor's entry point; the conflict item's file was linked
|
|
// to another prompt after it was queued. An open page re-reads its queue from the review change stream (F2).
|
|
import { startCoverage, saveCoverage } from '../../tools/vendor/browser-coverage.mjs';
|
|
import { test, expect } from './fixtures.mjs';
|
|
|
|
const review = '/prompt_manager/workspace#/review';
|
|
const main = page => page.locator('#workspace-main');
|
|
const savedNav = page => page.getByRole('navigation', { name: 'Saved views', exact: true });
|
|
const reviewRow = page => savedNav(page).locator('a[data-route="review"]');
|
|
const panel = page => main(page).getByRole('region', { name: 'Resolve the association', exact: true });
|
|
const context = page => panel(page).getByRole('combobox', { name: 'Sampler context', exact: true });
|
|
const cards = page => main(page).locator('.review-queue article.media-card');
|
|
const toast = page => page.locator('#workspace-toast');
|
|
const NOTICE = 'Multiple sampler paths were found. The existing image links were preserved. Choose the correct context or leave them unresolved.';
|
|
const EMPTY = 'Ambiguous images are added when a metadata scan or a new generation finds more than one sampler path.';
|
|
const OPTIONS = ['Sampler 11 · Golden dunes at dusk / Soft negative, blur', 'Sampler 13 · Harbor lights at night / Soft negative, blur',
|
|
'Leave unresolved'];
|
|
|
|
async function seed(request, items = 3, special = {}) {
|
|
const response = await request.post('/__test__/review/reset', { data: { items, ...special } });
|
|
await expect(response).toBeOK();
|
|
return response.json();
|
|
}
|
|
async function pending(request) {
|
|
return (await (await request.get('/prompt_manager/review/items?limit=1')).json()).total;
|
|
}
|
|
const links = async request => (await (await request.get('/__test__/review/links')).json()).links;
|
|
const streams = async request => (await (await request.get('/__test__/review/streams')).json());
|
|
const apply = page => panel(page).getByRole('button', { name: 'Apply association', exact: true });
|
|
const warning = page => panel(page).locator('.warning-note');
|
|
/** The page with its first item's sampler paths loaded. */
|
|
async function open(page) {
|
|
await page.goto(review);
|
|
await expect(context(page)).toBeEnabled();
|
|
}
|
|
|
|
test.beforeEach(async ({ page, browserName }) => {
|
|
await startCoverage(page, browserName);
|
|
page.reviewErrors = [];
|
|
page.on('pageerror', error => page.reviewErrors.push(error.message));
|
|
});
|
|
test.afterEach(async ({ page, browserName, request }) => {
|
|
await saveCoverage(page, browserName);
|
|
expect(page.reviewErrors).toEqual([]);
|
|
await request.post('/__test__/jobs/restart');
|
|
});
|
|
|
|
test('queue shows persisted items and the nav count', async ({ page, request }) => {
|
|
await seed(request, 3);
|
|
await open(page);
|
|
// SAVED VIEWS: Favorites, then Needs review with the exact pending count (ruling R5).
|
|
await expect(savedNav(page).locator('a').nth(1)).toHaveAttribute('data-route', 'review');
|
|
await expect(reviewRow(page)).toHaveText('Needs review3');
|
|
await expect(reviewRow(page)).toHaveAttribute('aria-current', 'page');
|
|
await expect(page).toHaveTitle('Review · Prompt Manager');
|
|
await expect(page.locator('#workspace-breadcrumb')).toHaveText('Review');
|
|
await expect(main(page).getByRole('heading', { level: 1 })).toHaveText('Metadata review');
|
|
await expect(main(page).locator('.heading p.muted')).toHaveText('Uncertain evidence stays visible until you decide.');
|
|
await expect(main(page).locator('.notice h2')).toHaveText('3 images need a decision');
|
|
await expect(main(page).locator('.notice p')).toHaveText(NOTICE);
|
|
await expect(cards(page)).toHaveCount(3);
|
|
await expect(cards(page).first()).toHaveClass(/selected/);
|
|
await expect(panel(page).locator('p.small')).toHaveText('review_0000.png');
|
|
await expect(context(page).locator('option')).toHaveText(OPTIONS);
|
|
await expect(context(page)).toHaveValue(/^[0-9a-f]{64}$/);
|
|
await expect(panel(page).locator('.prompt-section.positive .prompt-text')).toHaveText('Golden dunes at dusk');
|
|
await expect(panel(page).locator('.prompt-section.negative .prompt-text')).toHaveText('Soft negative, blur');
|
|
await context(page).selectOption({ label: OPTIONS[1] });
|
|
await expect(panel(page).locator('.prompt-section.positive .prompt-text')).toHaveText('Harbor lights at night');
|
|
await context(page).selectOption({ label: 'Leave unresolved' });
|
|
await expect(panel(page).locator('.prompt-section.positive .prompt-text')).toHaveText('Multiple possible prompts. Source could not be determined.');
|
|
// Info selects another item.
|
|
await cards(page).nth(1).getByRole('button', { name: 'Inspect review_0001.png', exact: true }).click();
|
|
await expect(panel(page).locator('p.small')).toHaveText('review_0001.png');
|
|
await expect(cards(page).nth(1)).toHaveClass(/selected/);
|
|
await expect(context(page)).toBeEnabled();
|
|
// The card's image opens the shared viewer.
|
|
await cards(page).nth(1).getByRole('button', { name: 'Open review_0001.png', exact: true }).click();
|
|
await expect(page.locator('#viewer-dialog')).toBeVisible();
|
|
await page.keyboard.press('Escape');
|
|
await expect(page.locator('#viewer-dialog')).toHaveCount(0);
|
|
// Open activity.
|
|
await main(page).getByRole('button', { name: 'Open activity', exact: true }).click();
|
|
await expect(page).toHaveURL(/#\/activity$/);
|
|
});
|
|
|
|
test('apply candidate links the pair and the item leaves the queue and the count drops', async ({ page, request }) => {
|
|
await seed(request, 2);
|
|
await open(page);
|
|
await expect(reviewRow(page)).toHaveText('Needs review2');
|
|
const decided = page.waitForResponse(item => /\/review\/items\/[^/]+\/decision$/.test(item.url()));
|
|
await panel(page).getByRole('button', { name: 'Apply association', exact: true }).click();
|
|
expect((await decided).status()).toBe(200);
|
|
await expect(toast(page)).toHaveText('Association accepted.');
|
|
await expect(page).toHaveURL(/#\/images$/);
|
|
await expect(reviewRow(page)).toHaveText('Needs review1');
|
|
expect(await pending(request)).toBe(1);
|
|
// The first sampler path's pair is linked to that file, and only to it.
|
|
expect(await links(request)).toEqual([{ filename: 'review_0000.png', prompt: 'Golden dunes at dusk',
|
|
pair_id: expect.any(Number), positive: 'Golden dunes at dusk', negative: 'Soft negative, blur' }]);
|
|
});
|
|
|
|
test('conflict leaves links unchanged and explains', async ({ page, request }) => {
|
|
// Queued first, then linked to another prompt (before a scan or monitor pass could settle it).
|
|
await seed(request, 0, { conflict: true });
|
|
const before = await links(request);
|
|
expect(before).toEqual([{ filename: 'conflict.png', prompt: 'Misty forest path', pair_id: null, positive: null,
|
|
negative: null }]);
|
|
await open(page);
|
|
await expect(panel(page).locator('p.small')).toHaveText('conflict.png');
|
|
await expect(context(page).locator('option')).toHaveText(OPTIONS);
|
|
const decided = page.waitForResponse(item => /\/decision$/.test(item.url()));
|
|
await apply(page).click();
|
|
const answer = await decided;
|
|
expect(answer.status()).toBe(409);
|
|
expect((await answer.json()).code).toBe('association-conflict');
|
|
await expect(warning(page)).toHaveText('This image is already linked to another prompt or negative, so this sampler path cannot be attached safely. The existing links were preserved.');
|
|
await expect(page).toHaveURL(/#\/review$/);
|
|
await expect(context(page)).toBeEnabled();
|
|
await expect(context(page)).toHaveValue(/^[0-9a-f]{64}$/);
|
|
expect(await links(request)).toEqual(before);
|
|
expect(await pending(request)).toBe(1);
|
|
await expect(reviewRow(page)).toHaveText('Needs review1');
|
|
// The file can still be left unresolved, which links nothing either.
|
|
await context(page).selectOption({ label: 'Leave unresolved' });
|
|
await apply(page).click();
|
|
await expect(toast(page)).toHaveText('Left unresolved.');
|
|
expect(await links(request)).toEqual(before);
|
|
expect(await pending(request)).toBe(0);
|
|
});
|
|
|
|
test('a limited item and an unavailable file can only be left unresolved', async ({ page, request }) => {
|
|
await seed(request, 0, { limited: true, unavailable: true });
|
|
await open(page);
|
|
await expect(cards(page)).toHaveCount(2);
|
|
await expect(panel(page).locator('p.small')).toHaveText('limited.png');
|
|
await expect(context(page).locator('option')).toHaveText(['Leave unresolved']);
|
|
await expect(warning(page)).toHaveText('This file has too many sampler paths to list. You can leave it unresolved.');
|
|
// The unavailable file: no current root lists it, so its media and Tag are inert.
|
|
const unavailable = cards(page).nth(1);
|
|
await expect(unavailable.locator('.image-open')).toHaveAttribute('aria-disabled', 'true');
|
|
await expect(unavailable.locator('.image-card-actions button').last()).toHaveAttribute('aria-disabled', 'true');
|
|
// F3: its empty media button keeps the concept's 1.33 media area, so the card lines up with its neighbours.
|
|
await expect(cards(page).first().locator('.image-open img')).toBeVisible();
|
|
const sizes = await cards(page).evaluateAll(nodes => nodes.map(node => {
|
|
const art = node.querySelector('.image-open').getBoundingClientRect();
|
|
return [Math.round(art.width), Math.round(art.height), Math.round(node.getBoundingClientRect().height)];
|
|
}));
|
|
expect(sizes[1]).toEqual(sizes[0]);
|
|
await unavailable.getByRole('button', { name: 'Inspect unavailable.png', exact: true }).click();
|
|
await expect(panel(page).locator('p.small')).toHaveText('unavailable.png');
|
|
await expect(warning(page)).toHaveText('This file is not under a current image source, so it cannot be opened. You can leave it unresolved.');
|
|
await expect(panel(page).getByRole('button', { name: 'Tag image', exact: true })).toHaveAttribute('aria-disabled', 'true');
|
|
const observes = [];
|
|
page.on('request', item => { if (item.url().endsWith('/image-annotations/observe')) observes.push(item.url()); });
|
|
await apply(page).click();
|
|
await expect(toast(page)).toHaveText('Left unresolved.');
|
|
expect(observes).toEqual([]);
|
|
expect(await pending(request)).toBe(1);
|
|
});
|
|
|
|
test('leave unresolved removes the item from pending', async ({ page, request }) => {
|
|
await seed(request, 2);
|
|
await open(page);
|
|
await context(page).selectOption({ label: 'Leave unresolved' });
|
|
await panel(page).getByRole('button', { name: 'Apply association', exact: true }).click();
|
|
await expect(toast(page)).toHaveText('Left unresolved.');
|
|
await expect(page).toHaveURL(/#\/images$/);
|
|
expect(await pending(request)).toBe(1);
|
|
});
|
|
|
|
test('leave for later writes nothing and goes to Images', async ({ page, request }) => {
|
|
await seed(request, 2);
|
|
await open(page);
|
|
const writes = [];
|
|
page.on('request', item => { if (item.method() !== 'GET') writes.push(item.url()); });
|
|
await panel(page).getByRole('button', { name: 'Leave for later', exact: true }).click();
|
|
await expect(page).toHaveURL(/#\/images$/);
|
|
expect(writes).toEqual([]);
|
|
expect(await pending(request)).toBe(2);
|
|
});
|
|
|
|
test('tag image from review saves tags and the item remains pending', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
await open(page);
|
|
const before = await links(request);
|
|
await panel(page).getByRole('button', { name: 'Tag image', exact: true }).click();
|
|
const dialog = page.getByRole('dialog', { name: 'Tag image', exact: true });
|
|
await expect(dialog).toBeVisible();
|
|
await expect(dialog.locator('p.tag-scope-note')).toHaveText('Tags belong to this image. Resolve its prompt association separately in Needs review.');
|
|
await dialog.getByRole('textbox', { name: 'Image tags · edit manually', exact: true }).fill('dunes');
|
|
await dialog.getByRole('button', { name: 'Save manual tags', exact: true }).click();
|
|
await expect(toast(page)).toHaveText('1 tags saved for review_0000.png. Prompt association still awaits review.');
|
|
await expect(dialog).toHaveCount(0);
|
|
expect(await pending(request)).toBe(1);
|
|
await expect(page).toHaveURL(/#\/review$/);
|
|
// The item is untouched: still listed, still open, nothing linked.
|
|
await expect(cards(page)).toHaveCount(1);
|
|
await expect(context(page)).toBeEnabled();
|
|
expect(await links(request)).toEqual(before);
|
|
const [item] = (await (await request.get('/prompt_manager/review/items')).json()).items;
|
|
expect([item.state, item.revision]).toEqual(['pending', 0]);
|
|
// The card's Tag opens the same dialog.
|
|
await cards(page).first().getByRole('button', { name: 'Tag or auto-tag review_0000.png', exact: true }).click();
|
|
await expect(dialog).toBeVisible();
|
|
await expect(dialog.locator('p.tag-scope-note')).toBeVisible();
|
|
await page.keyboard.press('Escape');
|
|
await expect(dialog).toHaveCount(0);
|
|
});
|
|
|
|
test('an empty queue shows the empty notice only', async ({ page, request }) => {
|
|
await seed(request, 0);
|
|
await page.goto(review);
|
|
await expect(main(page).locator('.notice h2')).toHaveText('No images need a decision');
|
|
await expect(main(page).locator('.notice p')).toHaveText(EMPTY);
|
|
await expect(main(page).locator('.gallery-layout')).toHaveCount(0);
|
|
await expect(reviewRow(page)).toHaveText('Needs review0');
|
|
});
|
|
|
|
test('load more appends the next page', async ({ page, request }) => {
|
|
await seed(request, 45);
|
|
await open(page);
|
|
await expect(cards(page)).toHaveCount(40);
|
|
const continuation = main(page).locator('.infinite-continuation');
|
|
await expect(continuation.locator('p')).toHaveText('40 of 45 images');
|
|
await continuation.getByRole('button', { name: 'Load more images', exact: true }).click();
|
|
await expect(cards(page)).toHaveCount(45);
|
|
await expect(continuation).toHaveCount(0);
|
|
});
|
|
|
|
test('a scan job with review items offers Review metadata in Activity', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
const started = await (await request.post('/__test__/jobs/start', { data: { total: 10, review_items: 2 } })).json();
|
|
await expect(await request.post(`/__test__/jobs/${started.job.id}/finish`, { data: {} })).toBeOK();
|
|
const plain = await (await request.post('/__test__/jobs/start', { data: { total: 10 } })).json();
|
|
await expect(await request.post(`/__test__/jobs/${plain.job.id}/finish`, { data: {} })).toBeOK();
|
|
await page.goto('/prompt_manager/workspace#/activity');
|
|
const item = main(page).locator(`.activity-item[data-job-id="${started.job.id}"]`);
|
|
await expect(item.getByRole('button', { name: 'Review metadata', exact: true })).toBeVisible();
|
|
await expect(main(page).locator(`.activity-item[data-job-id="${plain.job.id}"] button`)).toHaveCount(0);
|
|
await page.goto(`/prompt_manager/workspace#/activity/${started.job.id}`);
|
|
const actions = main(page).locator('.heading-actions button');
|
|
await expect(actions).toHaveText(['Download report', 'Review metadata']);
|
|
await actions.nth(1).click();
|
|
await expect(page).toHaveURL(/#\/review$/);
|
|
await expect(main(page).getByRole('heading', { level: 1 })).toHaveText('Metadata review');
|
|
});
|
|
|
|
test('a failed item read says so and Retry reads it again', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
await page.route(url => /\/prompt_manager\/review\/items\/[0-9a-f-]{36}$/.test(url.pathname),
|
|
route => route.fulfill({ status: 500, contentType: 'application/json', body: JSON.stringify({ success: false, code: 'review-failed', error: 'x' }) }),
|
|
{ times: 1 });
|
|
await page.goto(review);
|
|
await expect(panel(page).locator('.warning-note')).toHaveText('This item could not be read. Select it again to retry.');
|
|
await expect(panel(page).getByText('Could not read prompts from this file.', { exact: true })).toBeVisible();
|
|
await expect(panel(page).getByRole('button', { name: 'Apply association', exact: true })).toHaveAttribute('aria-disabled', 'true');
|
|
await panel(page).getByRole('button', { name: 'Retry prompt details', exact: true }).click();
|
|
await expect(context(page)).toBeEnabled();
|
|
await expect(context(page).locator('option')).toHaveText(OPTIONS);
|
|
await expect(panel(page).locator('.warning-note')).toBeHidden();
|
|
});
|
|
|
|
test('a failed queue read offers Retry', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
await page.route(url => url.pathname.endsWith('/prompt_manager/review/items') && url.searchParams.get('limit') === '40',
|
|
route => route.fulfill({ status: 500, contentType: 'application/json', body: JSON.stringify({ success: false, code: 'review-failed', error: 'x' }) }),
|
|
{ times: 1 });
|
|
await page.goto(review);
|
|
await expect(main(page).getByRole('alert')).toHaveText('The review queue could not be read.');
|
|
await main(page).getByRole('button', { name: 'Retry', exact: true }).click();
|
|
await expect(context(page)).toBeEnabled();
|
|
await expect(main(page).locator('.notice h2')).toHaveText('1 image needs a decision');
|
|
});
|
|
|
|
test('keyboard focus labels and touch targets', async ({ page, request }) => {
|
|
await seed(request, 2);
|
|
await open(page);
|
|
const first = cards(page).first();
|
|
for (const [name, role] of [['Open review_0000.png', 'button'], ['Inspect review_0000.png', 'button'],
|
|
['Tag or auto-tag review_0000.png', 'button']]) await expect(first.getByRole(role, { name, exact: true })).toBeVisible();
|
|
await expect(main(page).getByRole('list', { name: 'Review queue', exact: true })).toBeVisible();
|
|
await expect(panel(page)).toBeVisible();
|
|
// Keyboard: Info on the second card opens it, and the panel's controls take focus in their order.
|
|
const info = cards(page).nth(1).getByRole('button', { name: 'Inspect review_0001.png', exact: true });
|
|
await info.focus();
|
|
await page.keyboard.press('Enter');
|
|
await expect(panel(page).locator('p.small')).toHaveText('review_0001.png');
|
|
await expect(context(page)).toBeEnabled();
|
|
await context(page).focus();
|
|
await expect(context(page)).toBeFocused();
|
|
const order = await panel(page).evaluate(node => [...node.querySelectorAll('button, select')]
|
|
.filter(control => control.offsetParent !== null).map(control => control.getAttribute('aria-label') || control.textContent.trim()));
|
|
expect(order[0]).toBe('Tag image');
|
|
expect(order.slice(-2)).toEqual(['Leave for later', 'Apply association']);
|
|
// Targets: the panel's controls are 40px on a coarse pointer (the concept's coarse buttons) and 24px otherwise (the
|
|
// WCAG 2.2 minimum); the card's buttons keep the concept's compact size, never under 24px (its ≤700px rule).
|
|
const coarse = await page.evaluate(() => matchMedia('(pointer: coarse)').matches);
|
|
const sized = [
|
|
[panel(page).getByRole('button', { name: 'Tag image', exact: true }), coarse ? 40 : 24],
|
|
[context(page), coarse ? 40 : 24],
|
|
[panel(page).getByRole('button', { name: 'Leave for later', exact: true }), coarse ? 40 : 24],
|
|
[apply(page), coarse ? 40 : 24],
|
|
[first.getByRole('button', { name: 'Inspect review_0000.png', exact: true }), 24],
|
|
[first.getByRole('button', { name: 'Tag or auto-tag review_0000.png', exact: true }), 24],
|
|
];
|
|
for (const [control, minimum] of sized) {
|
|
const box = await control.boundingBox();
|
|
const label = await control.evaluate(node => node.getAttribute('aria-label') || node.textContent.trim().slice(0, 40));
|
|
expect(box.height, label).toBeGreaterThanOrEqual(minimum);
|
|
expect(box.width, label).toBeGreaterThanOrEqual(24);
|
|
}
|
|
// Enter on Leave for later returns to Images.
|
|
await panel(page).getByRole('button', { name: 'Leave for later', exact: true }).focus();
|
|
await page.keyboard.press('Enter');
|
|
await expect(page).toHaveURL(/#\/images$/);
|
|
});
|
|
|
|
test('an open page shows items the monitor adds and keeps the open choice', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
await context(page).selectOption({ label: OPTIONS[1] });
|
|
await expect(reviewRow(page)).toHaveText('Needs review1');
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect(cards(page)).toHaveCount(2);
|
|
await expect(main(page).locator('.notice h2')).toHaveText('2 images need a decision');
|
|
await expect(reviewRow(page)).toHaveText('Needs review2');
|
|
await expect(cards(page).first()).toHaveClass(/selected/);
|
|
await expect(panel(page).locator('p.small')).toHaveText('review_0000.png');
|
|
await expect(context(page).locator('option:checked')).toHaveText(OPTIONS[1]);
|
|
await expect(warning(page)).toBeHidden();
|
|
});
|
|
|
|
test('an open page shows items a metadata scan adds', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'file' } })).toBeOK();
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
await expect(cards(page)).toHaveCount(1);
|
|
const started = await request.post('/prompt_manager/jobs/scan', { data: { scope: 'new' } });
|
|
expect(started.status()).toBe(202);
|
|
await expect(cards(page)).toHaveCount(2);
|
|
await expect(cards(page).nth(1).getByRole('button', { name: 'Inspect added_0000.png', exact: true })).toBeVisible();
|
|
await expect(reviewRow(page)).toHaveText('Needs review2');
|
|
});
|
|
|
|
test('a decision in another tab leaves the open page and opens the next image', async ({ page, request, context: browserContext }) => {
|
|
await seed(request, 2);
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
const other = await browserContext.newPage();
|
|
await open(other);
|
|
await context(other).selectOption({ label: 'Leave unresolved' });
|
|
await apply(other).click();
|
|
await expect(other).toHaveURL(/#\/images$/);
|
|
await other.close();
|
|
await expect(cards(page)).toHaveCount(1);
|
|
await expect(panel(page).locator('p.small')).toHaveText('review_0001.png');
|
|
await expect(warning(page)).toHaveText('review_0000.png was decided elsewhere, so the next image is open.');
|
|
await expect(main(page).locator('.notice h2')).toHaveText('1 image needs a decision');
|
|
await expect(reviewRow(page)).toHaveText('Needs review1');
|
|
await expect(context(page)).toBeEnabled();
|
|
});
|
|
|
|
/** The queue reads (`?limit=40`, cursors) and count reads (`?limit=1`) the page sends from now on. */
|
|
function reviewReads(page) {
|
|
const reads = [];
|
|
page.on('request', item => {
|
|
const url = new URL(item.url());
|
|
if (url.pathname === '/prompt_manager/review/items') reads.push(url.searchParams.get('cursor') ? 'more' : url.search);
|
|
});
|
|
return reads;
|
|
}
|
|
|
|
test('a visit reads its queue once, and a change reads it once more', async ({ page, request }) => {
|
|
// F3 ruling: the stream's ready must not read a queue the first read already holds.
|
|
await seed(request, 1);
|
|
const reads = reviewReads(page);
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect(cards(page)).toHaveCount(2);
|
|
await expect(reviewRow(page)).toHaveText('Needs review2');
|
|
// The page's first read and the change's re-read; the shell's count read at start, and the row follows the page.
|
|
expect(reads.filter(search => search === '?limit=40')).toHaveLength(2);
|
|
expect(reads.filter(search => search === '?limit=1')).toHaveLength(1);
|
|
});
|
|
|
|
test('a ready whose version cannot be read re-reads the queue once', async ({ page, request }) => {
|
|
// The stream's ready names no readable version (an older server, a proxy that rewrote it): the page reads again.
|
|
await seed(request, 1);
|
|
const reads = reviewReads(page);
|
|
// M1: `retry` keeps the browser from reconnecting the ended stream during the test, so exactly one re-read follows.
|
|
await page.route(url => url.pathname === '/prompt_manager/review/events', route => route.fulfill({
|
|
status: 200, headers: { 'Content-Type': 'text/event-stream', 'Cache-Control': 'no-store' },
|
|
body: 'retry: 3600000\nevent: ready\ndata: not json\n\n' }));
|
|
let reread = 0;
|
|
const second = page.waitForResponse(item => item.url().endsWith('/prompt_manager/review/items?limit=40') && ++reread === 2);
|
|
await open(page);
|
|
await second;
|
|
await expect(cards(page)).toHaveCount(1);
|
|
expect(reads.filter(search => search === '?limit=40')).toHaveLength(2);
|
|
});
|
|
|
|
const live = page => main(page).locator('.heading .review-live');
|
|
const NOT_LIVE = 'Live updates are paused: changes made elsewhere appear once the connection returns.';
|
|
|
|
test('a stream the browser gives up on is opened again, and the page says it is not live meanwhile', async ({ page, request }) => {
|
|
// I3: a 503 (shutdown, or a proxy while the backend restarts) fails an EventSource for good.
|
|
await seed(request, 1);
|
|
let attempts = 0;
|
|
await page.route(url => url.pathname === '/prompt_manager/review/events', route => {
|
|
attempts += 1;
|
|
if (attempts === 1) return route.fulfill({ status: 503, contentType: 'application/json', body: '{"success":false}' });
|
|
return route.fallback();
|
|
});
|
|
await open(page);
|
|
await expect(live(page)).toHaveText(NOT_LIVE);
|
|
await expect(live(page)).toBeVisible();
|
|
// The page opens the stream again (after 3 s) and is live once it sends ready.
|
|
await expect.poll(async () => (await streams(request)).streams, { timeout: 15000 }).toBe(1);
|
|
await expect(live(page)).toBeHidden();
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect(cards(page)).toHaveCount(2);
|
|
expect(attempts).toBe(2);
|
|
});
|
|
|
|
/** Make the page hidden or visible as a tab switch does. */
|
|
async function setVisible(page, visible) {
|
|
await page.evaluate(shown => {
|
|
Object.defineProperty(document, 'hidden', { configurable: true, get: () => !shown });
|
|
Object.defineProperty(document, 'visibilityState', { configurable: true, get: () => (shown ? 'visible' : 'hidden') });
|
|
document.dispatchEvent(new Event('visibilitychange'));
|
|
}, visible);
|
|
}
|
|
|
|
test('a hidden tab closes its stream and a visible one reads only what changed meanwhile', async ({ page, request }) => {
|
|
// I4: background tabs must not hold one of the origin's six connections.
|
|
await seed(request, 1);
|
|
const reads = reviewReads(page);
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
await setVisible(page, false);
|
|
// The server drops a closed stream at its next write: this monitor addition is one.
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(0);
|
|
await expect(cards(page)).toHaveCount(1);
|
|
expect(reads.filter(search => search === '?limit=40')).toHaveLength(1);
|
|
// Visible again: the reopened stream's ready names a newer version, so the page reads once.
|
|
const reread = page.waitForResponse(item => item.url().endsWith('/prompt_manager/review/items?limit=40'));
|
|
await setVisible(page, true);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
await reread;
|
|
await expect(cards(page)).toHaveCount(2);
|
|
await expect(live(page)).toBeHidden();
|
|
expect(reads.filter(search => search === '?limit=40')).toHaveLength(2);
|
|
});
|
|
|
|
test('a re-read refreshes a card whose media or target changed', async ({ page, request }) => {
|
|
// M6 and M10: a root came or went between reads; the card follows, and a known thumbnail is its media.
|
|
await seed(request, 2);
|
|
let rewrite = false;
|
|
await page.route(url => url.pathname === '/prompt_manager/review/items' && url.search === '?limit=40', async route => {
|
|
if (!rewrite) return route.fallback();
|
|
const response = await route.fetch();
|
|
const body = await response.json();
|
|
body.items[0] = { ...body.items[0], thumbnail_url: `${body.items[0].url}&thumb=1` };
|
|
body.items[1] = { ...body.items[1], url: null, thumbnail_url: null, target: null, unavailable: true };
|
|
return route.fulfill({ response, json: body });
|
|
});
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
const second = cards(page).nth(1);
|
|
await expect(second.getByRole('button', { name: 'Open review_0001.png', exact: true })).not.toHaveAttribute('aria-disabled', 'true');
|
|
rewrite = true;
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect(cards(page)).toHaveCount(3);
|
|
await expect(cards(page).first().locator('img')).toHaveAttribute('src', /&thumb=1$/);
|
|
await expect(second.getByRole('button', { name: 'Open review_0001.png', exact: true })).toHaveAttribute('aria-disabled', 'true');
|
|
await expect(second.locator('img')).toHaveCount(0);
|
|
await expect(second.locator('.image-card-actions button').last()).toHaveAttribute('aria-disabled', 'true');
|
|
await expect(cards(page).first()).toHaveClass(/selected/);
|
|
});
|
|
|
|
test('leaving during the observe releases the capture it answers', async ({ page, request }) => {
|
|
// M4: the server made the capture; the page left before the answer came.
|
|
await seed(request, 1);
|
|
await open(page);
|
|
let held;
|
|
const sent = new Promise(resolve => { held = resolve; });
|
|
await page.route(url => url.pathname === '/prompt_manager/image-annotations/observe', async route => {
|
|
const response = await route.fetch();
|
|
held(() => route.fulfill({ response }));
|
|
});
|
|
await apply(page).click();
|
|
const answer = await sent;
|
|
expect((await streams(request)).captures).toBe(1);
|
|
await page.evaluate(() => { window.location.hash = '#/tags'; });
|
|
await expect(main(page).getByRole('heading', { level: 1 })).toHaveText('Tags & categories');
|
|
await answer();
|
|
await expect.poll(async () => (await streams(request)).captures).toBe(0);
|
|
});
|
|
|
|
test('a live re-read keeps the loaded depth and the scroll position', async ({ page, request }) => {
|
|
// F3 ruling: a queue change re-reads as many items as Load more had shown, and the page does not jump.
|
|
await seed(request, 45);
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
await main(page).getByRole('button', { name: 'Load more images', exact: true }).click();
|
|
await expect(cards(page)).toHaveCount(45);
|
|
await cards(page).last().scrollIntoViewIfNeeded();
|
|
const scrollTop = () => cards(page).first().evaluate(node => {
|
|
for (let el = node.parentElement; el; el = el.parentElement) {
|
|
const style = getComputedStyle(el);
|
|
if (/(auto|scroll)/.test(style.overflowY) && el.scrollHeight > el.clientHeight) return el.scrollTop;
|
|
}
|
|
return document.scrollingElement.scrollTop;
|
|
});
|
|
const before = await scrollTop();
|
|
expect(before).toBeGreaterThan(0);
|
|
const reads = reviewReads(page);
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect(main(page).locator('.notice h2')).toHaveText('46 images need a decision');
|
|
await expect(cards(page)).toHaveCount(46);
|
|
expect(await scrollTop()).toBe(before);
|
|
expect(reads).toEqual(['?limit=40', 'more']);
|
|
await expect(main(page).locator('.infinite-continuation')).toHaveCount(0);
|
|
});
|
|
|
|
test('teardown releases captures listeners and requests', async ({ page, request }) => {
|
|
await seed(request, 1);
|
|
await open(page);
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(1);
|
|
const inFlight = new Set();
|
|
page.on('request', item => { if (item.url().includes('/prompt_manager/review/')) inFlight.add(item); });
|
|
page.on('requestfinished', item => inFlight.delete(item));
|
|
page.on('requestfailed', item => inFlight.delete(item));
|
|
// A decision whose answer never comes: leaving the page must still release its capture.
|
|
let held;
|
|
const sent = new Promise(resolve => { held = resolve; });
|
|
await page.route(url => /\/decision$/.test(url.pathname), route => held(route));
|
|
await apply(page).click();
|
|
const route = await sent;
|
|
expect((await streams(request)).captures).toBe(1);
|
|
await page.evaluate(() => { window.location.hash = '#/tags'; });
|
|
await expect(main(page).getByRole('heading', { level: 1 })).toHaveText('Tags & categories');
|
|
await expect.poll(async () => (await streams(request)).captures).toBe(0);
|
|
await route.abort().catch(() => {});
|
|
// The server drops a closed stream at its next write: a monitor addition is one.
|
|
await expect(await request.post('/__test__/review/add', { data: { kind: 'monitor' } })).toBeOK();
|
|
await expect.poll(async () => (await streams(request)).streams).toBe(0);
|
|
await expect.poll(() => inFlight.size).toBe(0);
|
|
});
|