DumiFlex
73ca8a3f9a
Implements spec §4 Flow 4: bulk-at-boot is NOT a parallel forward-chain implementation; it's eager iteration of lazy_migrate_row over every stale row. Same original-first logic, same re-projection, zero divergence. Eliminates the transient-wrong window where bulk could write fabricated defaults over recoverable data in original_payload_json. run_bulk_lazy returns the failure count; caller surfaces a dashboard banner when > 0. STALE_PREDICATE catches both 'sv < current' AND 'tolerantly-installed row whose original now outranks the projection'. Migration 014 invokes run_bulk_lazy at the end of up() — no-op pass at v1, but validates the wiring is correct. Future bump migrations (015 = v2, etc) will reuse the same helper.
87 lines
3.3 KiB
Python
87 lines
3.3 KiB
Python
"""Migration 014: ALTERs modules + bundles with schema_version, original_payload_json,
|
|
tolerant_drift_status, schema_migrated_at; backfills schema_version=1 on existing rows.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import sqlite3
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from engine.db.migrations import migrate
|
|
|
|
|
|
@pytest.fixture
|
|
def db(tmp_path: Path) -> sqlite3.Connection:
|
|
conn = sqlite3.connect(":memory:")
|
|
conn.row_factory = sqlite3.Row
|
|
conn.execute("PRAGMA foreign_keys=ON;")
|
|
migrate(conn)
|
|
return conn
|
|
|
|
|
|
def test_014_adds_module_columns(db: sqlite3.Connection) -> None:
|
|
cols = {row["name"] for row in db.execute("PRAGMA table_info(modules)")}
|
|
assert "schema_version" in cols
|
|
assert "original_payload_json" in cols
|
|
assert "tolerant_drift_status" in cols
|
|
assert "schema_migrated_at" in cols
|
|
|
|
|
|
def test_014_adds_bundle_columns(db: sqlite3.Connection) -> None:
|
|
cols = {row["name"] for row in db.execute("PRAGMA table_info(bundles)")}
|
|
assert "schema_version" in cols
|
|
assert "original_payload_json" in cols
|
|
assert "tolerant_drift_status" in cols
|
|
assert "schema_migrated_at" in cols
|
|
|
|
|
|
def test_014_backfills_schema_version_one_on_existing_rows(
|
|
db: sqlite3.Connection,
|
|
) -> None:
|
|
"""Pre-existing module rows get schema_version=1 (the implicit baseline)."""
|
|
db.execute(
|
|
"INSERT INTO modules(id, type, name, description, category_id, tags, "
|
|
"is_favorite, payload, version, created_at, updated_at) "
|
|
"VALUES('m1','wildcard','m','',NULL,'[]',0,'{}',1,'2026-01-01','2026-01-01')"
|
|
)
|
|
db.commit()
|
|
row = db.execute(
|
|
"SELECT schema_version, tolerant_drift_status FROM modules WHERE id='m1'"
|
|
).fetchone()
|
|
assert row["schema_version"] == 1
|
|
assert row["tolerant_drift_status"] == "none"
|
|
|
|
|
|
def test_014_idempotent_rerun(db: sqlite3.Connection) -> None:
|
|
"""Re-running migrate() doesn't reapply 014 (migrations table guards it)."""
|
|
before = db.execute("SELECT MAX(version) FROM migrations").fetchone()[0]
|
|
migrate(db)
|
|
after = db.execute("SELECT MAX(version) FROM migrations").fetchone()[0]
|
|
assert before == after
|
|
|
|
|
|
def test_014_bulk_runner_iterates_lazy_routine(db: sqlite3.Connection) -> None:
|
|
"""When migration 014 runs (or any payload-bump migration), it walks
|
|
every stale row + invokes lazy_migrate_row. The bulk-at-boot path is
|
|
eager iteration of the lazy routine — NOT a parallel forward-chain
|
|
implementation (spec §4 Flow 4)."""
|
|
# Insert a row we can mark stale (db fixture is function-scoped, fresh DB)
|
|
db.execute(
|
|
"INSERT INTO modules(id, type, name, description, category_id, tags, "
|
|
"is_favorite, payload, version, created_at, updated_at) "
|
|
"VALUES('m1','wildcard','m','',NULL,'[]',0,'{}',1,'2026-01-01','2026-01-01')"
|
|
)
|
|
db.execute("UPDATE modules SET schema_version = 0 WHERE id = 'm1'")
|
|
db.commit()
|
|
|
|
from engine.db.migrations_sql._014_helpers import run_bulk_lazy
|
|
failed = run_bulk_lazy(
|
|
db, current_version=1, migrators={}, validators={}, tolerant_strip={},
|
|
)
|
|
# Failure path runs lazy_migrate_row on each stale row; with no migrators
|
|
# registered + sv=0→1 needed, this fails to migrate. The row stays at 0.
|
|
# The test just confirms the iteration happens (failed > 0 indicates
|
|
# the routine was called for each stale row).
|
|
assert failed >= 1
|