HappyOnigiri
4d45ea6e25
- Rename py/ directory to meld/ to eliminate PyPI 'py' package shadowing, which required conftest.py/path.py workarounds in the test suite - Remove meld/path.py (pytest stub no longer needed after rename) - Empty meld/__init__.py (removed redundant 'from . import path as path') - Replace 87-line conftest.py monkeypatch with minimal Package.setup() shim - Extract create_schema(cursor) from schema.py as single DDL source of truth, called by both init_db() and test helpers - Add permanent_delete, soft_delete, soft_delete_to_trash, restore_image, restore_image_with_rename, and collect_deleted_ancestors to repository.py to eliminate duplicated inline SQL across router.py and importer/service.py - Update all import paths, pyproject.toml, Makefile, CI config, and check_scripts to reference meld/ instead of py/
58 lines
2.1 KiB
Python
58 lines
2.1 KiB
Python
import ast
|
|
import glob
|
|
import os
|
|
|
|
from .abstract_check import ASTChecker
|
|
|
|
|
|
class ApiResponseChecker(ASTChecker):
|
|
def get_target_files(self) -> list[str]:
|
|
# Target all router.py files in features
|
|
pattern = os.path.join("meld", "image_manager", "features", "**", "router.py")
|
|
files = glob.glob(pattern, recursive=True)
|
|
# Also include the main api.py
|
|
api_py = os.path.join("meld", "image_manager", "api.py")
|
|
if os.path.exists(api_py):
|
|
files.append(api_py)
|
|
return files
|
|
|
|
def _get_name(self, node: ast.AST) -> str | None:
|
|
if isinstance(node, ast.Name):
|
|
return node.id
|
|
elif isinstance(node, ast.Attribute):
|
|
base = self._get_name(node.value)
|
|
if base:
|
|
return f"{base}.{node.attr}"
|
|
return None
|
|
|
|
def visit_Call(self, node: ast.Call) -> None:
|
|
func_name = self._get_name(node.func)
|
|
|
|
if func_name == "web.json_response" or func_name == "json_response":
|
|
if not node.args:
|
|
self.add_error(node.lineno, "web.json_response() called without arguments")
|
|
return
|
|
|
|
arg0 = node.args[0]
|
|
|
|
# We want to see ApiResponse(...).to_dict()
|
|
# This is a Call to .to_dict() where the receiver is a Call to ApiResponse(...)
|
|
is_valid = False
|
|
if isinstance(arg0, ast.Call):
|
|
# Check if it's .to_dict()
|
|
if isinstance(arg0.func, ast.Attribute) and arg0.func.attr == "to_dict":
|
|
# Check if the receiver is ApiResponse(...)
|
|
receiver = arg0.func.value
|
|
if isinstance(receiver, ast.Call):
|
|
receiver_func = self._get_name(receiver.func)
|
|
if receiver_func == "ApiResponse":
|
|
is_valid = True
|
|
|
|
if not is_valid:
|
|
self.add_error(
|
|
node.lineno,
|
|
"web.json_response must be called with ApiResponse(...).to_dict(). Found: " + ast.dump(arg0),
|
|
)
|
|
|
|
self.generic_visit(node)
|