A generation with a compare node indexes two temp preview files next to
the output, so one generation showed a badge of 3. Skip assets whose
source is temp.
The 0-5 hotkeys and the grid "Set rating (N selected)" submenu now send
chunked batch requests (<=500 ids, sequential) via updateAssetsRatingBulk
instead of one per-asset request per card, with per-asset
mjr:asset-rating-changed events, a progress toast on multi-chunk runs and
an "N rated, M failed" summary on partial failures. Single-card paths
are unchanged.
- Tag the Studio player's video with the media class the floating viewer
uses, so zoom, pan, exposure/channel tone and overlay guides apply to it
in A/B, side by side and grid like they do to the other slots.
- Stop the A/B divider above the player controls instead of drawing over
them.
- Keep B's aspect ratio when comparing images of different sizes in the
Studio viewer.
The Run group is rendered asynchronously inside the actionbar, and the
observer only watched the actionbar's direct children, so the button stayed
at the end once Run appeared. Observe the subtree and re-anchor when the
button is not right after the Run group.
With the Studio player on A, put layer A on top and clip only its picture
at the divider (B shows underneath), instead of clipping B over A, which
hid the right half of the player controls.
- Floating viewer compare modes (A/B, side by side, grid) now build their
primary video/audio with the Studio player, like the simple mode. The
legacy video controls, their media bridge, styles and tests are removed;
only the sidebar's preview controls remain.
- The Studio viewer closes again when the empty area around the picture is
clicked (quick click only, so panning never dismisses it).
The Studio viewer now covers everything the classic overlay did, so the
classic runtime (toolbar, panzoom, A/B and side-by-side engine, scopes,
loupe, probe, grading and WebGL video processors, filmstrip, context menu,
keyboard handling), its styles and its tests are deleted.
- Every open request goes to the Studio viewer; requestViewerOpen no longer
falls back to a viewer singleton.
- Drop the classic-only settings (use classic viewer, pan without zoom,
disable WebGL) and their internal options and constants.
- Studio tells the grid which asset it ended on when it closes, and the
rating hotkeys yield to it while it is open.
- Remove dead helpers left behind (image processor, media player helpers,
3D helpers, metadata block, viewerbar controls variant) and unused CSS.
- Update the viewer tutorial, hotkeys doc and changelog.
A tool rail on the left of the stage adds channels, exposure and gamma,
zebra, histogram and waveform scopes, composition guides, aspect masks,
pixel probe, loupe, copy to clipboard and A/B compare (wipe, side by side,
difference, add, subtract, multiply, screen) with B selection, pin and
swap. Colour tools are SVG filters so they also apply to playing video;
video compare keeps a second player in sync.
3D models and the A/B / side-by-side open modes now use the Studio viewer,
audio files show a live spectrum, and the inspector's tag editor no longer
steals focus after navigating.
- Simple mode renders video and audio with the Studio player through
mountStudioPlayerHost, which honours the floating viewer's player-host
contract (togglePlay / stepFrames / destroy handle, inner media element
for mute/speed persistence) and releases media on teardown. Falls back
to the legacy player for images, 3D, compare modes, mount failures
and the "classic viewer" setting.
- StudioPlayer gains initial mute/speed, a compact width-aware variant
and an autoplay that retries muted when sound is blocked.
- CSS-only refresh of the floating window aligned with the Studio
viewer; popped-out / desktop-expanded windows stay square.
A simpler, review-first main viewer built in Vue, routed through the
existing OPEN_VIEWER event so every caller keeps working:
- Header with navigation, file summary and actions; zoom/pan image
stage (cursor-anchored wheel zoom, fit/1:1, transparency checker).
- New video/audio player: frame stepping and counter, A-B loop, loop,
speed, volume, fullscreen, save frame as PNG, auto-hiding controls;
media is released on change/close.
- Inspector reusing the asset sidebar's rating, tags, generation,
workflow and file components, hydrated with the viewer metadata
cache; filmstrip windowed for large lists; keyboard shortcuts.
- The classic viewer stays for A/B and side-by-side compare, 3D models
and its analysis tools, and as an opt-in setting.
- Watcher: a sidecar JSON created or edited next to an unchanged media
file now invalidates that file's metadata cache and scan journal and
forces a re-extraction; a non-incremental re-index no longer skips
assets that already have a metadata row when the cache was cleared.
- Merge index rows that are one file under different Windows path
spellings at startup, keeping the best rating, all tags, the stack
cover, execution ids and the vector embedding.
- Remove deleted/removed assets from the generated feed too.
- Scope the floating viewer's single-letter shortcuts to the viewer
(pointer, focus or pop-out) instead of the whole page.
- Take LGraph/LGraphCanvas types from comfyui-frontend-types and drop
@comfyorg/litegraph; delete five dead frontend files.
- Fix an order-dependent test that leaked an input-directory override.
- Search: tokens were filtered down to nothing for inputs like "at-7",
"(2)", "AND", a single letter or a lone quote, producing an empty FTS
MATCH and "Invalid search query syntax". Fall back to the raw words,
treat punctuation-only input as browse-all, keep non-Latin scripts and
fold accents on Latin letters only (as FTS5 unicode61 does).
- Sidecar JSON (<file>.<ext>.json, then <stem>.json) now supplies the
workflow/prompt/generation data of images, videos and audio when none
is embedded; shared with the 3D extractor; BOM tolerated.
- Workflow tab: skip hidden folders (.history version snapshots were
listed as workflows), only list UI exports, API prompts and wrappers,
read with utf-8-sig, drop invalid JSON from the index (version 5),
and load API-format workflows with app.loadApiJson.
- Floating viewer: release (not just pause) videos before re-rendering
and on dispose, so Live mode no longer accumulates media players.
- Clicking a duplicate-stack badge could freeze ComfyUI: displayAssets,
the per-card ref callback (syncRenderedDuplicateCards) and the live
upsert dedupe each rewrote _mjrDupStack/_mjrDupMembers on reactive
assets read by the grid template, with a new array every pass and
conflicting representatives. The ref callback ran on every render, so
each write scheduled another render (no recursion limit in prod Vue).
- Compute duplicate stacks only in buildDisplayAssets with change-guarded
writes and stable member arrays; keep one ref callback per card; stop
the other passes from touching duplicate fields.
- A duplicate is now the same name in the same source/root/subfolder:
files sharing a name in different folders are no longer stacked,
hidden from the grid or given another file's generation time.
- The duplicates view lists every copy using cycle-free member copies.
- Add regression tests (render-loop idempotence, folder scoping).
- Fix assets_fts triggers: the external-content FTS5 table was updated
with plain UPDATE/DELETE, so every rename or move failed with
"database disk image is malformed" and the watcher fell back to
delete + re-index, losing ratings, tags and collections. Use the FTS5
'delete' command, limit the update trigger to filename/subfolder and
repair existing databases (plus an FTS rebuild) at startup.
- Wait for the prompt history entry before post-execution ingestion:
ComfyUI fires on_prompt_end before task_done() stores history, so
outputs of prompts queued from the API or another client could be
missed.
- Scan prune only removes assets whose absence is confirmed; a stat
error or an unreadable scan root no longer deletes user data. Report
pruned assets instead of SQLite change counts.
- Emit mjr-assets-removed for watcher deletes and scan prunes and
mjr-asset-updated for moves so open grids update in place.
- Annotate mjr-scan-complete with origin and needs_refresh; reload the
grid once when live events cannot cover a change and summarise a
finished directory scan in one ComfyUI core toast.
- Document the comparison with ComfyUI core's asset system.
- Use the typed ToastManager API (success/error/info/warning/loading)
instead of the deprecated add(); add() stays as a fallback for older
frontends.
- Accept a toast manager without add() so toasts keep working once
ComfyUI drops the deprecated methods.
- Tracked operations (DB restore/reset, vector backfill) show one
loading toast updated in place via its ToastId instead of stacking a
toast per step; dismiss them on extension teardown.
- Persistent toasts use the largest safe timer delay instead of
Infinity; history action links become native toast action buttons
(http(s) or same-origin paths only).
- Route genInfoOverridePicker and comfyAlert through the core toast API;
drop the app.ui.toast fallback, the no-op fallback dismisser and the
unused .mjr-toast CSS.
- Keep the Majoor message center as a read-only history; it no longer
pops open by itself on reset/backfill.
- Document the notification audit.
- Move the read-only OpenAPI compat surface from /api/v2/assets to
/mjr/am/compat/assets so it never squats ComfyUI core's /api namespace;
the legacy alias is opt-in via MJR_AM_LEGACY_API_V2_ASSETS=1.
- Allow Python 3.14 (requires-python <3.15) and add 3.14 to CI and tox.
- Stop wrapping api.queuePrompt: progress tracking now resolves the
running prompt from the core Jobs API (getJobDetail), then /queue and
/history, driven by websocket events. Remove wrapHostQueuePrompt.
- Add opt-in Majoor.Integration.HideNativeAssetsTab setting that hides
ComfyUI's native Assets sidebar tab through the official
getSidebarTabs/unregisterSidebarTab API and restores it when disabled.
- Fix all 913 type errors in tsconfig.test.json and type-check tests in
CI; drop a duplicated `stubs` key in asset_card_inner test; make
addToastHistory's type argument optional for the object form.
- Update audit report, changelog, API reference and env var docs.
- hostAdapter: serialize the root graph instead of calling the now-async
graphToPrompt() synchronously (avoids exporting only the open subgraph
and an unhandled rejection); read dirty state from the workflow store.
- Bump @comfyorg/comfyui-frontend-types to ^1.60.0: 1.57.3 was published
without index.d.ts, so the official ComfyApp type was silently lost.
- Backend: typed aiohttp request keys (web.RequestKey when available)
to silence NotAppKeyWarning on aiohttp >= 3.13 and avoid key clashes.
- Fix ruff import-order failures; rebuild dist bundle.
- Add docs/COMFYUI_INTEGRATION_AUDIT.md with remaining conflict risks
and an integration roadmap.
A global mjr:reload-grid event was handled by both the panel and the assets query controller, so each request reloaded the grid twice. Only the controller handles it now, and it skips the reload while DB maintenance is active.
These tests construct a bare FloatingViewer and call
_renderGenInfoSidebar() directly to check rendered content, so they
need to opt into the sidebar now that _genSidebarEnabled defaults to
false instead of asserting on it implicitly.
VIEWER_PAUSE_DURING_EXECUTION now defaults to false, matching the
settings toggle's own (already-false) displayed default. The Floating
Viewer's gen info sidebar no longer opens automatically; it stays
available on demand via its existing toggle button.
- useGridLoader's pagehide listener is now removed in dispose(), so
remounting the grid host (scope switches, feed panel) no longer
accumulates one bound listener per instance for the rest of the
page session.
- SearchBar's autocomplete now drops stale responses via a sequence
guard, so an earlier request resolving after a later one can no
longer overwrite the suggestions for the current query.
The frontend called checkMajoorVersion() unconditionally on startup,
and the backend /mjr/am/releases endpoint made outbound requests to
api.github.com to power it. This violates the no-internet-requests
policy for core ComfyUI code, even for update checks framed as
diagnostic or opt-out. Removes the endpoint, the frontend check, the
now-dead version-update badge dot in HeaderSection.vue, and associated
tests/docs.
Exclude development-only content from Registry packages while retaining runtime
docs and vendor assets. Centralize environment access and media process execution,
validate filesystem inputs, and restrict nested media protocols.
Route update checks through the backend GitHub boundary and read version metadata
without spawning Git. Preserve annotated-tag priority over lightweight nightly
tags, including packed refs, with regression coverage. Rebuild the frontend bundle.
Validation: Python tests with coverage, JS tests, targeted media/version regression
tests, and the canonical Python quality gate.
Types every remaining any in AssetsGrid.vue (its own state + the
methods matching MjrAssetsGridExpose's signatures) and
VirtualAssetGridHost.vue's props (scrollElement as a real Ref/element
union, onCardRendered/onCardDblclick with their actual call-site
argument shapes using MjrAssetLike).
ui/vue any count: 78 -> 1. The one survivor is MjrGridContainer's
`Record<string, any>` index signature (VirtualAssetGridHost.vue) --
already documented in a comment as deliberate: ~30 heterogeneous
_mjr* properties (functions, Maps, strings, booleans) legacy
controller code reads/writes on the grid container DOM node, where an
`unknown` index signature would force a cast at every one of those
call sites for no real safety gain.
Build + full vitest suite (831 tests) pass. Live-verified against the
running ComfyUI instance.
App.vue's panel-runtime dispose handle, ViewerPortal's viewer-instance
handle, SummaryBarSection's updateSummaryBar/setFolderBreadcrumb params
(now reusing its own BreadcrumbAction interface instead of any), and
SearchBar's similarPopoverRef (new MjrSimilarSearchPopoverExpose in
componentExposes.d.ts) + metadata-keys cache all get real shapes.
Build + full vitest suite (831 tests) pass.
The specific ask from the last audit follow-up: CollectionsPopover.vue's
collections list, AI cluster results, and smart-suggestion "ideas" now
use MjrCollectionItem/MjrCluster/MjrSmartCollectionIdea from
ui/types/collections.d.ts instead of any. withBusyAction is now generic
over its wrapped function's argument tuple instead of any[], so the
per-callback argument types (no args, MjrCollectionItem, etc.) still
flow through instead of being erased.
Build + full vitest suite (831 tests) pass. Live-verified against the
running ComfyUI instance.
GenerationInputThumb's dynamic floatingViewerManager import, WorkflowPickerDialog's
workflow list items, AssetSidebarContent's onUpdate callback, and
AddToCollectionMenu's collections list + addAssetsToCollection() result
all get real shapes instead of any. Adds ui/types/collections.d.ts
(MjrCollectionItem, MjrAddCollectionResult, MjrSmartCollectionIdea,
MjrCluster) shared between AddToCollectionMenu.vue and the next
CollectionsPopover.vue batch.
Build + full vitest suite (831 tests) pass.
Ewald