From 247c9bb6d42b2468f62f551a4984af9c22ae34fa Mon Sep 17 00:00:00 2001 From: snomiao Date: Mon, 20 Jan 2025 22:53:57 +0000 Subject: [PATCH 1/3] chore(publish): update GitHub Actions workflow for node publishing - Add permissions for writing issues - Restrict job execution to specific repository owner - Update action version to v1 for node publishing --- .github/workflows/publish.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 828f300..97d21b2 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -7,15 +7,19 @@ on: paths: - "pyproject.toml" +permissions: + issues: write + jobs: publish-node: name: Publish Custom Node to registry runs-on: ubuntu-latest + if: ${{ github.repository_owner == 'MrForExample' }} steps: - name: Check out code uses: actions/checkout@v4 - name: Publish Custom Node - uses: Comfy-Org/publish-node-action@main + uses: Comfy-Org/publish-node-action@v1 with: ## Add your own personal access token to your Github Repository secrets and reference it here. - personal_access_token: ${{ secrets.REGISTRY_ACCESS_TOKEN }} \ No newline at end of file + personal_access_token: ${{ secrets.REGISTRY_ACCESS_TOKEN }} From 578ae2cbbcd18ea2264dd0e98002a4f4789dab74 Mon Sep 17 00:00:00 2001 From: Robin Huang Date: Tue, 4 Feb 2025 14:40:31 -0800 Subject: [PATCH 2/3] Change node id name. --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index ddcf166..1d95c31 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,5 +1,5 @@ [project] -name = "comfyui-3d-pack" +name = "ComfyUI-3D-Pack" description = "Make ComfyUI generates 3D assets as good & convenient as it generates image/video!" version = "0.1.3" license = { file = "LICENSE" } From a9d45620c6e9692e01a8e1315bc98ca7d59175a1 Mon Sep 17 00:00:00 2001 From: sqlpxc Date: Thu, 13 Feb 2025 23:48:10 +0800 Subject: [PATCH 3/3] fix wsl2 eglInitialize() failed --- Gen_3D_Modules/Unique3D/mesh_reconstruction/render.py | 4 ++-- Gen_3D_Modules/Unique3D/scripts/project_mesh.py | 2 +- MVs_Algorithms/FlexiCubes/flexicubes_renderer.py | 2 +- nodes.py | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Gen_3D_Modules/Unique3D/mesh_reconstruction/render.py b/Gen_3D_Modules/Unique3D/mesh_reconstruction/render.py index 23707d8..0fb93a0 100644 --- a/Gen_3D_Modules/Unique3D/mesh_reconstruction/render.py +++ b/Gen_3D_Modules/Unique3D/mesh_reconstruction/render.py @@ -12,11 +12,11 @@ def _warmup(glctx, device=None): tri = tensor([[0, 1, 2]], dtype=torch.int32) dr.rasterize(glctx, pos, tri, resolution=[256, 256]) -glctx = dr.RasterizeGLContext(output_db=False, device="cuda") +glctx = dr.RasterizeCudaContext(device="cuda") class NormalsRenderer: - _glctx:dr.RasterizeGLContext = None + _glctx:dr.RasterizeCudaContext = None def __init__( self, diff --git a/Gen_3D_Modules/Unique3D/scripts/project_mesh.py b/Gen_3D_Modules/Unique3D/scripts/project_mesh.py index 43950dd..1782e07 100644 --- a/Gen_3D_Modules/Unique3D/scripts/project_mesh.py +++ b/Gen_3D_Modules/Unique3D/scripts/project_mesh.py @@ -68,7 +68,7 @@ def _warmup(glctx, device=None): class Pix2FacesRenderer: def __init__(self, device="cuda"): - self._glctx = dr.RasterizeGLContext(output_db=False, device=device) + self._glctx = dr.RasterizeCudaContext(device=device) self.device = device _warmup(self._glctx, device) diff --git a/MVs_Algorithms/FlexiCubes/flexicubes_renderer.py b/MVs_Algorithms/FlexiCubes/flexicubes_renderer.py index 2ca47c8..6453c68 100644 --- a/MVs_Algorithms/FlexiCubes/flexicubes_renderer.py +++ b/MVs_Algorithms/FlexiCubes/flexicubes_renderer.py @@ -43,7 +43,7 @@ class FlexiCubesRenderer: ''' v_pos_clip = util.xfm_points(mesh.vertices.unsqueeze(0), mvp) # Rotate it to camera coordinates rast, db = dr.rasterize( - dr.RasterizeGLContext(), v_pos_clip, mesh.faces.int(), iter_res) + dr.RasterizeCudaContext(), v_pos_clip, mesh.faces.int(), iter_res) alpha_index = rast[..., -1:] > 0 inv_alpha_index = rast[..., -1:] <= 0 diff --git a/nodes.py b/nodes.py index b527f33..30b0227 100644 --- a/nodes.py +++ b/nodes.py @@ -987,7 +987,7 @@ class Mesh_Orbit_Renderer: "render_background_color_r": ("FLOAT", {"default": 0.0, "min": 0.0, "max": 1.0, "step": 0.001}), "render_background_color_g": ("FLOAT", {"default": 0.0, "min": 0.0, "max": 1.0, "step": 0.001}), "render_background_color_b": ("FLOAT", {"default": 0.0, "min": 0.0, "max": 1.0, "step": 0.001}), - "force_cuda_rasterize": ("BOOLEAN", {"default": False},), + "force_cuda_rasterize": ("BOOLEAN", {"default": True},), }, "optional": { @@ -1302,7 +1302,7 @@ class Fitting_Mesh_With_Multiview_Images: "ms_ssim_loss_weight": ("FLOAT", {"default": 0.5, "min": 0.0, "max": 1.0, "step": 0.01}), "remesh_after_n_iteration": ("INT", {"default": 512, "min": 128, "max": 100000}), "invert_background_probability": ("FLOAT", {"default": 0.5, "min": 0.0, "max": 1.0, "step": 0.1}), - "force_cuda_rasterize": ("BOOLEAN", {"default": False},), + "force_cuda_rasterize": ("BOOLEAN", {"default": True},), }, }