Reithan
a70d1d09bb
## Summary Fixes issue #20 where NRS would fail with `RuntimeError: "Could not determine prediction type for this model"` when using certain samplers like WanKSamplerAdvanced and RES4LYF ClownsharKsampler. ## Changes Made - **Enhanced prediction type mapping**: Added support for FLOW models (`"flow"`, `"wan"`, `"const"` → `PredictionType.EPS`) - **Improved model introspection**: Added `model_sampling` class inspection and `model.model.model_type` enum detection - **Graceful fallback**: Replaced RuntimeErrors with safe EPS defaults when prediction type cannot be determined - **Better debugging**: Added warning logs when using fallback prediction types - **Documentation**: Updated README with sampler compatibility information - **Version bump**: 0.7.3 → 0.7.4 ## Technical Details The issue occurred because WAN and similar samplers use **FLOW model types** (ModelType.FLOW) that implement the CONST prediction class, which are fundamentally different from traditional EPS/V-prediction models. The original code only checked for string attributes and failed to recognize these newer model architectures. This fix follows the established pattern from commitsfc38b5c(flux support) andba145c4(chroma support) while adding robust fallback mechanisms. ## Testing - ✅ Manual integration testing planned with WanKSamplerAdvanced - ✅ Manual integration testing planned with RES4LYF ClownsharKsampler - ✅ Backwards compatibility maintained for existing samplers - ✅ Enhanced logging for debugging unrecognized models ## Risk Assessment **Low Risk**: Only enhances existing detection logic without changing core mathematical operations. Adds fallback instead of removing functionality. Closes #20 --------- Signed-off-by: Reithan <bo122081@hotmail.com>
17 lines
698 B
TOML
17 lines
698 B
TOML
[project]
|
|
name = "negative_rejection_steering"
|
|
description = "NRS seeks to replace the 'naive' linear interpolation of Classifier Free Guidance with a more nuanced and composable steering of the generation process with better mathematical basis."
|
|
authors = [{name = "Bryan O'Malley", email = "bo122081@hotmail.com"}]
|
|
version = "0.7.4"
|
|
license = {file = "LICENSE"}
|
|
readme = "README.md"
|
|
|
|
[project.urls]
|
|
Repository = "https://github.com/Reithan/negative_rejection_steering"
|
|
# Used by Comfy Registry https://comfyregistry.org
|
|
|
|
[tool.comfy]
|
|
PublisherId = "reithan"
|
|
DisplayName = "Negative Rejection Steering"
|
|
Icon = "https://raw.githubusercontent.com/Reithan/negative_rejection_steering/main/icon.png"
|