4 Commits
Author SHA1 Message Date
asagi4 181641ca04 v0.4.0 2025-05-03 21:12:06 +03:00
asagi4 20dffb1fd0 Merge pull request #13 from ComfyNodePRs/update-publish-yaml
Update Github Action for Publishing to Comfy Registry
2025-02-24 09:21:40 +02:00
snomiao 4907ef1b6f chore(publish): update GitHub Actions workflow for node publishing
- Add permissions for issue writing
- Update action version to v1 for publish-node-action
- Add condition to run job only for 'asagi4' repository owner
2025-01-20 21:33:44 +00:00
asagi4 8fc3b008ad Implement adaptive projected guidance, with adaptive momentum stolen from
https://github.com/MythicalChu/ComfyUI-APG_ImYourCFGNow

I'm not sure which type of model output the algorithm works better with,
so pick your preferred one by setting the mode to "normal" or "denoised"

Fixes #11

Fix Adaptive momentum; was using the momentum as CFG
2024-11-23 19:32:59 +02:00
5 changed files with 108 additions and 3 deletions
+5 -1
View File
@@ -7,15 +7,19 @@ on:
paths: paths:
- "pyproject.toml" - "pyproject.toml"
permissions:
issues: write
jobs: jobs:
publish-node: publish-node:
name: Publish Custom Node to registry name: Publish Custom Node to registry
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: ${{ github.repository_owner == 'asagi4' }}
steps: steps:
- name: Check out code - name: Check out code
uses: actions/checkout@v4 uses: actions/checkout@v4
- name: Publish Custom Node - name: Publish Custom Node
uses: Comfy-Org/publish-node-action@main uses: Comfy-Org/publish-node-action@v1
with: with:
## Add your own personal access token to your Github Repository secrets and reference it here. ## Add your own personal access token to your Github Repository secrets and reference it here.
personal_access_token: ${{ secrets.REGISTRY_ACCESS_TOKEN }} personal_access_token: ${{ secrets.REGISTRY_ACCESS_TOKEN }}
+1 -1
View File
@@ -4,7 +4,7 @@ An implementation of adaptive guidance for ComfyUI
See https://bcv-uniandes.github.io/adaptiveguidance-wp/ See https://bcv-uniandes.github.io/adaptiveguidance-wp/
Import [this workflow](workflows/AGExample.json?raw=1) into ComfyUI to compare Adaptive Guidance vs. normal CFG. Import [this workflow](example_workflows/AGExample.json?raw=1) into ComfyUI to compare Adaptive Guidance vs. normal CFG.
## What ## What
+101
View File
@@ -187,9 +187,110 @@ class PerpNegAGGuider:
return (g,) return (g,)
def project(a, b):
dtype = a.dtype
a, b = a.double(), b.double()
b = torch.nn.functional.normalize(b, dim=[-1, -2, -3])
a_par = (a * b).sum(dim=[-1, -2, -3], keepdim=True) * b
a_orth = a - a_par
return a_par.to(dtype), a_orth.to(dtype)
class AdaptiveProjectedGuidanceFunction:
def __init__(self, momentum, eta, norm_threshold, adaptive_momentum=0, mode="normal"):
self.eta = eta
self.norm_threshold = norm_threshold
self.current_step = 999.0
self.init_momentum = momentum
self.momentum = momentum
self.running_average = 0.0
self.mode = mode
self.adaptive_momentum = adaptive_momentum
def __call__(self, args):
if "denoised" == self.mode:
cond = args["cond_denoised"]
uncond = args["uncond_denoised"]
else:
cond = args["cond"]
uncond = args["uncond"]
cfg_scale = args["cond_scale"]
sigma = args["sigma"][0].item()
step = args["model"].model_sampling.timestep(args["sigma"])[0].item()
x_orig = args["input"]
if self.mode == "vpred":
sigma = step
x = x_orig / (sigma * sigma + 1.0)
cond = ((x - (x_orig - cond)) * (sigma**2 + 1.0) ** 0.5) / (sigma)
uncond = ((x - (x_orig - uncond)) * (sigma**2 + 1.0) ** 0.5) / (sigma)
if self.current_step < step:
self.current_step = 999.0
self.running_average = 0.0
self.momentum = self.init_momentum
else:
scale = self.init_momentum
if self.adaptive_momentum > 0:
scale -= scale * (self.adaptive_momentum**4) * (1000 - step)
if self.init_momentum < 0 and scale > 0:
scale = 0
elif self.init_momentum > 0 and scale < 0:
scale = 0
self.momentum = scale
self.current_step = step
diff = cond - uncond
new_average = self.momentum * self.running_average
self.running_average = diff + new_average
diff = self.running_average
if self.norm_threshold > 0.0:
diff_norm = diff.norm(p=2, dim=[-1, -2, -3], keepdim=True)
scale_factor = torch.minimum(torch.ones_like(diff), self.norm_threshold / diff_norm)
diff = diff * scale_factor
diff_parallel, diff_orthogonal = project(diff, cond)
pred = cond + (cfg_scale - 1) * (diff_orthogonal + self.eta * diff_parallel)
if "denoised" == self.mode:
pred = x_orig - pred
elif "vpred" == self.mode:
pred = x_orig - (x - pred * sigma / (sigma * sigma + 1.0) ** 0.5)
return pred
class AdaptiveProjectedGuidance:
@classmethod
def INPUT_TYPES(s):
return {
"required": {"model": ("MODEL",)},
"optional": {
"momentum": ("FLOAT", {"default": 0.5, "min": -1.0, "max": 1.0, "step": 0.01}),
"eta": ("FLOAT", {"default": 1, "min": 0.0, "max": 1.0, "step": 0.01}),
"norm_threshold": ("FLOAT", {"default": 15.0, "min": 0.0, "max": 50.0, "step": 0.1}),
"mode": (["normal", "denoised", "vpred"],),
"adaptive_momentum": ("FLOAT", {"default": 0.18, "min": 0, "max": 1.0, "step": 0.01}),
},
}
RETURN_TYPES = ("MODEL",)
FUNCTION = "apply"
CATEGORY = "_for_testing"
def apply(self, model, momentum=0.5, eta=1.0, norm_threshold=15.0, mode="normal", adaptive_momentum=0.18):
fn = AdaptiveProjectedGuidanceFunction(momentum, eta, norm_threshold, adaptive_momentum, mode)
m = model.clone()
m.set_model_sampler_cfg_function(fn)
return (m,)
NODE_CLASS_MAPPINGS = { NODE_CLASS_MAPPINGS = {
"AdaptiveGuidance": AdaptiveGuidanceGuider, "AdaptiveGuidance": AdaptiveGuidanceGuider,
"PerpNegAdaptiveGuidanceGuider": PerpNegAGGuider, "PerpNegAdaptiveGuidanceGuider": PerpNegAGGuider,
"AdaptiveProjectedGuidance": AdaptiveProjectedGuidance,
} }
NODE_DISPLAY_NAME_MAPPINGS = { NODE_DISPLAY_NAME_MAPPINGS = {
+1 -1
View File
@@ -1,7 +1,7 @@
[project] [project]
name = "comfyui-adaptive-guidance" name = "comfyui-adaptive-guidance"
description = "An implementation of adaptive guidance for ComfyUI\nSee https://bcv-uniandes.github.io/adaptiveguidance-wp/" description = "An implementation of adaptive guidance for ComfyUI\nSee https://bcv-uniandes.github.io/adaptiveguidance-wp/"
version = "0.3.1" version = "0.4.0"
license = { text = "GNU General Public License v3.0" } license = { text = "GNU General Public License v3.0" }
[project.urls] [project.urls]