ausboss
0e4749db6b
Five things surfaced by release testing. Node search: ComfyUI's search dialog cuts at 64 results and ranks by [match tier, global popularity, name length], where tier 1 needs the name to START with what was typed. Popularity is a fixed global table in which every node from a new pack scores zero, so tier is the only lever. As "Refine Mask" this node came 121st for "mask" and was never on screen. Renamed to Mask Refine, which is 15th, and kept "refine mask" as an alias. The mapping key is untouched, so saved workflows are unaffected. Aliases alone cannot fix this: the frontend indexes them but drops them from the tier scoring because they are a list rather than a string, so they decide whether a node is findable, not where it lands. Previews: Mask Refine, LaMa Inpaint and Select Frame showed whatever fed their input, which is nothing when a segmentation node is upstream - Mask Refine's panel was blank however the mask turned out. Each now returns its result as a preview and the panel shows that, falling back to the input before the first run. A node does not need to be an OUTPUT_NODE for this; returning a ui payload is enough. ComfyUI's own preview for these nodes is stood down so the picture appears once, in the panel, rather than also underneath the node. That also fixes LaMa finishing a single image with an empty panel: frame previews were only attached for batches over one frame, on the assumption that one image would preview through the output path, which a non-output node does not have. Mask Refine opens on expand and blur with the other five behind MORE. Hidden widgets keep their values and their saved positions. AUTO sets both from the mask's size, scaled off the 8/4 hand-tuned for the watermark workflow at 576px, because a feather is a fraction of the picture rather than a fixed pixel count. Save Video gains nvenc h264/h265, webm av1, ProRes mov, lossless ffv1 mkv, gif and webp, plus pingpong and save_metadata. Every format is encoded and read back in the tests rather than trusted from its table row. fps steps in whole frames but stays FLOAT: an INT would refuse Load Video's fps link and round 29.97 to 30, drifting picture off audio. mov files now carry the embedded workflow, which they silently did not. The reload button is gone - it only re-fetched what was already on screen. Not done: Select Frame's preview updates on a run, not as the number changes. Seeking to a frame needs the source fps, which the browser never learns, so live scrubbing needs a server route - the surface Frame Chooser was just demoted for.
31 lines
1.4 KiB
JavaScript
31 lines
1.4 KiB
JavaScript
// Starting expand/blur for a mask, picked from the picture's size.
|
|
//
|
|
// A feather is a fraction of the subject, not a fixed number of pixels: the
|
|
// 8 px grow that covers a watermark's antialiased rim on a 576-tall clip is
|
|
// a smear on a 128 px thumbnail and does nothing at all on a 4K plate. The
|
|
// ladder below is anchored on the value that was tuned by hand for the video
|
|
// watermark workflow — 8 px of expand, 4 of blur, on a 576x1024 clip — and
|
|
// scales it by the SHORT edge, which is what "how big is this picture"
|
|
// actually means for a mask.
|
|
//
|
|
// These are a starting point to nudge, never a correct answer: how far a
|
|
// mask has to grow depends on how tight the segmentation was, and nothing
|
|
// here can see that.
|
|
//
|
|
// No DOM and no ComfyUI imports, so node:test covers it directly.
|
|
|
|
const REFERENCE_SHORT_EDGE = 576;
|
|
const REFERENCE_EXPAND = 8;
|
|
const MIN_EXPAND = 1;
|
|
const MAX_EXPAND = 64;
|
|
|
|
export function autoMaskValues(width, height) {
|
|
const shortEdge = Math.min(Number(width) || 0, Number(height) || 0);
|
|
if (!(shortEdge > 0)) return null;
|
|
const scaled = Math.round((shortEdge * REFERENCE_EXPAND) / REFERENCE_SHORT_EDGE);
|
|
const expand = Math.max(MIN_EXPAND, Math.min(MAX_EXPAND, scaled));
|
|
// Half the grow: enough to soften the edge the grow just created without
|
|
// washing away the coverage it added.
|
|
return { expand, blur: Math.round(expand * 5) / 10 };
|
|
}
|