The audit compared every node against ComfyUI core and the major packs; this lands its outcomes in one branch. On-node visual editing (the old Codex-pack interaction, rebuilt): - New Load Image + Pad: image loader with whole-edge pad dragging on the node canvas, align-to-multiple rounding, and a megapixel target that rescales the source before padding so the mask seam stays binary. - Pad Image gains the same handle canvas, fed by an execution-time snapshot of its input; wireframe with diagnostic empty states before the first run. Widgets, outputs, and saved workflows unchanged. - Image Crop + Rotate + Pad's compact panel is now a live stage - crop, pad, and rotate handles on the node, one shared implementation with the full-screen editor so the two surfaces cannot drift. Feature gaps closed against the ecosystem: - Crop For Inpaint: target_megapixels, selectable rescale_algorithm (recorded in the stitcher for the paste-back), and extend_* inputs that grow the frame itself for outpainting. - Save Video: format choice - mp4 h264, mp4 h265, webm vp9 with Opus (resampled to 48 kHz); CRF drives all three. - Load Video: every_nth thinning (fps output divides to match) and a max_frames cap that ends the decode early. - LoRA Loader: saved stack templates behind a bar button, and a console warning when a LoRA's base-model family disagrees with the checkpoint. - LM Studio Chat: history in/out for multi-turn chains and a json_schema widget for structured replies. - Drop Shadow: multiply blend and a shadow_mask output. Align Image: offset outputs for un-aligning after sampling. Color Match: first_frame reference mode as a one-node video flicker fix. Removed (backed up in git history): Select Frame Range and the Video Bundle family - core ImageFromBatch and the core VIDEO wire now cover both jobs. Dead NODE_ID module variables cleaned out of every node file. 455 Python tests, 216 JS tests, validate_nodes.py green on 19 node files.
113 lines
5.1 KiB
JavaScript
113 lines
5.1 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
|
|
import {
|
|
canvasLocalPoint,
|
|
cropHandleCenters,
|
|
nearestHandle,
|
|
paddingHandleCenters,
|
|
resetTransformValues,
|
|
resizeCrop,
|
|
resolveCrop,
|
|
resolvePadding,
|
|
rotatedSize,
|
|
sourceChanged,
|
|
stageHandleLayout,
|
|
stageHeightForWidth,
|
|
zoomAround,
|
|
} from "../js/shared/transform_geometry.mjs";
|
|
|
|
test("rotated size handles positive and negative angles", () => {
|
|
assert.deepEqual(rotatedSize(100, 50, 90), { width: 50, height: 100 });
|
|
assert.deepEqual(rotatedSize(100, 50, -90), { width: 50, height: 100 });
|
|
// Mixed odd/even sides hit Pillow's exact transpose fast path.
|
|
assert.deepEqual(rotatedSize(2, 3, -90), { width: 3, height: 2 });
|
|
});
|
|
|
|
test("rotated size matches Pillow expand output exactly", () => {
|
|
// Expected values generated with Pillow's Image.rotate(expand=True); see
|
|
// the note on rotatedSize. The old width*cos+height*sin formula was 1px
|
|
// short on most free angles (e.g. 512@45 gave 725, Pillow produces 726).
|
|
assert.deepEqual(rotatedSize(512, 512, 45), { width: 726, height: 726 });
|
|
assert.deepEqual(rotatedSize(512, 512, -12.5), { width: 612, height: 612 });
|
|
assert.deepEqual(rotatedSize(512, 512, 179.9), { width: 514, height: 514 });
|
|
assert.deepEqual(rotatedSize(1920, 1080, 15), { width: 2136, height: 1542 });
|
|
assert.deepEqual(rotatedSize(1920, 1080, 60), { width: 1896, height: 2204 });
|
|
});
|
|
|
|
test("crop clamps and honors ratios", () => {
|
|
assert.deepEqual(resolveCrop({ crop_x: 95, crop_y: 45, crop_width: 99, crop_height: 99, crop_aspect_ratio: "free" }, { width: 100, height: 50 }), { x: 95, y: 45, width: 5, height: 5 });
|
|
assert.deepEqual(resolveCrop({ crop_x: 0, crop_y: 0, crop_width: 0, crop_height: 0, crop_aspect_ratio: "16:9" }, { width: 100, height: 100 }), { x: 0, y: 0, width: 100, height: 56 });
|
|
});
|
|
|
|
test("canvas multiple adds only right and bottom", () => {
|
|
assert.deepEqual(resolvePadding({ pad_left: 0, pad_top: 0, pad_right: 0, pad_bottom: 0, canvas_multiple: 8 }, { width: 101, height: 99 }), { left: 0, top: 0, right: 3, bottom: 5, outputWidth: 104, outputHeight: 104 });
|
|
});
|
|
|
|
test("handle priority and closest distance are deterministic", () => {
|
|
const selection = nearestHandle({ x: 20, y: 20 }, [
|
|
{ kind: "padding", priority: 1, radius: 30, handles: [{ name: "pad_left", x: 20, y: 20 }] },
|
|
{ kind: "crop", priority: 2, radius: 30, handles: [{ name: "nw", x: 20, y: 20 }] },
|
|
]);
|
|
assert.equal(selection.kind, "padding");
|
|
});
|
|
|
|
test("crop resize never leaves the source", () => {
|
|
const resized = resizeCrop({ x: 10, y: 10, width: 40, height: 30 }, "se", 1000, 1000, { width: 100, height: 80 });
|
|
assert.deepEqual(resized, { x: 10, y: 10, width: 90, height: 70 });
|
|
});
|
|
|
|
test("coordinate conversion accounts for CSS scaling", () => {
|
|
const canvas = { clientWidth: 400, clientHeight: 200, getBoundingClientRect: () => ({ left: 10, top: 20, width: 200, height: 100 }) };
|
|
assert.deepEqual(canvasLocalPoint(canvas, { clientX: 110, clientY: 70 }), { x: 200, y: 100 });
|
|
});
|
|
|
|
test("zoom remains anchored under the pointer", () => {
|
|
assert.deepEqual(zoomAround({ zoom: 1, panX: 0, panY: 0 }, 2, { x: 100, y: 50 }), { zoom: 2, panX: -100, panY: -50 });
|
|
});
|
|
|
|
test("panel stage height tracks node width within its clamps", () => {
|
|
assert.equal(stageHeightForWidth(100), 200); // floor
|
|
assert.equal(stageHeightForWidth(330), 218);
|
|
assert.equal(stageHeightForWidth(500), 330);
|
|
assert.equal(stageHeightForWidth(2000), 520); // ceiling
|
|
assert.equal(stageHeightForWidth(undefined), 200);
|
|
});
|
|
|
|
test("handle layout keeps the editor's classic geometry on large stages", () => {
|
|
// A full-screen editor stage must render exactly as before the panel
|
|
// re-home: classic offsets and the min(90, w/10, h/10) margin.
|
|
const layout = stageHandleLayout(1246, 758);
|
|
assert.equal(layout.padOffset, 38);
|
|
assert.equal(layout.rotateArm, 34);
|
|
assert.ok(Math.abs(layout.margin - 75.8) < 1e-9);
|
|
});
|
|
|
|
test("handle layout pulls handles inward but keeps them visible on the panel", () => {
|
|
const layout = stageHandleLayout(312, 214);
|
|
assert.ok(layout.padOffset < 38 && layout.padOffset >= 16);
|
|
assert.ok(layout.rotateArm < 34 && layout.rotateArm >= 14);
|
|
// The fit margin always covers the outboard handles: the pad diamond's
|
|
// half-diagonal (~11px) past its offset, the knob radius (13px) past the
|
|
// rotate arm — otherwise the panel would clip its own controls.
|
|
assert.ok(layout.margin >= layout.padOffset + 11);
|
|
assert.ok(layout.margin >= layout.rotateArm + 13);
|
|
});
|
|
|
|
test("handle layout stays finite on degenerate stage sizes", () => {
|
|
const layout = stageHandleLayout(0, 0);
|
|
assert.ok(Number.isFinite(layout.margin));
|
|
assert.ok(layout.padOffset >= 16 && layout.rotateArm >= 14);
|
|
});
|
|
|
|
test("reset and source change restore identity including timeline", () => {
|
|
const reset = resetTransformValues(true);
|
|
assert.equal(reset.canvas_multiple, 1);
|
|
assert.equal(reset.pad_bottom, 0);
|
|
assert.equal(reset.feather, 24); // feather defaults on; no-op until padding/rotation exists
|
|
assert.equal(reset.frame_index, 0);
|
|
assert.equal(sourceChanged("a", "b", true), true);
|
|
assert.equal(sourceChanged("a", "b", false), false);
|
|
assert.equal(sourceChanged("a", "a", true), false);
|
|
});
|