nodes/darth-veitcher-comfydv
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #18 from darth-veitcher/chore/finish-llm-provider-abstraction-epic

Browse Source 
chore: finish llm-provider-abstraction epic
This commit is contained in:
James Veitch
2026-07-11 21:55:08 +01:00
committed by GitHub
parent 27b26ec7a4 2df9e87838
commit 834ae3e9e3
4 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ROADMAP.md
+2 -2
View File
@@ -14,11 +14,11 @@ gantt
section Active
llama.cpp Model Integration :active, llamacpp-integration, 2026-07-11, 7d
LLM Provider Abstraction :active, llm-provider-abstraction, 2026-07-11, 7d
ComfyUI UX Polish & Manager Compatibility :active, ux-and-install, 2026-06-28, 21d
section Done
BEACON Bootstrap :done, beacon-bootstrap, 2026-07-11, 7d
LLM Provider Abstraction :done, llm-provider-abstraction, 2026-07-11, 7d
Logging Modernisation :done, logging-modernisation, 2026-07-11, 7d
Ollama Model Integration :done, ollama-integration, 2026-07-11, 7d
@@ -29,9 +29,9 @@ gantt
| Epic | Title | Status | Specs | Fidelity |
|---|---|---|---|---|
| [llamacpp-integration](project-management/Roadmap/epics/llamacpp-integration.md) | llama.cpp Model Integration | Active | 1/1 shipped | S+ A+ T:96% |
| [llm-provider-abstraction](project-management/Roadmap/epics/llm-provider-abstraction.md) | LLM Provider Abstraction | Active | 1/1 shipped | S+ A+ T:58% |
| [ux-and-install](project-management/Roadmap/epics/ux-and-install.md) | ComfyUI UX Polish & Manager Compatibility | Active | 1/4 shipped | S+ A+ T:100% |
| [beacon-bootstrap](project-management/Roadmap/epics/archive/beacon-bootstrap.md) | BEACON Bootstrap | Done | — | S? A? T:- |
| [llm-provider-abstraction](project-management/Roadmap/epics/archive/llm-provider-abstraction.md) | LLM Provider Abstraction | Done | 1/1 shipped | S+ A+ T:58% |
| [logging-modernisation](project-management/Roadmap/epics/archive/logging-modernisation.md) | Logging Modernisation | Done | 1/1 shipped | S+ A+ T:100% |
| [ollama-integration](project-management/Roadmap/epics/archive/ollama-integration.md) | Ollama Model Integration | Done | 1/1 shipped | S+ A+ T:100% |
project-management/Roadmap/README.md
+2 -2
View File
@@ -26,8 +26,8 @@
- **BEACON bootstrap** — `epics/archive/beacon-bootstrap.md` — ✅ DONE — BEACON framework wired up; problem statement, constitution, roadmap, and ADR template populated; quality gates clean
- **Logging modernisation** — `epics/logging-modernisation.md` — ✅ DONE — stdlib logging, NullHandler, silent-by-default; colorama/rich/termcolor removed; 11 tests
- **ComfyUI UX Polish & Manager Compatibility** — `epics/ux-and-install.md` — 🔄 ACTIVE — Fix installation, core UX bugs (debounce, connection drops, alert dialogs), correctness bugs (class-level mutation, IS_CHANGED, seed=0), and metadata drift
- **LLM Provider Abstraction** — `epics/llm-provider-abstraction.md` — 🔄 ACTIVE — Introduce a shared `LLMProvider` protocol (list/load/unload/chat/structured-output) and generic ComfyUI nodes; migrate the existing Ollama integration onto it (ADR-007, supersedes ADR-006)
- **llama.cpp Model Integration** — `epics/llamacpp-integration.md` — 📋 PROPOSED — Add a `LlamaCppProvider` implementing the shared protocol via llama-server's router mode; depends on LLM Provider Abstraction landing first (GitHub issue #15)
- **LLM Provider Abstraction** — `epics/archive/llm-provider-abstraction.md` — ✅ DONE — shared `LLMProvider` protocol (list/load/unload/chat/structured-output) and generic ComfyUI nodes; Ollama integration migrated onto it (ADR-007, supersedes ADR-006); merged via PR #17
- **llama.cpp Model Integration** — `epics/llamacpp-integration.md` — 🔄 ACTIVE — Add a `LlamaCppProvider` implementing the shared protocol via llama-server's router mode (GitHub issue #15); dependency on LLM Provider Abstraction now satisfied
For the live rollup (specs per epic, % tasks complete, last-commit age):
project-management/Roadmap/epics/llm-provider-abstraction.md → project-management/Roadmap/epics/archive/llm-provider-abstraction.md
+1 -1
View File
@@ -1,7 +1,7 @@
# Epic: LLM Provider Abstraction
## Status
Active — started 2026-07-11
Done — completed 2026-07-11
## Why now
project-management/Roadmap/epics/llamacpp-integration.md
+8 -6
View File
@@ -20,12 +20,14 @@ ComfyUI nodes.
## Dependencies
Depends on the `llm-provider-abstraction` epic landing first. This epic's
`LlamaCppProvider` implements the `LLMProvider` protocol that epic defines,
and its `LlamaCppClient` node emits the same `LLM_CLIENT` socket type the
generic `ChatCompletion`/`LLMModelSelector`/`LLMLoadModel`/`LLMUnloadModel`
nodes already consume — none of those node classes are touched by this
epic.
Depended on the `llm-provider-abstraction` epic landing first — **satisfied**
2026-07-11, merged via [PR #17](https://github.com/darth-veitcher/comfydv/pull/17)
(`project-management/Roadmap/epics/archive/llm-provider-abstraction.md`).
This epic's `LlamaCppProvider` implements the `LLMProvider` protocol that
epic defined, and its `LlamaCppClient` node emits the same `LLM_CLIENT`
socket type the generic `ChatCompletion`/`LLMModelSelector`/`LLMLoadModel`/
`LLMUnloadModel` nodes already consume — none of those node classes are
touched by this epic.
## Specs