James VeitchandClaude Sonnet 5
1879ca2265
Rewrote tests/test_ollama.py against a _FakeProvider double per atomic-cutover-plan.md's D4/D5 test-layer split: node-contract/delegation tests only, no aiohttp/_post_json mocking (that lives in test_ollama_provider.py now). 98 unit tests, collapsed from the original ~125 largely mechanical monkeypatch-per-scenario tests where the retry/ validation coverage they duplicated already lives in test_llm_chat_structured.py. Fixed a real gap the rename surfaced along the way: comfy-manager-entry.json (ComfyUI Manager registry listing) still had the old Ollama-specific display names — updated it and its matching test expectation. Full validation (T-CUT-10): 218 tests green (only the pre-existing, unrelated Dockerfile-python-version test fails); ruff/ty clean (confirmed via git stash comparison that the remaining ty diagnostics pre-date this work); beacon doctor --strict shows only already-disclosed items. Manual smoke test (T-CUT-12): Ollama was reachable in this environment, so ran the real integration suite rather than a walkthrough. 6/8 passed including the critical paths (real load/unload, real structured-output retry-then-raise, real error handling). 2 failures traced via direct curl to Ollama's /api/chat (bypassing this codebase) to a pre-existing, ADR-006-documented unreliability in the specific test model, not a regression. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132ojafeazQ3ephcBejEWFj
28 lines
1.0 KiB
JSON
28 lines
1.0 KiB
JSON
{
|
|
"author": "Darth Veitcher",
|
|
"title": "Comfy DV Nodes",
|
|
"reference": "https://github.com/darth-veitcher/comfydv",
|
|
"files": ["https://github.com/darth-veitcher/comfydv"],
|
|
"install_type": "git-clone",
|
|
"description": "Quality of life ComfyUI nodes: dynamic string formatting with Python f-strings or Jinja2 templates, seed-controlled random input selection, workflow circuit-breaker for conditional queue interruption, and Ollama LLM integration with 14 nodes for model management and chat completion.",
|
|
"nodename": [
|
|
"Format String (Python f-strings)",
|
|
"Random Choice",
|
|
"Circuit Breaker",
|
|
"Ollama Client",
|
|
"LLM Model Selector",
|
|
"LLM Load Model",
|
|
"LLM Unload Model",
|
|
"Chat Completion",
|
|
"Ollama Option — Temperature",
|
|
"Ollama Option — Seed",
|
|
"Ollama Option — Max Tokens",
|
|
"Ollama Option — Top P",
|
|
"Ollama Option — Top K",
|
|
"Ollama Option — Repeat Penalty",
|
|
"Ollama Option — Extra Body",
|
|
"Ollama Debug History",
|
|
"Ollama History Length"
|
|
]
|
|
}
|