42 Commits
Author SHA1 Message Date
facok 20455e339e Fix sharpness calibration vector count 2026-06-28 01:21:38 +08:00
facok 44812b79a6 Clean up anchor and calibration code after review
- Remove dead detect_anomalies() (superseded by adaptive variant)
- Remove unused r_ref param from infer_color_from_neighbors()
- Remove write-only c_ema state from anchor hook
- Use math.exp() instead of torch.tensor()+torch.exp() in bilateral loop
- Use in-place .add_() for accumulation in bilateral filter
- Pre-normalize padded tensor once in compute_local_relationships()
- Fix video VAE fallback producing duplicate vectors in calibration
2026-03-23 16:33:06 +08:00
facok 561f6ed041 Fix calibration crash with video VAEs that return 5D latents
vae.encode() on some VAEs returns [B, C, T, H, W] even for still
images. Squeeze temporal dim before patchify to avoid shape mismatch.
2026-03-23 16:24:48 +08:00
facok e9b7d7481d Add missing core modules required by LCSColorAnchor
core/bilateral.py and core/relationships.py were referenced by
nodes/anchor.py but never committed, causing ModuleNotFoundError
on fresh clones.
2026-03-23 16:11:27 +08:00
facok 85e437c794 Add .gitignore: exclude .claude/ and __pycache__/ 2026-03-22 21:55:23 +08:00
facok e7a836db4d Fix color/brightness side effects in sharpness intervention
Two bugs caused sharpness edits to shift color even when calibrated
with lcs_data:

1. Calibration order was wrong: DC removal before LCS color removal
   operated in the wrong space (LCS basis has large DC components),
   producing incorrect color projection and incomplete removal.
   Fix: remove color first (in raw space), then DC.

2. Intervention DC removal broke orthogonality: subtracting
   mean(pc1_dir) introduced a color component because the all-ones
   vector projects onto LCS basis. Fix: re-orthogonalize against
   LCS basis after DC removal.

Also: store lcs_basis in SharpnessData/safetensors so intervention
can re-orthogonalize; bump cache name to _grating to force
re-calibration with the corrected pipeline.
2026-03-22 20:57:08 +08:00
facok 818ec85429 Replace Gaussian blur calibration with sinusoidal grating stimuli
Grating stimuli achieve higher linearity (R²=0.94 vs 0.88) because each
contains a single spatial frequency — a purer probe of the sharpness axis.
Both methods discover the same 1D subspace (|cos|=0.986, 9.7° apart).

- Replace _gaussian_kernel_1d, _apply_gaussian_blur with _generate_grating_batch
- Generate stimuli lazily per batch to avoid 1.3GB all-at-once allocation
- Accept deprecated blur_levels parameter with warning
- Update cache filename to sharpness_{fp}_freq{suffix}.safetensors
- Update node descriptions to reflect new calibration method
2026-03-22 20:17:27 +08:00
facok bab475edc0 Add auto mode with drift-driven intensity to LCS Color Anchor
Default mode is now "auto", which infers the concrete mode from
connected inputs (reference+vae → reference, mask → smooth,
nothing → self_anchor) and derives intensity from runtime drift
signals instead of requiring manual tuning.
2026-03-22 03:29:27 +08:00
facok 858f0747c4 Extract shared downsample_mask helper to core/sampling.py
Deduplicate mask downsampling logic that was copied in 3 places
(intervene.py color hook, intervene.py tone hook, sharpen.py).
2026-03-21 22:56:59 +08:00
facok 0d9b685c2f Clean up: remove unused pack_info fields and legacy constants 2026-03-21 22:17:42 +08:00
facok cc5a8cbd6f Pad odd spatial dims in patchify for LTXV compatibility
LTXV can produce latents with odd H or W (e.g. 11x20) which can't be
divided into 2x2 patches. Patchify now pads odd dims to even using
replicate padding before rearranging, and unpatchify crops back to the
original size. This keeps patch_size=2 consistent between calibration
and inference for all models.
2026-03-21 21:39:46 +08:00
facok ec9941b5fc Use model's latent_format for space conversion instead of hardcoded FLUX constants
Replaces hardcoded SCALE_FACTOR/SHIFT_FACTOR with model.latent_format.process_in/out
so LCS works with any model (FLUX, LTXV, SD, etc). Adds LTXAV packed tensor
unpack/repack support for audio+video models. All hooks (color, tone, sharpness,
observer) now use the model-aware conversion from args["model"].
2026-03-21 21:30:22 +08:00
facok 4948395ac4 Skip intervention gracefully for incompatible latent formats (LTXAV)
LTXAV uses a flattened 1D latent layout (e.g. [1, 1, 466048]) where
spatial H/W < 2, making 2x2 patchification impossible. patchify() now
returns None for such formats, and all hooks skip intervention cleanly.
2026-03-21 20:40:53 +08:00
facok 5154bae137 Handle 3D tensors (LTXAV) in patchify/unpatchify 2026-03-21 20:34:40 +08:00
facok 0d82606fb0 Support 5D video VAE latents (Wan) in patchify/unpatchify
Video VAEs output [B, C, T, H, W]. Patchify now merges T into batch,
processes all frames, and unpatchify restores the 5D shape.
Updated all callers to pass extra_shape through.
2026-03-21 16:19:03 +08:00
facok a336d4ca95 Fall back to per-image VAE encoding for video VAEs (Wan)
Video VAEs like Wan don't support batch encoding — input B images
produces only 1 latent. Detect this by comparing output batch size
to input, and fall back to encoding images one by one.
Fixes both color calibration and sharpness calibration.
2026-03-21 16:10:13 +08:00
facok 53b2c4cadb Fix blur_labels count to match actual VAE output size 2026-03-21 15:41:14 +08:00
facok bab5d1b1ec Fix calibration batch indexing for VAEs that don't preserve batch size 2026-03-21 15:36:39 +08:00
facok 8c1d987b4f Fix patchify for video VAEs: slice first frame when ndim > 4 2026-03-21 15:33:32 +08:00
facok 6dd89e55e7 Handle 5D video VAE output (Wan) by squeezing temporal dimension 2026-03-21 15:21:51 +08:00
facok b3b08761c3 Auto-detect channel count in unpatchify for FLUX2 (128ch) support 2026-03-21 14:57:52 +08:00
facok c9e7d608a8 Simplify sharpness: precompute edit vector, remove dead pc1_std, reduce memory
- Precompute edit_vec = (strength * sign) * dc_removed_pc1_dir once in
  closure instead of recomputing pc1_dir mean removal every denoising step
- Remove SharpnessData.pc1_std (stored but never used since dropping
  pc1_std multiplier)
- Blur single-channel gray noise, expand to 3-channel per-batch instead
  of allocating full 201 MB 3-channel copy upfront
- Remove unused LCSData import
2026-03-20 17:25:49 +08:00
facok 1d024be9da Revert to 512px default, remove diagnostic logging
256 vs 512 difference (97.5% vs 97.3%) is within random variation —
different image_size consumes different random numbers from the same
seed, producing different images rather than a controlled comparison.
Keep 512 consistent with LCS color calibration. Remove per-blur-level
mean logging that was used during development.
2026-03-20 17:06:17 +08:00
facok ce4007b916 Default to 256px calibration images, add image_size parameter
256px gives the best PC1 (97.5%) and fastest calibration.
Larger images average more patches, reducing per-sample variance
but not improving PCA purity. Added image_size input to
LCSSharpnessCalibrate for experimentation.
2026-03-20 17:02:21 +08:00
facok 71233801a2 Use uniform blur levels (0,0.5,1,2,4,8) for sharpness calibration
σ=16 nearly destroys all spatial content (≈solid color), adding little
information beyond σ=8 while distorting PCA with an extreme outlier.
Adding σ=0.5 better captures subtle sharpness differences.

Result: PC1 96.7% → 97.3%, correlation 0.748 → 0.893.
2026-03-20 16:51:57 +08:00
facok f1661ed4bf Use grayscale noise for sharpness calibration
RGB noise has independent per-channel variation that blur affects
differently, introducing inter-channel variance captured as PC2.
Grayscale noise (same value across RGB) ensures blur affects all
channels identically, raising PC1 from 95.8% to 96.7%.

Also added per-vector zero-mean to remove VAE brightness drift
and diagnostic logging for per-blur-level latent means.
2026-03-20 16:37:34 +08:00
facok 6fe4add02c Add lcs_data to LCSSharpnessIntervene for color-preserved sharpness
When calibration used LCS color removal, the intervention must also
remove the color component before projecting onto the sharpness basis,
then add it back after reconstruction. This ensures sharpness edits
don't affect color.

Workflow:
1. LCSSharpnessCalibrate(vae, lcs_data) → sharpness_data
2. LCSSharpnessIntervene(model, sharpness_data, strength, lcs_data=lcs_data)

Both nodes now have optional lcs_data input. When connected, color is
preserved during sharpness intervention.
2026-03-20 14:16:22 +08:00
facok cc0291352e Add lcs_data input to remove color component during calibration
When LCS color data is connected, the sharpness PC1 will be orthogonal
to the color subspace, preventing color shifts during intervention.

Changes:
- calibrate_sharpness() now accepts optional lcs_data parameter
- LCSSharpnessCalibrate node has optional lcs_data input
- Cache files use "_lcs" suffix when LCS is used (different subspace)
2026-03-20 14:00:57 +08:00
facok c6b746ff32 Fix conv2d groups parameter and add .contiguous() for expanded kernels 2026-03-20 13:37:50 +08:00
facok 531fb5fd1a Fix sharpness calibration: use same base images for all blur levels
- Generate base images once upfront, then apply all blur levels to the
  SAME images (was generating different random images per blur level)
- Add separable convolution for kernel_size > 15 (O(2k) vs O(k²))
- Add kernel caching to avoid recomputation
- Add per-blur-level progress logging

This matches SubspaceLab's methodology and ensures PCA receives
properly paired stimuli (same image × multiple blur levels).
2026-03-20 13:34:45 +08:00
facok 03fb376b8c Fix sharpness calibration and simplify intervention hook
- Use random noise images instead of solid-color (blur had no effect
  on spatially uniform images, making calibration a no-op)
- Generate images per-batch to avoid 200 MB upfront allocation
- Simplify hook algebraically: patches + delta * pc1_dir eliminates
  projection/reconstruction/residual intermediates (~24 MB per step)
- Move SCALE_FACTOR, SHIFT_FACTOR, find_step_index to core/sampling.py
- Rename sd → shd to avoid confusion with state_dict convention
- Remove redundant [:,:,:,:3] slice and unused imports
2026-03-20 13:12:46 +08:00
facok cf9edf0239 Add sharpness intervention via PCA subspace in FLUX VAE patch space
New calibration (core/sharpness.py) generates blur stimuli, VAE-encodes,
and extracts PC1 as the sharpness direction. New nodes (nodes/sharpen.py)
provide LCSSharpnessCalibrate (auto-cached per-VAE) and
LCSSharpnessIntervene (post-CFG hook with strength, step window, mask).
Positive strength = sharper, negative = blurrier.
2026-03-20 13:01:23 +08:00
facok 28fa9450e0 Add progress output to calibration
- Print calibration parameters at start
- Show encoding progress with batch count
- Print PCA results (variance explained per component)
- Show anchor color encoding status
- Display final basis shape and anchor coordinates
2026-03-20 03:02:04 +08:00
facok 3fec154341 Refactor: extract shared _hue_lerp and _wrap_hue_diff helpers
- Add _wrap_hue_diff() and _hue_lerp() to core/color_space.py for
  reuse across the codebase
- Remove duplicate _hue_lerp from nodes/intervene.py, import from core
- Update diagnostics.py to use shared _hue_lerp instead of inline logic
- Move input_var computation outside strength loop in test_type_ii_uniformity
- Move get_alpha_beta_t50() outside sigma loop in test_early_timestep_amplification
2026-03-19 18:14:13 +08:00
facok b8834564e2 Refactor: extract _bicone_factor helper and clean up diagnostics
- Extract repeated bicone factor formula (1 - |2L - 1|) into _bicone_factor()
  helper function, used in 4 places across color_space.py
- Optimize test_type_ii_uniformity: move decode outside strength loop
- Add named constants for test parameters in diagnostics.py
- Remove unused imports and variables
2026-03-19 15:47:20 +08:00
facok 651599b003 Fix bicone geometry: normalize chroma radii to equatorial
The chromatic anchors (R,G,B,C,M,Y) have different lightness levels
(L=0.38-0.63), so their observed chroma radii are already scaled by
the bicone factor (1 - |2L - 1|). The old code double-counted this
factor, causing round-trip errors of 10-12 units and color distortion.

Fix: In _hue_to_chroma_vector, normalize anchor radii to equatorial
(radius at L=0.5) before interpolation. During encode/decode, apply
bicone factor at target lightness. This ensures proper round-trip:
- encode(lcs) → hsl → encode(hsl) ≈ lcs with error < 1e-5
- Saturation now correctly returns 1.0 for saturated anchor colors

Also add diagnostics module for blurriness analysis:
- test_round_trip_consistency: verify bicone math
- test_normalization_stability: check timestep amplification
- test_type_ii_uniformity: measure variance loss at different strengths
- analyze_blurriness_causes: comprehensive diagnostic report
2026-03-19 13:21:12 +08:00
facok 6cd650596d Extract shared _chromatic_plane_basis helper and _ANCHOR_HUES constant
Deduplicate the Gram-Schmidt basis construction that was copy-pasted
in decode_lcs_to_hsl, encode_hsl_to_lcs, and calibration.py. Extract
anchor hue values into a module-level constant to prevent silent
divergence. Also remove unnecessary tensor clone in _angle_to_hue and
use torch.empty instead of torch.zeros where all elements are overwritten.
2026-03-17 13:05:27 +08:00
facok 02585b6bf1 Fix bicone HSL mapping by projecting anchors onto chromatic plane
Replace _hue_to_polygon_point with _hue_to_chroma_vector to fix
Type II and interpolated color intervention modes. The old function
interpolated raw 3D anchor positions (mixing lightness into chroma
directions) and ignored calibrated anchor angles. The new function
projects anchors onto the plane perpendicular to the achromatic axis
to get pure chroma radii, then interpolates radius and angle in the
same segment structure as _angle_to_hue for round-trip consistency.
2026-03-17 12:25:49 +08:00
facok c0449e3382 Fix BFloat16 error in VAE fingerprinting by casting to float32 2026-03-17 06:57:34 +08:00
facok 48d5f7efb6 Merge LCSCalibrate into LCSLoadData with per-VAE auto-caching
Replace two calibration nodes with a single smart LCSLoadData that
fingerprints VAE weights (sha256 of first decoder weight) and
auto-manages cached calibration files as data/lcs_{fingerprint}.safetensors.
2026-03-17 06:27:55 +08:00
facok 0973fd0fd8 Add docstrings to all public functions, classes, and methods
Coverage: 29% → 100% (41/41 public items documented).
Keeps the existing concise style with inline shape annotations.
2026-03-17 02:26:21 +08:00
facok 534bc19033 Implement LCS plugin for training-free color control in FLUX
Implements "The Latent Color Subspace" (arXiv:2603.12261v1, ICML 2026)
as a ComfyUI plugin with V3 API + V2 backward compatibility.

6 nodes across 3 categories:
- LCS/calibration: LCSCalibrate (PCA from VAE), LCSLoadData (cache load)
- LCS/intervention: LCSColorIntervene (single color), LCSColorBatch (multi)
- LCS/observe: LCSPreviewColors (latent color map), LCSStepObserver

Core modules: patchify (16ch->64d patches), bicone HSL<->LCS mapping,
alpha_t/beta_t tables (51 entries from Appendix F), PCA calibration,
and timestep normalization with residual preservation.
2026-03-17 01:43:26 +08:00