Gregory RichardandClaude Opus 5
56cc87fd92
Bugs found reading the pack end to end. V3 mode registered five of the seven nodes: Save Image (Civitai) and Prompt + LoRAs had no schema, so a workflow using either failed to open with WARPPIPE_ENABLE_V3=1 and nothing said why. Both registration paths are now built from one NODE_DEFINITIONS table, a missing V3 schema is reported at startup, and a test asserts the two paths agree. The built wheel shipped no JavaScript at all - package-data listed only web/docs/*.md - so a registry install had a frontend directory holding documentation and nothing else. A test now reads pyproject.toml and checks every file under web/ is matched by a glob. Also fixed: - ruff format failed on two files, so CI was red on every push - the nearest-model tie-break compared whole tuples, breaking ties on the filename rather than on the order the graph listed them - SAFE_SAMPLERS and SAFE_SCHEDULERS referenced ComfyUI's own lists rather than copying them, so anything another pack appended later walked through coerce_scheduler untouched - the hash and thumbnail caches wrote straight to their final paths, leaving a truncated file behind if anything interrupted them - the Prompt + LoRAs node left a 100ms timer, a MutationObserver and its strip running after the node was removed - model names and base models from downloaded sidecars were written into the browser's rows as markup without escaping - a branch in the save node preferring "LoRAs recorded in the warp" could never run, because nothing ever wrote them there - indexing the library read every .civitai.info twice - the two views each held their own copy of the index and fetched it separately The frontend had no automated checks at all, which is how two unused arguments and an unescaped innerHTML survived. eslint and prettier now run over web/ in their own CI job, with the lockfile committed for the same reason the Python tools are pinned. Five regression tests, each checked against the unfixed code. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
19 lines
535 B
JSON
19 lines
535 B
JSON
{
|
|
"name": "comfyui-warppipe-web",
|
|
"private": true,
|
|
"type": "module",
|
|
"description": "Lint and format checks for the WarpPipe frontend. Not published; the node pack ships as a Python package.",
|
|
"scripts": {
|
|
"lint": "eslint web",
|
|
"format": "prettier --write \"web/**/*.js\"",
|
|
"format:check": "prettier --check \"web/**/*.js\"",
|
|
"check": "npm run lint && npm run format:check"
|
|
},
|
|
"devDependencies": {
|
|
"@eslint/js": "9.39.1",
|
|
"eslint": "9.39.1",
|
|
"globals": "16.5.0",
|
|
"prettier": "3.6.2"
|
|
}
|
|
}
|