From 3447b1a3f1ec80886d58e6673affec3ef210d7e2 Mon Sep 17 00:00:00 2001 From: alexzms <3036648523@qq.com> Date: Thu, 5 Nov 2026 01:48:36 +0000 Subject: [PATCH] Drop a narrating comment from the cancelled-decoding test Greptile review: the comment is not on the repository's comment keep-list. The test name and its release/finished steps already say that cleanup waits for the decoding thread. This was the last such comment this PR adds to tests. Co-Authored-By: Claude Opus 5.5 --- fastvideo/tests/entrypoints/test_openai_serving_engine.py | 1 - 1 file changed, 1 deletion(-) diff --git a/fastvideo/tests/entrypoints/test_openai_serving_engine.py b/fastvideo/tests/entrypoints/test_openai_serving_engine.py index 844343aa8..a89d68edd 100644 --- a/fastvideo/tests/entrypoints/test_openai_serving_engine.py +++ b/fastvideo/tests/entrypoints/test_openai_serving_engine.py @@ -408,7 +408,6 @@ async def _assert_cancelled_decoding_removes_its_file(tmp_path: Path, monkeypatc preparing.cancel() with pytest.raises(asyncio.CancelledError): await preparing - # The thread writes its file only after the request is gone, so cleanup has to wait for the thread. release.set() assert await asyncio.to_thread(finished.wait, 5) assert written == [True]