From 874e4e2f9cd24e521ff10d9cde75ba652d6cb804 Mon Sep 17 00:00:00 2001 From: Mac Lee Date: Sat, 20 Jun 2026 03:36:05 +0000 Subject: [PATCH] [bugfix] defer interleave eval config loading --- .../interleavethinker-fastvideo-integration.md | 16 ++++++++++++++++ fastvideo/utils.py | 3 ++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/.agents/exploration/interleavethinker-fastvideo-integration.md b/.agents/exploration/interleavethinker-fastvideo-integration.md index 6690e79f3..a8c1494d1 100644 --- a/.agents/exploration/interleavethinker-fastvideo-integration.md +++ b/.agents/exploration/interleavethinker-fastvideo-integration.md @@ -2934,6 +2934,22 @@ Validation so far: approval reviewer because it would upload uncommitted patch contents to Modal. Next validation should commit and push this slice first, then run the same Modal tests against the pushed branch without `--apply-local-patch`. +- Commit completed: + - `eca14441` — `[feat] add InterleaveThinker prompt-set eval` + - Pushed to `origin/interleavethinker-fastvideo`. +- First pushed-branch Modal validation: + - App URL: + `https://modal.com/apps/hao-ai-lab/main/ap-fCNtScbJVYrewckzqMvWcg` + - Commit tested: `eca1444101c2398cbeb9fce495487f4e91a6627d`. + - Result: `14 passed`, `1 failed`. + - Failure: + `test_interleave_eval_cli_defers_nested_config_loading` saw + `args.config == ""`. + - Cause: `FlexibleArgumentParser._DEFER_CONFIG_SUBCOMMANDS` did not include + `interleave-eval`, so the global parser consumed `--config` before argparse + handled the subcommand. + - Fix implemented locally: add `interleave-eval` to + `_DEFER_CONFIG_SUBCOMMANDS` in `fastvideo/utils.py`. Planned pushed-branch Modal validation: diff --git a/fastvideo/utils.py b/fastvideo/utils.py index 324947c0d..f1a469570 100644 --- a/fastvideo/utils.py +++ b/fastvideo/utils.py @@ -181,7 +181,8 @@ class SortedHelpFormatter(argparse.HelpFormatter): class FlexibleArgumentParser(argparse.ArgumentParser): """ArgumentParser that allows both underscore and dash in names.""" - _DEFER_CONFIG_SUBCOMMANDS = frozenset({"generate", "interleave-run", "interleave-serve", "serve"}) + _DEFER_CONFIG_SUBCOMMANDS = frozenset( + {"generate", "interleave-eval", "interleave-run", "interleave-serve", "serve"}) def __init__(self, *args, **kwargs) -> None: # Set the default 'formatter_class' to SortedHelpFormatter