- Added test_data/benchmarks/ to exclude benchmark JSON files
- Added test_data/inputs/ and test_data/outputs/ to exclude captured data
- Added test_data/analysis_results.json and optimization_recommendations.json
- Removed already committed benchmark files from git tracking
This ensures instrumentation data is not committed to the repository
while keeping the data available locally for analysis.
Fixed critical issue: Expected 4 channels for latent, got 16
Changes:
- Added support for both SD (4-channel) and SDXL (16-channel) latents
- Fixed tensor dimension handling - removed incorrect permute operations
- Added comprehensive test suite covering different channel counts
- Fixed import issues (time, logging) for testing environment
- Enhanced error handling for unsupported channel counts
- Added fallback behavior tests for both SD and SDXL
- Updated instrumentation to capture new channel types
Test coverage:
- SD 4-channel latents (standard)
- SDXL 16-channel latents (new support)
- Different batch sizes and resolutions
- Fallback behavior when VAE decode fails
- Error handling for unsupported channel counts
- Instrumentation capture verification
All 8 tests passing! The nodes now properly handle both SD and SDXL architectures.
- Added instrumentation decorator to all ROCM nodes
- Fixed instrumentation to work with ComfyUI node structure
- Collected baseline performance data for ROCMOptimizedVAEDecode
- Created test infrastructure for performance optimization
- Baseline: avg 0.427ms, median 0.199ms, 100% fast executions
Gavroche