Commit Graph
36 Commits
Author SHA1 Message Date
iGavroche 20626b4fd4 v2.2.0: ROCm SamplerCustomAdvanced drop-in with benchmark
- ROCMSamplerCustomAdvanced: V3 ComfyNode drop-in for stock SamplerCustomAdvanced
  with architecture detection, ROCm backend tuning, memory defrag for high-memory
  models (LTX 128ch), enhanced per-step callback with ETA
- ROCMSamplerCustomAdvancedBenchmark: A/B comparison node for stock vs ROCm
- docs/SAMPLER_CUSTOM_ADVANCED.md: full documentation for agents and users
- Category: ROCm Ninodes/Sampling
- Bump version to 2.2.0 across all files
2026-06-13 09:52:12 -04:00
iGavroche 281472e0e4 v2.1.1: shared arch detection, sampler auto-detect for z-image/ernie/ideogram4
- Extract detect_architecture() to shared rocm_nodes/utils/architecture.py
- ROCm KSampler now auto-detects GPU architecture + model type at runtime:
  - Flow-matching models (z-image, ernie, ideogram4) logged and optimized
  - Pixel-space models (z-image-turbo) recognized — no VAE decode needed
  - High-memory models (ideogram4, factor 11.6x) get automatic cleanup
  - Architecture-aware backend settings (TF32, fp16 accumulation)
- ROCmSamplerPerformanceMonitor now model-type + architecture aware
- ROCmVAEPerformanceMonitor uses shared architecture detection
- Fix ProgressBar mock in test conftest
- Add flow-matching and pixel-space model detection tests
- Update KSampler/PerfMonitor README docs
2026-06-12 17:49:56 -04:00
iGavroche c989a48aab v2.1.0: LTX/z-image VAE support, temporal tiling, fp16 default, APU tuning
- LTX Video VAE detection (128 channels, 32x spatial compression, 8x temporal)
- z-image / z-image-turbo pixel-space VAE passthrough (no decode needed)
- fp16 default on all AMD GPUs (Strix Halo, RDNA 2/3, CDNA)
- Per-architecture tuning with automatic detection (gfx1151/gfx1100/gfx1030/CDNA)
- Temporal tiling for long videos: overlapping chunks with linear blend,
  zero frame loss, progress bar in UI (disabled by default)
- Chunked IO bypass for LTX — fixes OOM with max_split_size_mb caps
- Fixed memory estimation: correct for all dims (including 5D temporal) and dtypes
- APU-aware memory management (psutil for unified memory on Strix Halo)
- Tile size floor for high-compression VAEs (min 64 latent pixels)
- 25 unit tests covering all new features
2026-06-12 15:54:56 -04:00
iGavroche 82540c5245 chore(release): bump version to 2.0.11 and update documentation
- Updated version to 2.0.11 in pyproject.toml and comfyui_manager.json for consistency.
- Removed video chunking from ROCMOptimizedVAEDecode to ensure full video decoding for temporal/causal VAEs, preventing artifacts.
- Added new ROCm Text Generate LTX2 Prompt node, enhancing generative AI capabilities.
- Updated README to reflect new features and improvements in v2.0.11.
- Enhanced changelog with details on changes and fixes in this release.
2026-03-08 11:35:08 -04:00
iGavroche ed83aa2f17 docs: Update README for v2.0.10 with new features and improvements
- Updated version number to 2.0.10 in the README header.
- Added new section detailing features in v2.0.10, including checkpoint caching and FP8/quantized checkpoint reuse.
- Enhanced clarity on the ROCm Checkpoint Loader's caching mechanism and its benefits for performance.
2026-03-08 09:44:12 -04:00
iGavroche f6c3d39d9f docs: Enhance README with detailed node usage guide for ROCm Ninodes, including VAE Decode, KSampler, and performance monitoring nodes 2025-11-30 12:33:04 -05:00
Nino ab9ea59779 Fix WAN VAE jitter issue - disable chunking for WAN models (v2.0.1)
- Added reliable WAN VAE detection using isinstance() with imported classes
- Added fallback detection using latent_channels (16 for WAN 2.1, 48 for WAN 2.2)
- Disabled chunking for WAN VAEs to preserve causal decoding chain with feature caching
- Matched native ComfyUI behavior exactly for WAN VAE video processing
- Fixed detection logic to use correct file (rocm_nodes/core/vae.py)
- Applied ROCm backend optimizations to video processing
- Added async memory cleanup for WAN VAE videos
- Added gfx1151 architecture detection and logging
- Updated version to 2.0.1 across all files
2025-11-01 15:02:09 -04:00
Nino 5d515f035e docs: add Upgrade to v2 section; fix ROCm branding in title\nchore: add tools/upgrade_to_v2.py migration helper\nrefactor: finalize v2 structure and cleanup wording 2025-10-30 14:47:52 -04:00
Nino 50e84d712b v1.0.29: Fixed video chunk boundary artifacts - Added temporal overlap to prevent darker frames at chunk boundaries 2025-10-28 18:19:51 -04:00
Nino 93e2213ec2 v1.0.27: Mature ROCm driver support with gentle memory management
- Optimized for mature ROCm drivers and libraries
- Added TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1 for better performance
- Replaced aggressive memory management with gentle cleanup
- Updated memory allocation settings (256MB chunks, 0.8 threshold)
- Removed performance-penalizing functions and complex memory management
- Cleaned up development files and test workflows
- Enhanced README with clear explanation of what we do and how we do it
- Maintained 9 optimized nodes with gentle memory management
2025-10-19 19:53:41 -04:00
Gavroche 1466b7f75c ✅ COMPLETE: ROCM Performance Recovery & Testing Infrastructure
- Restored v1.0.13 with all 9 working nodes (ROCMOptimizedCheckpointLoader, ROCMOptimizedKSampler, etc.)
- Implemented comprehensive debug flag system (ROCM_NINODES_DEBUG=1)
- Created complete test suite with performance and correctness tests
- Added data capture infrastructure for real workflow testing
- Built standalone test runner with mock data support
- Created ComfyUI integration tests for Flux and WAN workflows
- Added comprehensive documentation (ARCHITECTURE.md, RULES.md, TESTING_GUIDE.md)
- Updated README with testing section and performance targets
- All tests passing with proper error handling and data validation

Performance Targets:
- Flux: 78% improvement (≤110s total)
- WAN: 5.6% improvement (≤93s sampling)
- VAE Decode: <10s for any resolution
- Checkpoint Load: <30s for Flux models

Ready for production use with comprehensive testing infrastructure!
2025-10-11 09:56:20 -04:00
Gavroche 9651f824f5 v1.0.13: Fix critical WAN video workflow errors and add comprehensive testing
- Fixed AttributeError: 'dict' object has no attribute 'shape'
- Fixed IndexError: tuple index out of range in WAN VAE memory calculation
- Fixed ValueError: Expected numpy array with ndim 3 but got 4 in video output
- Added comprehensive test suite with 9 test cases covering all error scenarios
- Added debug data collection and optimization testing framework
- Updated documentation with testing section and performance benchmarks
- Cleaned up unused files and improved code quality
- WAN video workflows now work end-to-end without errors
2025-10-10 20:00:32 -04:00
Gavroche 2f9c5af099 v1.0.12: Fix parameter type error in ROCMOptimizedKSampler
- Fixed TypeError: '>' not supported between instances of 'list' and 'float'
- Added parameter conversion logic for cfg, steps, seed, denoise, etc.
- Applied fix to both ROCMOptimizedKSampler and ROCMOptimizedKSamplerAdvanced
- Complete end-to-end workflow now executes successfully (70.41s total)
- Performance: Checkpoint 26.05s, Sampling 41.54s, VAE 0.30s
- Successfully generates proper images confirming full functionality
2025-10-10 15:57:47 -04:00
Gavroche 10606e17a6 Enhance checkpoint loader with better Flux model detection and guidance
- Added warning detection for Flux diffusion-model-only files
- Enhanced error messages with specific guidance for Flux models
- Added helpful console output explaining Flux model file structure
- Updated troubleshooting guide with specific checkpoint recommendations
- Provides clearer guidance for users selecting diffusion-model-only files
2025-10-10 15:08:36 -04:00
Gavroche ddeffe40e9 v1.0.11: Fix checkpoint compatibility and CLIP input error
- Fixed blessed workflow using diffusion-model-only file instead of full checkpoint
- Resolved 'clip input is invalid: None' error caused by flux1-dev-fp8.safetensors
- Enhanced error handling with comprehensive validation for model, CLIP, and VAE outputs
- Updated troubleshooting guide to explain diffusion-model-only files issue
- Added Flux model guidance for separate file structure
- Blessed workflow now uses user-selectable checkpoint for maximum compatibility
2025-10-10 15:00:55 -04:00
Gavroche ddf24eb010 Fix blessed workflow checkpoint issue
- Fixed flux_dev_optimized.json to use user-selectable checkpoint instead of hardcoded flux1-dev-fp8.safetensors
- Updated troubleshooting guide to explain diffusion-model-only files issue
- Added guidance for Flux models that come as separate files
- Resolves CLIP input invalid error caused by using diffusion model only file
2025-10-10 14:58:22 -04:00
Gavroche 9623a5b698 Add generic workflow version and troubleshooting guide
- Created flux_dev_optimized_generic.json with no hardcoded checkpoint
- Added comprehensive troubleshooting section for CLIP input errors
- Provides solutions for missing/invalid checkpoint issues
- Added generic workflow download link for users without specific checkpoints
- Enhanced error handling and validation in checkpoint loader
2025-10-10 14:55:58 -04:00
Gavroche 38b68dd30c Update README with alternative GitHub web interface links for blessed workflow
- Added GitHub web interface links as alternatives to raw.githubusercontent.com
- Provides immediate access while CDN propagates
- Ensures users can access flux_dev_optimized.json workflow
2025-10-10 14:42:13 -04:00
Gavroche 0fbece61e7 v1.0.10: Fix checkpoint loader stability and resolve noise output issues
- Fixed critical ROCMOptimizedCheckpointLoader errors causing noise output
- Resolved torch.pickle and comfy.model_management.ModelPatcher errors
- Streamlined checkpoint loader implementation for maximum reliability
- Enhanced with lazy_loading, optimize_for_flux, and precision_mode parameters
- Performance within 2-3% of standard loader (28.32s vs 29.07s)
- Verified proper 512x512 PNG image generation with both standard and ROCM nodes
- Updated blessed workflow with enhanced checkpoint loader parameters
- Comprehensive testing confirms stable end-to-end workflow execution
2025-10-10 14:38:46 -04:00
Gavroche db15697bb7 Update version to 1.0.9 and enhance ROCM optimizations
- Increment version in pyproject.toml and comfyui_manager.json from 1.0.7 to 1.0.9
- Add new nodes: ROCMOptimizedCheckpointLoader, ROCMFluxBenchmark, and ROCMMemoryOptimizer
- Implement Flux-specific optimizations and adaptive tile sizing in VAE decode
- Introduce memory management improvements and performance benchmarks
- Update README with new features and installation methods for enhanced user experience
2025-10-10 13:53:28 -04:00
Gavroche b4e009dae1 merge fixes 2025-10-05 10:12:35 -04:00
Gavroche 0fed5b44b0 Add detailed WAN 2.2 i2v benchmarks and bump version to 1.2.1
- Add comprehensive benchmark results for 320x320px, 17 frames WAN 2.2 i2v
- Show 8.1% overall performance improvement (93.05s vs 101.17s average)
- Include detailed breakdown of KSampler and VAE Decode timings
- Update version to 1.2.1 for ComfyUI registry submission
- Add consistency metrics showing stable performance across runs
2025-10-05 10:08:19 -04:00
iGavroche 756e251496 Add node.zip and update README installation methods
- Introduced a new node.zip file for plugin distribution
- Updated README to include new installation methods for the plugin via ComfyUI CLI and manual installation
- Renumbered installation methods for clarity

This enhances the installation experience for users by providing clear and updated instructions.
2025-10-03 21:37:54 -04:00
Gavroche 7e342843de Add comprehensive Windows pagination error 1455 fixes
- Add WindowsPaginationDiagnostic node for automatic detection and fixes
- Add Windows-specific memory management and optimizations
- Add 6 different methods to fix pagination errors
- Add PowerShell and Batch scripts for automatic fixes
- Add psutil dependency for memory diagnostics
- Update documentation with comprehensive troubleshooting guide
- Version bump to 1.2.0
2025-10-03 13:45:17 -04:00
Gavroche 8d4ac261f1 Update README to remove redundant installation instructions
- Removed unnecessary additional dependencies installation step for torchvision and torchaudio
- Streamlined the installation process for ROCm PyTorch nightly on gfx1151

This simplifies the setup instructions for users, ensuring clarity and efficiency in the installation process.
2025-10-03 13:30:25 -04:00
Gavroche fb3f4b30ed Consolidate benchmarks with new i2v results
- Added 480x720px i2v generation benchmark (303s, 33 frames, 16fps)
- Properly categorized as Image-to-Video (i2v) generation
- Organized benchmarks into clear sections: Image Generation vs i2v Generation
- Updated performance metrics to reflect i2v capabilities
- Shows progression: 320x320 → 480x480 → 480x720px successfully handled

This demonstrates the plugin's ability to scale i2v generation
to higher resolutions on AMD GPUs with ROCm optimization.
2025-10-03 13:15:50 -04:00
Gavroche dbdb3dcc3d Add comprehensive Windows pagination error fixes
- Added 4 different methods to fix Windows pagination errors
- Environment variable, batch file, PowerShell profile, and system variable solutions
- Advanced troubleshooting for memory and ROCm issues on Windows
- Updated performance results with 480x480px video generation success
- Comprehensive Windows-specific guidance for users

This addresses the common pagination errors Windows users encounter
when using ROCm with PyTorch on AMD GPUs.
2025-10-03 12:59:33 -04:00
Gavroche 66bdc55fe5 Fix Windows installation errors and add troubleshooting
- Added quick fix section for common Windows PowerShell errors
- Clarified git pull vs git clone usage in update instructions
- Added specific troubleshooting for 'fatal: couldn't find remote ref' error
- Added troubleshooting for 'does not appear to be a git repository' error
- Added virtual environment activation troubleshooting
- Separated installation methods: existing vs new installations
- Added Method 3 for when git pull fails completely
- Made Windows instructions more step-by-step and foolproof

This addresses the specific errors shown in the user's screenshot:
- git pull before cloning
- virtual environment activation issues
- incorrect git command syntax
2025-10-03 11:05:39 -04:00
Gavroche 7cd5d0729d Add comprehensive ComfyUI installation and plugin update instructions
- Added complete ComfyUI setup guide with uv for Linux and Windows
- Documented tested setup on Manjaro Linux with GMTek Evo-X2 Strix Halo
- Added detailed plugin update instructions (git pull and fresh install)
- Included uv-specific troubleshooting for common issues
- Added update notifications and changelog references
- Covered both Linux (Manjaro/Ubuntu/Arch) and Windows (PowerShell) setups
- Included ROCm PyTorch nightly installation steps
- Added virtual environment management with uv
- Comprehensive troubleshooting for uv, git, and permission issues

This makes the plugin much more accessible to users who want to set up
ComfyUI from scratch or update the plugin easily.
2025-10-03 11:01:51 -04:00
Gavroche 59c06ab32c Fix workflow UUID validation and update performance results
- Fixed invalid UUID in example_workflow.json (was string, now proper UUID)
- Updated example_workflow_wan_video.json with new UUID
- Added WAN 2.2 video performance results: 163s → 139s (15% improvement)
- Updated README with video workflow performance metrics
- Both workflows now pass ComfyUI Zod schema validation

Performance Summary:
- Flux 1024x1024: 500s → 110s (78% improvement)
- WAN 2.2 Video (2s, 320x320): 163s → 139s (15% improvement)
2025-10-03 10:57:31 -04:00
Gavroche e83dc6fa70 Add optimized WAN 2.2 video workflow
- Added video_wan2_2_14B_i2v_rocm_optimized.json workflow
- Replaced VAE Decode nodes with ROCMOptimizedVAEDecode (2 nodes)
- Replaced KSamplerAdvanced nodes with ROCMOptimizedKSamplerAdvanced (6 nodes)
- Total of 8 ROCM optimizations in the video workflow
- Updated README with both Flux and WAN video workflow downloads
- Ready for testing on gfx1151 architecture
2025-10-03 10:22:37 -04:00
Gavroche 30d1235ed2 Add comprehensive Windows/PowerShell support
- Added Windows-specific prerequisites and installation steps
- PowerShell commands for ROCm PyTorch installation
- Windows environment variable setup instructions
- Windows-specific troubleshooting section
- PowerShell execution policy and Python path fixes
- Git installation guidance for Windows users
- Clear warnings about ROCm Windows limitations
- WSL2 and dual-boot recommendations for optimal performance
2025-10-03 10:15:48 -04:00
Gavroche 6100496fb5 Add optimized workflow download links to README
- Added prominent download link in main features section
- Added detailed Quick Start section with workflow download
- Direct link to example_workflow.json for easy testing
- Clear instructions for using the optimized workflow
- Users can now easily test the 78% performance improvement
2025-10-03 10:14:28 -04:00
Gavroche 3968cb1439 Update README with new node organization
- Updated post-installation instructions to show 'RocM Ninodes' folder structure
- Clarified node categories: VAE and Sampling subfolders
- Better user guidance for finding nodes in ComfyUI interface
2025-10-03 10:06:32 -04:00
Nino 0b5cd1d358 Update branding and add real-world performance results
- Renamed to 'RocM Ninodes' with updated branding
- Added real-world performance results: 500s → 110s (78% improvement)
- Added GMTek Evo-X2 Strix Halo setup instructions
- Updated author email to nino2k@proton.me
- Added specific ROCm PyTorch installation commands
- Added optimized ComfyUI startup flags
- Updated GitHub repository URLs to iGavroche/rocm-ninodes
2025-10-03 09:50:59 -04:00
Nino 1e3d3a1cc3 Initial release: RocM-Nino v1.0.0
- Complete ROCM optimization suite for AMD GPUs (gfx1151)
- 6 optimized nodes: VAE decode, KSampler, and performance monitors
- ROCm 6.4+ specific optimizations and memory management
- Easy installation with install.py script
- Comprehensive documentation and example workflows
- Expected 20-40% performance improvement for gfx1151 architecture

Features:
- ROCMOptimizedVAEDecode: Main optimized VAE decode
- ROCMOptimizedVAEDecodeTiled: Advanced tiled VAE decode
- ROCMOptimizedKSampler: Optimized sampling with ROCm tuning
- ROCMOptimizedKSamplerAdvanced: Advanced sampler with extended control
- ROCMVAEPerformanceMonitor: VAE performance analysis
- ROCMSamplerPerformanceMonitor: Sampler performance analysis
2025-10-03 09:37:23 -04:00