Commit Graph
12 Commits
Author SHA1 Message Date
iGavroche 20626b4fd4 v2.2.0: ROCm SamplerCustomAdvanced drop-in with benchmark
- ROCMSamplerCustomAdvanced: V3 ComfyNode drop-in for stock SamplerCustomAdvanced
  with architecture detection, ROCm backend tuning, memory defrag for high-memory
  models (LTX 128ch), enhanced per-step callback with ETA
- ROCMSamplerCustomAdvancedBenchmark: A/B comparison node for stock vs ROCm
- docs/SAMPLER_CUSTOM_ADVANCED.md: full documentation for agents and users
- Category: ROCm Ninodes/Sampling
- Bump version to 2.2.0 across all files
2026-06-13 09:52:12 -04:00
iGavroche 281472e0e4 v2.1.1: shared arch detection, sampler auto-detect for z-image/ernie/ideogram4
- Extract detect_architecture() to shared rocm_nodes/utils/architecture.py
- ROCm KSampler now auto-detects GPU architecture + model type at runtime:
  - Flow-matching models (z-image, ernie, ideogram4) logged and optimized
  - Pixel-space models (z-image-turbo) recognized — no VAE decode needed
  - High-memory models (ideogram4, factor 11.6x) get automatic cleanup
  - Architecture-aware backend settings (TF32, fp16 accumulation)
- ROCmSamplerPerformanceMonitor now model-type + architecture aware
- ROCmVAEPerformanceMonitor uses shared architecture detection
- Fix ProgressBar mock in test conftest
- Add flow-matching and pixel-space model detection tests
- Update KSampler/PerfMonitor README docs
2026-06-12 17:49:56 -04:00
iGavroche c989a48aab v2.1.0: LTX/z-image VAE support, temporal tiling, fp16 default, APU tuning
- LTX Video VAE detection (128 channels, 32x spatial compression, 8x temporal)
- z-image / z-image-turbo pixel-space VAE passthrough (no decode needed)
- fp16 default on all AMD GPUs (Strix Halo, RDNA 2/3, CDNA)
- Per-architecture tuning with automatic detection (gfx1151/gfx1100/gfx1030/CDNA)
- Temporal tiling for long videos: overlapping chunks with linear blend,
  zero frame loss, progress bar in UI (disabled by default)
- Chunked IO bypass for LTX — fixes OOM with max_split_size_mb caps
- Fixed memory estimation: correct for all dims (including 5D temporal) and dtypes
- APU-aware memory management (psutil for unified memory on Strix Halo)
- Tile size floor for high-compression VAEs (min 64 latent pixels)
- 25 unit tests covering all new features
2026-06-12 15:54:56 -04:00
iGavroche 82540c5245 chore(release): bump version to 2.0.11 and update documentation
- Updated version to 2.0.11 in pyproject.toml and comfyui_manager.json for consistency.
- Removed video chunking from ROCMOptimizedVAEDecode to ensure full video decoding for temporal/causal VAEs, preventing artifacts.
- Added new ROCm Text Generate LTX2 Prompt node, enhancing generative AI capabilities.
- Updated README to reflect new features and improvements in v2.0.11.
- Enhanced changelog with details on changes and fixes in this release.
2026-03-08 11:35:08 -04:00
iGavroche 2b7c9e26ee chore(release): bump version to 2.0.3 and update changelog for enhanced KSampler progress reporting 2025-11-30 09:10:58 -05:00
iGavroche 8070724ffb chore(release): bump version to 2.0.2 and update changelog for video processing improvements 2025-11-27 14:22:26 -05:00
Nino ab9ea59779 Fix WAN VAE jitter issue - disable chunking for WAN models (v2.0.1)
- Added reliable WAN VAE detection using isinstance() with imported classes
- Added fallback detection using latent_channels (16 for WAN 2.1, 48 for WAN 2.2)
- Disabled chunking for WAN VAEs to preserve causal decoding chain with feature caching
- Matched native ComfyUI behavior exactly for WAN VAE video processing
- Fixed detection logic to use correct file (rocm_nodes/core/vae.py)
- Applied ROCm backend optimizations to video processing
- Added async memory cleanup for WAN VAE videos
- Added gfx1151 architecture detection and logging
- Updated version to 2.0.1 across all files
2025-11-01 15:02:09 -04:00
Nino 5d515f035e docs: add Upgrade to v2 section; fix ROCm branding in title\nchore: add tools/upgrade_to_v2.py migration helper\nrefactor: finalize v2 structure and cleanup wording 2025-10-30 14:47:52 -04:00
Gavroche 29b6eb293d Add ComfyUI management scripts and process control workflow
- Created kill_comfyui.sh for reliable ComfyUI process termination
- Updated restart_comfyui.sh to use existing start.sh
- Added ComfyUI Process Management section to RULES.md
- Established proper workflow: kill -> edit -> restart
- Debug mode controlled by ROCM_NINODES_DEBUG environment variable
- Removed redundant start_comfyui.sh script
- Fixed process killing method (ps aux + kill -9 instead of pkill)
- Integrated with existing ROCm-optimized start.sh infrastructure
2025-10-11 12:00:28 -04:00
Gavroche 471fef9996 ✅ RESTORE TEST SUITE: Comprehensive testing infrastructure
CRITICAL RESTORATION COMPLETED:
- Restored complete test suite that was accidentally deleted
- Fixed performance regression issues
- Created comprehensive testing infrastructure

Test Suite Components:
✅ Unit Tests (10 tests) - All passing
  - Basic VAE decode functionality
  - Different tile sizes and resolutions
  - Precision modes and batch processing
  - Memory optimization and adaptive tiling
  - Error handling and performance consistency

✅ Integration Tests (6 passed, 1 skipped) - All passing
  - Flux workflow simulation
  - High resolution workflow
  - Batch processing workflow
  - Memory-constrained workflow
  - Precision workflow simulation
  - Workflow consistency (video test skipped for now)

✅ Performance Benchmarks (5 tests) - All passing
  - VAE decode performance across resolutions
  - Tile size performance comparison
  - Precision mode performance
  - Memory usage patterns
  - Performance consistency

Test Infrastructure:
- Comprehensive mock objects for ComfyUI modules
- Proper fixture setup for VAE, models, and conditioning
- Performance benchmarking with statistical analysis
- Integration testing for workflow simulation
- Proper error handling and edge case testing

Technical Implementation:
- Fixed comfy module import issues
- Created robust mock VAE with proper tensor handling
- Implemented proper test isolation and cleanup
- Added performance consistency testing
- Comprehensive error handling tests

Status: ✅ FULLY RESTORED
- 21 tests total (20 passing, 1 skipped)
- Complete test coverage for VAE decode functionality
- Performance benchmarking infrastructure
- Integration testing for workflows
- Ready for continuous testing and optimization
2025-10-10 22:49:44 -04:00
Nino 0b5cd1d358 Update branding and add real-world performance results
- Renamed to 'RocM Ninodes' with updated branding
- Added real-world performance results: 500s → 110s (78% improvement)
- Added GMTek Evo-X2 Strix Halo setup instructions
- Updated author email to nino2k@proton.me
- Added specific ROCm PyTorch installation commands
- Added optimized ComfyUI startup flags
- Updated GitHub repository URLs to iGavroche/rocm-ninodes
2025-10-03 09:50:59 -04:00
Nino 1e3d3a1cc3 Initial release: RocM-Nino v1.0.0
- Complete ROCM optimization suite for AMD GPUs (gfx1151)
- 6 optimized nodes: VAE decode, KSampler, and performance monitors
- ROCm 6.4+ specific optimizations and memory management
- Easy installation with install.py script
- Comprehensive documentation and example workflows
- Expected 20-40% performance improvement for gfx1151 architecture

Features:
- ROCMOptimizedVAEDecode: Main optimized VAE decode
- ROCMOptimizedVAEDecodeTiled: Advanced tiled VAE decode
- ROCMOptimizedKSampler: Optimized sampling with ROCm tuning
- ROCMOptimizedKSamplerAdvanced: Advanced sampler with extended control
- ROCMVAEPerformanceMonitor: VAE performance analysis
- ROCMSamplerPerformanceMonitor: Sampler performance analysis
2025-10-03 09:37:23 -04:00