nodes/iGavroche-rocm-ninodes
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
136 Commits 3 Branches 7 Tags
f779d67adf4e8900aebc5fd19399ed1caa07e779
Commit Graph
3 Commits
Author SHA1 Message Date
iGavroche 82540c5245 chore(release): bump version to 2.0.11 and update documentation 
- Updated version to 2.0.11 in pyproject.toml and comfyui_manager.json for consistency.
- Removed video chunking from ROCMOptimizedVAEDecode to ensure full video decoding for temporal/causal VAEs, preventing artifacts.
- Added new ROCm Text Generate LTX2 Prompt node, enhancing generative AI capabilities.
- Updated README to reflect new features and improvements in v2.0.11.
- Enhanced changelog with details on changes and fixes in this release.
 2026-03-08 11:35:08 -04:00
Gavroche 471fef9996 ✅ RESTORE TEST SUITE: Comprehensive testing infrastructure 
CRITICAL RESTORATION COMPLETED:
- Restored complete test suite that was accidentally deleted
- Fixed performance regression issues
- Created comprehensive testing infrastructure

Test Suite Components:
✅ Unit Tests (10 tests) - All passing
  - Basic VAE decode functionality
  - Different tile sizes and resolutions
  - Precision modes and batch processing
  - Memory optimization and adaptive tiling
  - Error handling and performance consistency

✅ Integration Tests (6 passed, 1 skipped) - All passing
  - Flux workflow simulation
  - High resolution workflow
  - Batch processing workflow
  - Memory-constrained workflow
  - Precision workflow simulation
  - Workflow consistency (video test skipped for now)

✅ Performance Benchmarks (5 tests) - All passing
  - VAE decode performance across resolutions
  - Tile size performance comparison
  - Precision mode performance
  - Memory usage patterns
  - Performance consistency

Test Infrastructure:
- Comprehensive mock objects for ComfyUI modules
- Proper fixture setup for VAE, models, and conditioning
- Performance benchmarking with statistical analysis
- Integration testing for workflow simulation
- Proper error handling and edge case testing

Technical Implementation:
- Fixed comfy module import issues
- Created robust mock VAE with proper tensor handling
- Implemented proper test isolation and cleanup
- Added performance consistency testing
- Comprehensive error handling tests

Status: ✅ FULLY RESTORED
- 21 tests total (20 passing, 1 skipped)
- Complete test coverage for VAE decode functionality
- Performance benchmarking infrastructure
- Integration testing for workflows
- Ready for continuous testing and optimization
 2025-10-10 22:49:44 -04:00
Gavroche 3c80308891 FIX: Convert tensor to ComfyUI-compatible format (B, H, W, C) 
CRITICAL FIX: Resolved PIL compatibility issue!

Root cause identified:
- Our VAE decode was outputting (B, C, H, W) format
- ComfyUI's save_images expects (B, H, W, C) format
- PIL cannot handle (C, H, W) uint8 data correctly

Solution implemented:
- Convert tensor from (B, C, H, W) to (B, H, W, C) using permute(0, 2, 3, 1)
- Updated validation to check channels in last dimension
- Updated tests to expect new format

Test results:
- (1, 3, 512, 512) format: ❌ PIL Error
- (1, 512, 512, 3) format: ✅ PIL Image created successfully

This should resolve the PIL error:
'Cannot handle this data type: (1, 1, 512), |u1'
 2025-10-10 21:47:33 -04:00