iGavroche-rocm-ninodes/docs/COMPLETE_NAMING_FIX.md

Complete Naming Convention Fix - October 2025

Summary

Fixed ALL naming inconsistencies across the entire ROCm Ninodes project. ComfyUI will now display uniform "ROCm" branding throughout.

Issue

ComfyUI was showing two different naming conventions:

• ❌ Some nodes: "ROCM" (all capitals)
• ❌ Some categories: "RocM" (lowercase 'c')
• Mixed display created unprofessional appearance
• Confusing for users

Solution

Updated ALL instances to use correct "ROCm" branding:

• ✅ Capital R, O, C
• ✅ Lowercase m
• ✅ Consistent everywhere

Files Updated

Node Display Names (rocm_nodes/nodes.py)

NODE_DISPLAY_NAME_MAPPINGS = {
    "ROCMOptimizedCheckpointLoader": "ROCm Checkpoint Loader",  # ✅ Fixed
    "ROCmDiffusionLoader": "ROCm Diffusion Loader",              # ✅ Fixed
    "ROCMOptimizedVAEDecode": "ROCm VAE Decode",                 # ✅ Fixed
    "ROCMOptimizedVAEDecodeTiled": "ROCm VAE Decode Tiled",      # ✅ Fixed
    "ROCMVAEPerformanceMonitor": "ROCm VAE Performance Monitor",  # ✅ Fixed
    "ROCMOptimizedKSampler": "ROCm KSampler",                    # ✅ Fixed
    "ROCMOptimizedKSamplerAdvanced": "ROCm KSampler Advanced",   # ✅ Fixed
    "ROCMSamplerPerformanceMonitor": "ROCm Sampler Performance Monitor", # ✅ Fixed
    "ROCMFluxBenchmark": "ROCm Flux Benchmark",                  # ✅ Fixed
    "ROCMMemoryOptimizer": "ROCm Memory Optimizer",              # ✅ Fixed
    "ROCMLoRALoader": "ROCm LoRA Loader",                        # ✅ Fixed
}

Category Names (All Node Files)

Updated CATEGORY in:

1. rocm_nodes/core/checkpoint.py

CATEGORY = "ROCm Ninodes/Loaders"  # ✅ Was "RocM Ninodes/Loaders"

2. rocm_nodes/core/unet_loader.py

CATEGORY = "ROCm Ninodes/Loaders"  # ✅ Was "RocM Ninodes/Loaders"

3. rocm_nodes/core/lora.py

CATEGORY = "ROCm Ninodes/Loaders"  # ✅ Was "RocM Ninodes/Loaders"

4. rocm_nodes/core/vae.py (3 nodes)

CATEGORY = "ROCm Ninodes/VAE"  # ✅ Was "RocM Ninodes/VAE" (3x)

5. rocm_nodes/core/sampler.py (3 nodes)

CATEGORY = "ROCm Ninodes/Sampling"  # ✅ Was "RocM Ninodes/Sampling" (3x)

6. rocm_nodes/core/monitors.py (2 nodes)

CATEGORY = "ROCm Ninodes/Benchmark"  # ✅ Was "RocM Ninodes/Benchmark"
CATEGORY = "ROCm Ninodes/Memory"     # ✅ Was "RocM Ninodes/Memory"

ComfyUI Display (After Fix)

Node Menu Structure

📁 ROCm Ninodes ✅ (correct capitalization)
   │
   ├─ 📁 Loaders
   │   ├─ ROCm Checkpoint Loader ✅
   │   ├─ ROCm Diffusion Loader ✅
   │   └─ ROCm LoRA Loader ✅
   │
   ├─ 📁 VAE
   │   ├─ ROCm VAE Decode ✅
   │   ├─ ROCm VAE Decode Tiled ✅
   │   └─ ROCm VAE Performance Monitor ✅
   │
   ├─ 📁 Sampling
   │   ├─ ROCm KSampler ✅
   │   ├─ ROCm KSampler Advanced ✅
   │   └─ ROCm Sampler Performance Monitor ✅
   │
   ├─ 📁 Benchmark
   │   └─ ROCm Flux Benchmark ✅
   │
   └─ 📁 Memory
       └─ ROCm Memory Optimizer ✅

Verification

Check 1: No Inconsistent Categories

grep -r "RocM\|ROCM" rocm_nodes/core/*.py | grep "CATEGORY ="

Result: ✅ No matches (all use "ROCm")

Check 2: All Categories Correct

grep "CATEGORY =" rocm_nodes/core/*.py

Result: ✅ All 11 instances show "ROCm Ninodes/*"

Check 3: Display Names

grep "DISPLAY_NAME_MAPPINGS" rocm_nodes/nodes.py -A 15

Result: ✅ All display names use "ROCm"

Statistics

• Files Modified: 7

  • rocm_nodes/nodes.py (display names)
  • rocm_nodes/core/checkpoint.py
  • rocm_nodes/core/unet_loader.py
  • rocm_nodes/core/lora.py
  • rocm_nodes/core/vae.py
  • rocm_nodes/core/sampler.py
  • rocm_nodes/core/monitors.py

• Categories Fixed: 11

  • Loaders: 3 nodes
  • VAE: 3 nodes
  • Sampling: 3 nodes
  • Benchmark: 1 node
  • Memory: 1 node

• Display Names Fixed: 11

  • All now use "ROCm" (not "ROCM")

Before vs After

Before (Mixed Convention) ❌

ComfyUI Node Menu:
├─ RocM Ninodes          ❌ (wrong 'c')
│  ├─ Loaders
│  │  ├─ ROCM Checkpoint Loader  ❌ (all caps)
│  │  └─ ROCM UNet Loader        ❌ (all caps)
│  └─ VAE
│     └─ ROCM VAE Decode         ❌ (all caps)

After (Consistent Convention) ✅

ComfyUI Node Menu:
├─ ROCm Ninodes          ✅ (correct)
│  ├─ Loaders
│  │  ├─ ROCm Checkpoint Loader  ✅
│  │  └─ ROCm Diffusion Loader   ✅
│  └─ VAE
│     └─ ROCm VAE Decode         ✅

Naming Standard (Official)

Correct: "ROCm"

• R - Capital (Radeon)
• O - Capital (Open)
• C - Capital (Compute)
• m - Lowercase (module/platform)

Usage Examples

# Class names
class ROCmDiffusionLoader:     # ✅ Correct

# Display names
"ROCm Checkpoint Loader"        # ✅ Correct

# Categories
"ROCm Ninodes/Loaders"          # ✅ Correct

# Documentation
"ROCm-optimized nodes"          # ✅ Correct

Incorrect Examples

"ROCM Checkpoint Loader"        # ❌ Wrong (all caps)
"RocM Ninodes/Loaders"          # ❌ Wrong (lowercase 'c')
"rocm-optimized nodes"          # ❌ Wrong (all lowercase)
"Rocm Checkpoint Loader"        # ❌ Wrong (only first cap)

Impact

User Experience

• ✅ Professional, consistent appearance
• ✅ Easy to find all nodes (grouped under "ROCm Ninodes")
• ✅ Clear branding matches AMD's official ROCm naming
• ✅ No confusion about which nodes are from this package

Developer Experience

• ✅ Clear naming standards in .cursorrules
• ✅ Easy to maintain consistency
• ✅ Future nodes will follow established pattern
• ✅ No mixed conventions in codebase

Testing Checklist

After restarting ComfyUI:

1. ✅ Check Node Menu

   • Navigate to "Add Node" menu
   • Find "ROCm Ninodes" folder
   • Verify all subfolders show "ROCm" (not "ROCM" or "RocM")

2. ✅ Check Node Names

   • Add a node from each category
   • Verify node titles show "ROCm" prefix
   • Confirm consistent capitalization

3. ✅ Check Existing Workflows

   • Load saved workflows with ROCm nodes
   • Verify nodes still work (internal IDs unchanged)
   • Confirm display names updated

Related Documentation

• .cursorrules - Naming convention guidelines
• docs/NAMING_AND_FIXES_UPDATE.md - Initial naming fixes
• docs/CATEGORY_VERIFICATION.md - Category verification
• docs/WORKFLOW_UPDATE_SUMMARY.md - Workflow file updates

Maintenance

For Future Nodes

When creating new nodes, always use:

class ROCmNewNode:
    CATEGORY = "ROCm Ninodes/CategoryName"
    
NODE_DISPLAY_NAME_MAPPINGS = {
    "ROCmNewNode": "ROCm Node Display Name"
}

Quick Reference

• Branding: ROCm (R-O-C capital, m lowercase)
• Category Prefix: "ROCm Ninodes/"
• Display Name Prefix: "ROCm "

Conclusion

✅ All naming inconsistencies resolved ✅ ComfyUI shows uniform "ROCm" branding ✅ Professional appearance restored ✅ Future nodes have clear standard to follow

No more mixed conventions in ComfyUI!

---

Status: Complete ✅
Date: October 29, 2025
Affected Files: 7 node files, 11 categories, 11 display names
Result: Consistent "ROCm" branding throughout entire project