de5edd7064
Two ComfyUI issues found while testing. 1. Empty output with no error: the Knowledge Base Loader resolved a relative `path` against ComfyUI's working directory, not this package, so the default `knowledge_base/` loaded 0 entries (an empty KB is valid) and every concept became unknown -> empty prompts. Relative paths now resolve against the package root, and the loader warns when the Knowledge Base is empty. 2. Add a `raw` string output (a JSON dump of the node's data) to the Scene Analyzer, Scene Validator, Resolver, Category Splitter, and Prompt Builder nodes, plus a summary `raw` on the Knowledge Base Loader, for inspecting the pipeline in the graph. Adds a shared to_raw_json helper. Tests: package-relative path resolution (independent of cwd), empty-KB warning, raw output content, and updated node metadata/return-arity expectations. Co-authored-by: kunail0804 <kunail0804@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
69 lines
2.5 KiB
Python
69 lines
2.5 KiB
Python
"""Tests for the Knowledge Base Loader ComfyUI node (issue #25)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
|
|
import nodes
|
|
from compiler.common.knowledge_base import KnowledgeBase
|
|
from nodes.knowledge_base_loader_node import KnowledgeBaseLoaderNode
|
|
|
|
|
|
def write_kb(directory, entries: list[dict]) -> str:
|
|
(directory / "hair.json").write_text(json.dumps(entries), encoding="utf-8")
|
|
return str(directory)
|
|
|
|
|
|
def test_node_metadata() -> None:
|
|
assert KnowledgeBaseLoaderNode.RETURN_TYPES == ("KNOWLEDGE_BASE", "STRING", "STRING", "STRING")
|
|
assert KnowledgeBaseLoaderNode.RETURN_NAMES == ("knowledge_base", "warnings", "errors", "raw")
|
|
inputs = KnowledgeBaseLoaderNode.INPUT_TYPES()
|
|
assert "path" in inputs["required"]
|
|
assert "reload" in inputs["optional"]
|
|
|
|
|
|
def test_loads_knowledge_base(tmp_path) -> None:
|
|
path = write_kb(tmp_path, [{"id": "long_hair", "tags": ["long hair"], "category": "hair"}])
|
|
kb, warnings, errors, *_ = KnowledgeBaseLoaderNode().run(path)
|
|
assert isinstance(kb, KnowledgeBase)
|
|
assert kb.get("long_hair") is not None
|
|
assert (warnings, errors) == ("", "")
|
|
|
|
|
|
def test_invalid_knowledge_base_surfaces_sc0004(tmp_path) -> None:
|
|
path = write_kb(tmp_path, [{"id": "x", "tags": ["x"], "category": "nope"}])
|
|
kb, warnings, errors, *_ = KnowledgeBaseLoaderNode().run(path)
|
|
assert kb is None
|
|
assert "SC0004" in errors
|
|
|
|
|
|
def test_relative_path_resolves_against_package(monkeypatch, tmp_path) -> None:
|
|
# Even with an unrelated working directory (as under ComfyUI), the default
|
|
# relative path must load the shipped Knowledge Base, not an empty one.
|
|
monkeypatch.chdir(tmp_path)
|
|
kb, warnings, errors, raw = KnowledgeBaseLoaderNode().run("knowledge_base/")
|
|
assert isinstance(kb, KnowledgeBase)
|
|
assert len(kb) > 100
|
|
assert (warnings, errors) == ("", "")
|
|
assert "entries" in raw
|
|
|
|
|
|
def test_empty_knowledge_base_warns(tmp_path) -> None:
|
|
kb, warnings, errors, raw = KnowledgeBaseLoaderNode().run(str(tmp_path))
|
|
assert len(kb) == 0
|
|
assert "empty" in warnings.lower()
|
|
|
|
|
|
def test_reload_input_is_accepted(tmp_path) -> None:
|
|
path = write_kb(tmp_path, [{"id": "long_hair", "tags": ["long hair"], "category": "hair"}])
|
|
kb, _, _, _ = KnowledgeBaseLoaderNode().run(path, reload=5)
|
|
assert isinstance(kb, KnowledgeBase)
|
|
|
|
|
|
def test_registered_for_comfyui() -> None:
|
|
assert nodes.NODE_CLASS_MAPPINGS["SceneCompilerKnowledgeBaseLoader"] is KnowledgeBaseLoaderNode
|
|
assert (
|
|
nodes.NODE_DISPLAY_NAME_MAPPINGS["SceneCompilerKnowledgeBaseLoader"]
|
|
== "Knowledge Base Loader"
|
|
)
|