de5edd7064
Two ComfyUI issues found while testing. 1. Empty output with no error: the Knowledge Base Loader resolved a relative `path` against ComfyUI's working directory, not this package, so the default `knowledge_base/` loaded 0 entries (an empty KB is valid) and every concept became unknown -> empty prompts. Relative paths now resolve against the package root, and the loader warns when the Knowledge Base is empty. 2. Add a `raw` string output (a JSON dump of the node's data) to the Scene Analyzer, Scene Validator, Resolver, Category Splitter, and Prompt Builder nodes, plus a summary `raw` on the Knowledge Base Loader, for inspecting the pipeline in the graph. Adds a shared to_raw_json helper. Tests: package-relative path resolution (independent of cwd), empty-KB warning, raw output content, and updated node metadata/return-arity expectations. Co-authored-by: kunail0804 <kunail0804@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
"""Regression: nodes must not crash when an upstream stage produced no output.
|
|
|
|
A failed upstream node passes ``None`` down its data output; downstream nodes must
|
|
surface an error instead of raising AttributeError (found in ComfyUI: a failed
|
|
Scene Analyzer crashed the Scene Validator on ``None.to_json()``).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from nodes.category_splitter_node import CategorySplitterNode
|
|
from nodes.prompt_builder_node import PromptBuilderNode
|
|
from nodes.resolver_node import ResolverNode
|
|
from nodes.scene_validator_node import SceneValidatorNode
|
|
|
|
|
|
def test_validator_handles_none_scene() -> None:
|
|
scene, warnings, errors, *_ = SceneValidatorNode().run(None)
|
|
assert scene is None
|
|
assert "no output" in errors.lower()
|
|
|
|
|
|
def test_resolver_handles_none_scene() -> None:
|
|
resolved, _, errors, *_ = ResolverNode().run(None, knowledge_base=object())
|
|
assert resolved is None
|
|
assert errors
|
|
|
|
|
|
def test_resolver_handles_none_knowledge_base() -> None:
|
|
resolved, _, errors, *_ = ResolverNode().run(scene=object(), knowledge_base=None)
|
|
assert resolved is None
|
|
assert errors
|
|
|
|
|
|
def test_category_splitter_handles_none_tags() -> None:
|
|
category_map, _, errors, *_ = CategorySplitterNode().run(None)
|
|
assert category_map is None
|
|
assert errors
|
|
|
|
|
|
def test_prompt_builder_handles_none_category_map() -> None:
|
|
outputs = PromptBuilderNode().run(None)
|
|
assert len(outputs) == len(PromptBuilderNode.RETURN_NAMES)
|
|
assert all(value == "" for value in outputs)
|