From 16ffa7d462623bb879ac4afb8903f8c0d57f1655 Mon Sep 17 00:00:00 2001 From: "Dr.Lt.Data" Date: Fri, 16 May 2025 03:59:10 +0900 Subject: [PATCH] hotfix: potential front error ``` TypeError: Cannot read properties of undefined (reading 'type') ``` https://github.com/ltdrdata/ComfyUI-Impact-Pack/issues/989 --- js/impact-pack.js | 4 ++-- modules/impact/config.py | 2 +- pyproject.toml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/js/impact-pack.js b/js/impact-pack.js index 552684f..644657d 100644 --- a/js/impact-pack.js +++ b/js/impact-pack.js @@ -370,7 +370,7 @@ app.registerExtension({ if(type == 2) { // connect output if(connected){ - if(app.graph._nodes_by_id[link_info.target_id].type == 'Reroute') { + if(app.graph._nodes_by_id[link_info.target_id]?.type == 'Reroute') { app.graph._nodes_by_id[link_info.target_id].disconnectInput(link_info.target_slot); } @@ -392,7 +392,7 @@ app.registerExtension({ } } else { - if(app.graph._nodes_by_id[link_info.origin_id].type == 'Reroute') + if(app.graph._nodes_by_id[link_info.origin_id]?.type == 'Reroute') this.disconnectInput(link_info.target_slot); // connect input diff --git a/modules/impact/config.py b/modules/impact/config.py index bdeddd9..925cb02 100644 --- a/modules/impact/config.py +++ b/modules/impact/config.py @@ -1,7 +1,7 @@ import configparser import os -version_code = [8, 14, 2] +version_code = [8, 14, 3] version = f"V{version_code[0]}.{version_code[1]}" + (f'.{version_code[2]}' if len(version_code) > 2 else '') dependency_version = 24 diff --git a/pyproject.toml b/pyproject.toml index eca1665..342e8b0 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,7 +1,7 @@ [project] name = "comfyui-impact-pack" description = "This node pack offers various detector nodes and detailer nodes that allow you to configure a workflow that automatically enhances facial details. And provide iterative upscaler." -version = "8.14.2" +version = "8.14.3" license = { file = "LICENSE.txt" } dependencies = ["segment-anything", "scikit-image", "piexif", "transformers", "opencv-python-headless", "GitPython", "scipy>=1.11.4"]