Claude/goofy faraday d23e98 (#255)

* refactor(nodes): drop keyframe_batch alias from Easy Image Batch

The keyframe_batch input was a deprecated alias of keyframes_insert,
added in 0.4.1 during PR #246 review to keep pre-rename workflows
loading. The old name only ever existed in unreleased dev builds before
the rename, so no published workflow depends on it and the alias only
cluttered the node with a second IMAGE input.

Remove the input, its parameter, and the alias-routing fallback; the
node now exposes a single keyframes_insert insert input. Tests and the
behavior spec updated; CHANGELOG notes the removal under [Unreleased].

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* docs(policy): make backward compatibility opt-in for Koolook nodes

Invert the default: backward compatibility is no longer a standing
constraint for Koolook-created nodes (the root k_*.py custom nodes).
By default, make the cleanest change — rename/drop/reorder IDs, inputs,
and outputs freely, no deprecation aliases or _v2 suffixes. Compatibility
with saved workflows is only preserved when the maintainer explicitly
says "check backward compatibility".

Forks are explicitly excluded: anything under forks/ (including the
Koolook-original nodes exposed via SKIP_VERSION_SUFFIX) keeps full
back-compat discipline by default, no request needed. The
__koolook_vX_Y_Z collision suffix always applies.

Scoped across the binding instruction files and skills: CLAUDE.md,
copilot-instructions, node-versioning.md, versioning.md, and the
preflight-release / add-external-fork / tdd skills. The preflight
workflows check is reframed as a drift detector for Koolook IDs and a
hard back-compat gate for fork IDs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* docs: clarify keyframe_batch alias removal

* fix: retain keyframe_batch compatibility alias

---------

Co-authored-by: AI Machine <ai.machine@x.baconcph.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
malkuthro
2026-06-20 11:16:38 +02:00
committed by GitHub
co-authored by Claude Opus 4.8 AI Machine
parent 472960b919
commit ba39cb3658
11 changed files with 116 additions and 38 deletions
+9 -3
View File
@@ -44,9 +44,15 @@ ComfyUI-Koolook is a custom-node pack for ComfyUI. Two shipped surfaces:
## Things that bite if you don't know them
- **Node IDs in saved workflows are stable.** Never rename a registered node
ID without a back-compat alias — see
[`docs/maintainers/node-versioning.md`](../docs/maintainers/node-versioning.md).
- **Backward compatibility is opt-in for Koolook-created nodes only** (the root
`k_*.py` custom nodes). For those, make the cleanest change by default —
rename/drop/reorder IDs, inputs, and outputs freely, no aliases or `_v2`
suffixes — unless the maintainer says `check backward compatibility`.
**Fork nodes are different: anything under `forks/` keeps full back-compat
discipline by default** (never rename a fork ID in saved workflows, version
via new suffix/namespace, keep the `__koolook_vX_Y_Z` collision suffix). See
[`docs/maintainers/node-versioning.md`](../docs/maintainers/node-versioning.md)
and [`CLAUDE.md`](../CLAUDE.md) → *Change management*.
- **Third-party code stays out of MAIN.** Modified fork code lives under
`forks/<name>/versions/<vX_Y_Z>/`; raw upstream checkouts live in
`../ComfyUI-Forks/`. See [`forks/README.md`](../forks/README.md) and