* feat(setups): publish success feedback + published-setup discoverability (#227)
Post-publish feedback (issue #227 Part 1):
- POST /koolook/api/setups now returns the on-disk storagePath
- new POST /koolook/api/setups/reveal opens the published-setups folder
(shared _open_dir_in_file_manager helper; the snapshot reveal route was
refactored onto it, behaviour-identical)
- the publish modal renders a success card reusing the snapshot Save dialog's
"Saved to ... Open folder" language (Open folder / Copy path / Close)
instead of closing silently; a draft publish still gets a confirmation
Published discoverability (reuses the tag system, no new schema):
- publishing auto-tags the source workflow `published` -> a "published" badge
in the Workflows tree + the Tags-section "published" pool
- a new "P" toggle in the sidebar Tools row prunes the Workflows tree to
published-only, folders force-expanded, so setups show in their origin
structure; toggling off restores the full tree
- workflowHasTag() shared helper (unit-tested)
Deferred, still open on #227: separate destination/library setting (Part 2),
relocating the storage folder beside the snapshot library, and clearing the
filter when entering Compare mode.
Tests: +server (storagePath, reveal route happy + 404), +client (reveal
client, buildPublishSuccessView view-model), +sidebar (workflowHasTag).
Full suite: 610 passed, 1 skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* feat(setups): store published setups beside the snapshot library (#227)
- the published-setup registry path now derives from the configured snapshot
library (`_configured_dir().parent / koolook-published-setups/setups.json`)
instead of a fixed user-dir folder, so it follows libraryPath /
KFORGELABS_PRESETS. The default config resolves to the same path as before
(target == legacy), so existing default installs are unchanged.
- non-destructive one-time migration: copy a legacy user-dir registry to the
new location when the new one is absent, leaving the original in place.
- sidebar: clear the "P" published filter when entering Compare mode so it
doesn't render both compare columns filtered with no toggle to undo it.
Tests: +tests/server/test_published_setups_relocation.py (path beside library;
migration copy / no-op-when-present / no-op-when-no-legacy). Full suite: 614
passed, 1 skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* style(tests): remove unused pathlib.Path import (ruff F401)
The relocation test only uses the `tmp_path` fixture, not `Path` directly, so
`from pathlib import Path` was unused and failed the Lint & Smoke (ruff) gate.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(setups): address PR #239 review — migration masking + tag persist
- HIGH: a failed legacy->new migration no longer masks real setups with the
bundled sample. The default registry keeps the legacy file as its primary
storage when migration could not produce the new file, so stranded data
stays visible. (+2 tests: keeps-legacy-on-copy-failure / uses-new-on-success)
- MEDIUM/LOW: the publish flow now awaits the `published`-tag persist so the
success card reflects a committed tag (persist failures already surface via
persistMutation's critical toast), and warns when the source workflow could
not be tagged (vanished mid-publish) rather than on a harmless republish.
Full suite: 616 passed, 1 skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(setups): harden migration against partial/corrupt relocation target
Addresses the remaining HIGH from the PR #239 consolidated re-review: a
zero-byte/partial/corrupt setups.json at the relocated path could shadow the
intact legacy registry (existence was treated as proof of migration).
- migration now copies via temp file + atomic os.replace (the same pattern
FileSetupStorage.save_setups uses), so an interrupted copy can never leave
a partial setups.json at the target; failed-copy temp files are cleaned up.
- primary selection is corruption-aware: when the relocated file exists but
does not parse as a setups document while the legacy file is intact, the
registry keeps serving the legacy file and logs a loud diagnostic. The
unreadable file is left untouched (never overwritten) as evidence. A valid
relocated file stays authoritative; if both are corrupt, the relocated path
stays primary so storage diagnostics point at the current location.
Tests (+4): corrupt-target-prefers-intact-legacy (file left untouched),
valid-target-stays-authoritative, both-corrupt-keeps-target, and
interrupted-copy-leaves-no-partial-target-and-no-tmp-litter.
Full suite: 620 passed, 1 skipped.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
malkuthro