malkuthroandClaude Opus 4.7
e95c12f6a9
* docs(forks): finalize de-vendoring audit trail (closes #28) The v0.1.4 / v0.1.5 release cycle untracked six vendored third-party trees from MAIN's git index (`git rm -r --cached`, then added to `.gitignore`), which fixed the Comfy Registry's static-scanner miscount (44 -> 8 nodes in ComfyUI-Manager) and shrank the published archive by ~3.7 MB. That part of issue #28 was already shipped. Issue #28's remaining acceptance criteria were the audit-trail bits: - list each removed tree in `forks/THIRD_PARTY.md` with upstream URL + license, and - record any modified files that were promoted into proper fork wrappers under `forks/<package>/versions/<vX_Y_Z>/`. This commit adds a "De-vendored upstream code (untracked in v0.1.4 / v0.1.5)" section to `forks/THIRD_PARTY.md` covering all six trees: - `upscaler_FIX/github_repos/ComfyUI-SuperUltimateVaceTools/` - `upscaler_FIX/github_repos/ComfyUI-multigpu/` - `upscaler_FIX/github_repos/debugg/` - `nuke_CAM_exporter/_Utils-CAM-track/Github-Repos/Comfyui-Animatedfiff-evolved/` - `nuke_CAM_exporter/_Utils-CAM-track/Github-Repos/Comfyui-kjnodes/` - `nuke_CAM_exporter/wrapper_FIX/` (kijai/ComfyUI-WanVideoWrapper) None of the six were promoted to tracked fork wrappers — the `wrapper_FIX/` work in particular was incomplete (token-count alignment fix between Wan 14B and FunCamera) and the upstream pin was never recorded, so it'll be redone from scratch against current upstream when needed. Pure docs change. No package code touched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(forks): full #28 closure — add manifest entries + verbatim-paths note Addressing /review-pr findings on the previous commit b029570: HIGH (CONFIRMED): "Closes #28" was overstated against issue #28's literal acceptance criterion (2) — registering each removed tree in `forks/forks_manifest.yaml` with `source_repo`/`source_ref`/ `pinned_commit`/`local_paths`. The previous commit only delivered the THIRD_PARTY.md audit table (criterion (3)). This commit adds six `status: "removed"` entries to `forks/forks_manifest.yaml` (one per de-vendored tree) with: - `source_repo`: known upstream URL where determinable, "unknown" with vendor-time-no-pin caveat otherwise - `source_ref` / `pinned_commit: null`: honest about missing pins - `local_paths`: actual former paths (matches v0.1.0 git tree) - `removed_at: 2026-05-03`, `removed_in_release: "0.1.4 / 0.1.5"` - `license`: mirrors THIRD_PARTY.md ("unverified" / "GPL-3.0" / "n/a" / "assumed GPL-3.0" — last verified 2026-05-03 for kjnodes) - `notes`: cross-link back to THIRD_PARTY.md "De-vendored upstream code" section LOW (CONFIRMED but no-action): typo `Comfyui-Animatedfiff-evolved` and mixed `Comfyui-` / `ComfyUI-` casing on rows 114-115 of THIRD_PARTY.md. Verifier confirmed both reflect actual former on-disk folder names (via `git ls-tree v0.1.0`) and are intentional historical record. Added a one-paragraph preamble note above the table making this explicit so future readers don't try to "fix" the typo and break the audit trail. HIGH (DOWNGRADED to LOW by verifier): "License unverified shipped to PyPI / Comfy Registry" claim was a false-positive premise — verifier checked `gh run list --workflow=publish.yml` and found every push-to- main publish for v0.1.0/v0.1.1/v0.1.3 failed; the first successful Comfy Registry publish was the v0.1.4-prep dispatch on 2026-05-03, post-untrack. The residual concern (GitHub release source tarballs) is real but standard for any post-untrack project; preamble now states this explicitly so future readers don't mis-read "License unverified" as "shipped to users without a license check". Pure docs / metadata. No package code touched. Closes #28. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Forks Workflow
This folder is the single source for all fork tracking metadata inside MAIN.
Purpose
- Keep modified forked code in MAIN under versioned paths (for GitHub tracking).
- Keep raw external checkouts outside MAIN under
../ComfyUI-Forks(for upstream reference/sync). - Keep all fork metadata in one place:
forks/forks_manifest.yamlforks/THIRD_PARTY.md
Folder Layout in MAIN
forks/radiance_koolook/__init__.py-> package entrypoint used by root__init__.pyforks/radiance_koolook/versions/v1_0_1/-> local modified node sourcesforks/radiance_koolook/versions/<version>/UPSTREAM_PIN.yaml-> exact upstream parity pin
External Folder Naming (outside MAIN)
Root: ../ComfyUI-Forks
- Pinned baseline checkout:
radiance-v1.0.1-koolook
- Rolling upstream checkout:
radiance-main-upstream
These names are referenced from forks/forks_manifest.yaml.
Referencing System
For each fork entry in forks/forks_manifest.yaml:
source_repo= canonical upstream URLsource_ref= release/tag (or baseline descriptor)pinned_commit= exact reproducible commit hashexternal_checkout.relative_path_from_forks_root= pinned raw reference folderexternal_checkout.upstream_tracking_path_from_forks_root= rolling upstream folderlocal_paths= files tracked in MAIN
Tagging Policy (from now on)
- MAIN repo tags use SemVer:
vMAJOR.MINOR.PATCH. - Local fork version folders use underscore variant of the same version:
v1_0_1,v2_3_3, etc.
- Node mapping namespace suffixes must match folder versions:
__koolook_v1_0_1,__koolook_v2_3_3, etc.
- Keep
source_ref+pinned_commitinforks/forks_manifest.yamlandUPSTREAM_PIN.yaml.
Upgrade Flow Example (Radiance)
- Compare current local version (
forks/radiance_koolook/versions/v1_0_1) with pinned raw baseline (../ComfyUI-Forks/radiance-v1.0.1-koolook). - Pull latest upstream in
../ComfyUI-Forks/radiance-main-upstream. - Create a new local version folder in MAIN, e.g.
forks/radiance_koolook/versions/v2_3_3. - Port/validate modifications.
- Namespace node IDs for that version.
- Add new entry/update metadata in
forks/forks_manifest.yaml.
Rule of Thumb
- If it is modified production code -> keep in MAIN under
forks/.../versions/... - If it is raw upstream reference -> keep outside MAIN under
../ComfyUI-Forks